Re: [PATCH 00/46] Support for cut-down Linux syscalls

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:09 Markos Chandras wrote: The following patches prefer the old system call if both syscalls are present. For example, if __NR_open and __NR_openat are defined, then open() will use the __NR_open syscall. If the __NR_open syscall is not defined, then open()

Re: [PATCH 01/46] chmod: Use fchmodat if arch does not have the chmod syscall

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:10 Markos Chandras wrote: +int chmod(const char* path, mode_t mode) const char *path, not const char* path. seems to apply to many patches in this series. -mike signature.asc Description: This is a digitally signed message part.

Re: [PATCH 01/46] chmod: Use fchmodat if arch does not have the chmod syscall

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:10 Markos Chandras wrote: +#if defined(__NR_fchmodat) ! defined(__NR_chmod) also, !defined rather than ! defined -mike signature.asc Description: This is a digitally signed message part. ___ uClibc mailing list

Re: [PATCH 01/46] chmod: Use fchmodat if arch does not have the chmod syscall

2012-11-17 Thread Markos Chandras
On Sat, Nov 17, 2012 at 8:25 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 13 November 2012 06:31:10 Markos Chandras wrote: +#if defined(__NR_fchmodat) ! defined(__NR_chmod) also, !defined rather than ! defined -mike Hi Mike, Thanks for the review. I will do the necessary

Re: [PATCH 15/46] dup3: Add dup3 syscall

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:24 Markos Chandras wrote: --- /dev/null +++ b/libc/sysdeps/linux/common/dup3.c ah, i already added dup3 +#if defined(__NR_dup3) i forgot this though ... just added -mike signature.asc Description: This is a digitally signed message part.

Re: [PATCH 22/46] fork: Use clone if arch does not have the fork syscall

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:31 Markos Chandras wrote: +pid_t __libc_fork(void) +{ + pid_t pid; + pid = INLINE_SYSCALL(clone, 4, SIGCHLD, NULL, NULL, NULL); merge the definition assignment + if (pid0) { if (pid 0) { + __set_errno(-pid); +

Re: [PATCH 33/46] ustat: Return ENOSYS if ustat syscall is not defined

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:42 Markos Chandras wrote: +#if ! defined(__NR_ustat) +/* + * ustat syscall is deprecated and statfs or fstatfs should + * be used instead. There is no way to provide a wrapper for the + * newer syscalls, so just mark this syscall as unimplemented + */ +int

Re: [PATCH 38/46] llseek: Use the llseek system call if defined

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:47 Markos Chandras wrote: -#if defined __NR__llseek defined __UCLIBC_HAS_LFS__ +#if (defined __NR__llseek ||defined __NR_llseek) defined needs a space after that || loff_t lseek64(int fd, loff_t offset, int whence) { loff_t result; +#if

Re: [PATCH 46/46] Config.in: Introduce symbol for arches without deprecated syscalls

2012-11-17 Thread Mike Frysinger
On Tuesday 13 November 2012 06:31:55 Markos Chandras wrote: --- a/extra/Configs/Config.in.arch +++ b/extra/Configs/Config.in.arch +config ARCH_HAS_NO_DEPRECATED_SYSCALLS where is this actually used ? i didn't see it in the patches posted. also, let's avoid xxx_NO_xxx from now on. it makes

Re: [PATCH 45/46] libc/ipc: Don't pass IPC_64 to arches that don't need it

2012-11-17 Thread Mike Frysinger
On Thursday 15 November 2012 22:56:58 Rich Felker wrote: On Tue, Nov 13, 2012 at 11:31:54AM +, Markos Chandras wrote: --- a/extra/Configs/Config.in.arch +++ b/extra/Configs/Config.in.arch +config ARCH_HAS_NO_OLD_IPC + bool Disable support for the old IPC interface + default n

Re: [PATCH 46/46] Config.in: Introduce symbol for arches without deprecated syscalls

2012-11-17 Thread Markos Chandras
On Sat, Nov 17, 2012 at 8:40 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 13 November 2012 06:31:55 Markos Chandras wrote: --- a/extra/Configs/Config.in.arch +++ b/extra/Configs/Config.in.arch +config ARCH_HAS_NO_DEPRECATED_SYSCALLS where is this actually used ? i didn't see it

Re: [PATCH 45/46] libc/ipc: Don't pass IPC_64 to arches that don't need it

2012-11-17 Thread Markos Chandras
On Sat, Nov 17, 2012 at 8:41 PM, Mike Frysinger vap...@gentoo.org wrote: On Thursday 15 November 2012 22:56:58 Rich Felker wrote: On Tue, Nov 13, 2012 at 11:31:54AM +, Markos Chandras wrote: --- a/extra/Configs/Config.in.arch +++ b/extra/Configs/Config.in.arch +config

Re: [PATCH] string/microblaze: Fix for little-endian

2012-11-17 Thread Mike Frysinger
On Friday 21 September 2012 01:38:41 Steve Bennett wrote: --- a/libc/string/microblaze/memcpy.S +++ b/libc/string/microblaze/memcpy.S +#ifdef __MICROBLAZEEL__ + #define BSLLI bsrli + #define BSRLI bslli +#else + #define BSLLI bslli + #define BSRLI bsrli +#endif for

Re: utils/getconf.c on MacOS X

2012-11-17 Thread Mike Frysinger
On Thursday 20 September 2012 04:38:20 Waldemar Brodkorb wrote: What might be the best solution to resolve this? don't bother building it ? i can't see why it would be useful. -mike signature.asc Description: This is a digitally signed message part.

Re: [PATCH 45/46] libc/ipc: Don't pass IPC_64 to arches that don't need it

2012-11-17 Thread Mike Frysinger
On Saturday 17 November 2012 15:44:23 Markos Chandras wrote: On Sat, Nov 17, 2012 at 8:41 PM, Mike Frysinger vap...@gentoo.org wrote: On Thursday 15 November 2012 22:56:58 Rich Felker wrote: On Tue, Nov 13, 2012 at 11:31:54AM +, Markos Chandras wrote: --- a/extra/Configs/Config.in.arch