Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-05 Thread Mike Frysinger
On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote: > +#ifndef O_CLOEXEC > +# define O_CLOEXEC 0 > +#endif it should be defined by the C library headers. if it isnt, then the port needs updating and the build should fail. so please drop this cruft. -mike signature.asc Description: Th

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-05 Thread Denys Vlasenko
>On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote: >> +#ifndef O_CLOEXEC >> +# define O_CLOEXEC 0 >> +#endif > >it should be defined by the C library headers. if it isnt, then the port >needs updating and the build should fail. so please drop this cruft. You probably was thinking abo

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-05 Thread Mike Frysinger
On Saturday 05 September 2009 17:55:26 Denys Vlasenko wrote: > >On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote: > >> +#ifndef O_CLOEXEC > >> +# define O_CLOEXEC 0 > >> +#endif > > > >it should be defined by the C library headers. if it isnt, then the port > >needs updating and the bui

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-05 Thread Denys Vlasenko
On Saturday 05 September 2009 23:55, Mike Frysinger wrote: > On Saturday 05 September 2009 17:55:26 Denys Vlasenko wrote: > > >On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote: > > >> +#ifndef O_CLOEXEC > > >> +# define O_CLOEXEC 0 > > >> +#endif > > > > > >it should be defined by the C

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-05 Thread Mike Frysinger
On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote: > On Saturday 05 September 2009 23:55, Mike Frysinger wrote: > > On Saturday 05 September 2009 17:55:26 Denys Vlasenko wrote: > > > >On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote: > > > >> +#ifndef O_CLOEXEC > > > >> +# defi

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 08:18, Mike Frysinger wrote: > On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote: > > On Saturday 05 September 2009 23:55, Mike Frysinger wrote: > > > On Saturday 05 September 2009 17:55:26 Denys Vlasenko wrote: > > > > >On Saturday 05 September 2009 16:04:36 D

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 06:07:04 Denys Vlasenko wrote: > On Sunday 06 September 2009 08:18, Mike Frysinger wrote: > > On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote: > > > On Saturday 05 September 2009 23:55, Mike Frysinger wrote: > > > > On Saturday 05 September 2009 17:55:26 Deny

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 16:44, Mike Frysinger wrote: > On Sunday 06 September 2009 06:07:04 Denys Vlasenko wrote: > > On Sunday 06 September 2009 08:18, Mike Frysinger wrote: > > > On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote: > > > > On Saturday 05 September 2009 23:55, Mike Fry

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 11:01:26 Denys Vlasenko wrote: > On Sunday 06 September 2009 16:44, Mike Frysinger wrote: > > On Sunday 06 September 2009 06:07:04 Denys Vlasenko wrote: > > > On Sunday 06 September 2009 08:18, Mike Frysinger wrote: > > > > On Saturday 05 September 2009 18:05:32 Denys Vl

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 17:27, Mike Frysinger wrote: > > > > > > > > >> +#ifndef O_CLOEXEC > > > > > > > > >> +# define O_CLOEXEC 0 > > > > > > > > >> +#endif > > > > > > > > > > > > > > > > > >it should be defined by the C library headers. if it isnt, > > > > > > > > > then the port needs upd

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Mike Frysinger
On Sun, Sep 6, 2009 at 3:56 PM, Denys Vlasenko wrote: > Then I do not understand what exactly you are saying. i'll break it down. these things need to happen: - revert all this #ifndef O_CLOEXEC - import __ASSUME_O_CLOEXEC from glibc into our kernel-features.h - remove the #if 0 in all the bit

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 23:43, Mike Frysinger wrote: > On Sun, Sep 6, 2009 at 3:56 PM, Denys Vlasenko wrote: > > Then I do not understand what exactly you are saying. > > i'll break it down. these things need to happen: > - revert all this #ifndef O_CLOEXEC > - import __ASSUME_O_CLOEXEC fro

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-10-07 Thread Mike Frysinger
On Sunday 06 September 2009 20:41:28 Denys Vlasenko wrote: > On Sunday 06 September 2009 23:43, Mike Frysinger wrote: > > On Sun, Sep 6, 2009 at 3:56 PM, Denys Vlasenko wrote: > > > Then I do not understand what exactly you are saying. > > > > i'll break it down. these things need to happen: > >