Re: [uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360

2010-08-18 Thread Greg Ungerer
Hi Philippe, Philippe De Muyter wrote: m68knommu : Fix strace support for 68328/68360 strace enabled is marked using the `flags' field of the `thread_info' struct. 68360 version of entry.S did test a wrong bit in a wrong structure (task_struct). 68328 version of entry.S did test the right bit

[uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360

2010-08-17 Thread Philippe De Muyter
m68knommu : Fix strace support for 68328/68360 strace enabled is marked using the `flags' field of the `thread_info' struct. 68360 version of entry.S did test a wrong bit in a wrong structure (task_struct). 68328 version of entry.S did test the right bit in the right structure, but wrongly, becaus

Re: [uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360

2010-08-17 Thread Geert Uytterhoeven
On Tue, Aug 17, 2010 at 17:39, Philippe De Muyter wrote: > On Tue, Aug 17, 2010 at 11:14:32AM -0400, Mike Frysinger wrote: >> >> unless i'm missing something, you're only changing whitespace here. > > That's true, > >> and these account for more than half the patch.  please keep >> whitespace chan

Re: [uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360

2010-08-17 Thread Philippe De Muyter
On Tue, Aug 17, 2010 at 11:14:32AM -0400, Mike Frysinger wrote: > > unless i'm missing something, you're only changing whitespace here. That's true, > and these account for more than half the patch. please keep > whitespace changes separate from real changes. but that makes comparing the resul

Re: [uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360

2010-08-17 Thread Mike Frysinger
On Tue, Aug 17, 2010 at 11:11 AM, Philippe De Muyter wrote: >  do_trace: > -       movel   #-ENOSYS,%sp@(PT_OFF_D0)        /* needed for strace*/ > +       movel   #-ENOSYS,%sp@(PT_OFF_D0) /* needed for strace*/ >        subql   #4,%sp > > -1:     movel   %d0,%sp@(PT_OFF_D0)             /* save the

[uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360

2010-08-17 Thread Philippe De Muyter
strace is enabled using the `flags' field of the `thread_info' struct. 68360 version of entry.S did test a wrong bit in a wrong structure (task_struct). 68328 version of entry.S did test the right bit in the right structure, but wrongly, because the `flags' field is 32 bit wide, while the used asse