Re: [uClinux-dev] [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization

2012-04-27 Thread Ezequiel García
Hi Greg, Just some very minor typos On Thu, Apr 26, 2012 at 10:14 AM, wrote: > > +/* > + *     Define macros to ease the pain of setting up the GPIO tables. There > + *     is two cases we need to deal with here, they cover all currently There *are* two cases? > + *     available ColdFire

Re: [uClinux-dev] [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization

2012-04-26 Thread Philippe De Muyter
Hello Greg, On Thu, Apr 26, 2012 at 11:14:51PM +1000, g...@snapgear.com wrote: > From: Greg Ungerer > ... > > +/* > + * Define macros to ease the pain of setting up the GPIO tables. There > + * is two cases we need to deal with here, they cover all currently > + * available ColdFire GPIO

Re: [uClinux-dev] [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization

2012-04-26 Thread Greg Ungerer
Hi Ezequiel, On 04/26/2012 11:29 PM, Ezequiel García wrote: Hi Greg, Just some very minor typos On Thu, Apr 26, 2012 at 10:14 AM, wrote: +/* + * á á Define macros to ease the pain of setting up the GPIO tables. There + * á á is two cases we need to deal with here, they cover all cur

[uClinux-dev] [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization

2012-04-26 Thread gerg
From: Greg Ungerer We have very large tables in the ColdFire CPU GPIO setup code that essentially boil down to 2 distinct types of GPIO pin initiaization. Using 2 macros we can reduce these large tables to at most a dozen lines of setup code, and in quite a few cases a single table entry. Introd