[uClinux-dev] Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

2009-11-25 Thread Greg Ungerer
Mike Frysinger wrote: From: Jie Zhang The mmu code uses the copy_*_user_page() variants in access_process_vm() rather than copy_*_user() as the former includes an icache flush. This is important when doing things like setting software breakpoints with gdb. So switch the nommu code over to do t

[uClinux-dev] Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

2009-12-02 Thread David Howells
Mike Frysinger wrote: > - len -= copy_to_user((void *) addr, buf, len); > + copy_to_user_page(vma, NULL, NULL, > + (void *) addr, buf, len); > else if (!write && vma->vm_flags & VM_MAYREAD) > -

[uClinux-dev] Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

2009-12-02 Thread David Howells
Mike Frysinger wrote: > The mmu code uses the copy_*_user_page() variants in access_process_vm() > rather than copy_*_user() as the former includes an icache flush. This is > important when doing things like setting software breakpoints with gdb. > So switch the nommu code over to do the same.

[uClinux-dev] Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

2009-12-08 Thread David Howells
Mike Frysinger wrote: > + copy_to_user_page(vma, NULL, NULL, > + (void *) addr, buf, len); > ... > + copy_from_user_page(vma, NULL, NULL, > + buf, (void *) addr, len); I think th

[uClinux-dev] Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

2009-12-08 Thread David Howells
Jie Zhang wrote: > I agree on using 0 instead of NULL. But for !MMU, I think, vaddr is always as > same as addr. So we don't need to pass it? FRV flushes the vaddr because in MMU mode the cache flush instructions take virtual addresses, so if we pass addr as vaddr, I can use the same cache flush

[uClinux-dev] Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

2009-12-08 Thread Mike Frysinger
On Tuesday 08 December 2009 09:19:27 David Howells wrote: > Jie Zhang wrote: > > I agree on using 0 instead of NULL. But for !MMU, I think, vaddr is > > always as same as addr. So we don't need to pass it? > > FRV flushes the vaddr because in MMU mode the cache flush instructions take > virtual a