Re: [uclinux-dist-devel] [PATCH 2/2] serial: bfin-uart: Remove ASYNC_CTS_FLOW flag for hardware automatic CTS.

2011-12-09 Thread Alan Cox
> +#ifdef CONFIG_SERIAL_BFIN_CTSRTS > uart->port.flags |= ASYNC_CTS_FLOW; > +#endif As an aside could the cts/hard cts etc be passed as properties to the platform device rather than ifdeffed ? Alan ___ Uclinux-dist-devel mailing li

Re: [uclinux-dist-devel] [PATCH] serial: bfin-sport-uart: Add tty ASYNC_CTS_FLOW flag to do CTS flow control.

2011-12-06 Thread Alan Cox
>port.flags |= ASYNC_CTS_FLOW; > + } > > res = platform_get_resource(pdev, IORESOURCE_IO, 1); > if (res == NULLA Acked-by: Alan Cox ___ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel

Re: [uclinux-dist-devel] [PATCH 2/2] serial: bfin-sport-uart: Request CTS GPIO PIN when the sport emulated serial device starts up.

2011-12-06 Thread Alan Cox
ails in that early stage. > > Signed-off-by: Sonic Zhang Acked-by: Alan Cox ___ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel

Re: [uclinux-dist-devel] [PATCH 2/2] serial: bfin-uart: remove redundant CTS check for hardware CTS control.

2011-12-05 Thread Alan Cox
On Mon, 5 Dec 2011 18:13:11 +0800 Sonic Zhang wrote: > From: Sonic Zhang > > Blackfin hardware CTS control generate interrupt for both CTS on and off. > > Signed-off-by: Sonic Zhang Both Acked-by: Alan Cox ___ Uclinux-dist-dev

Re: [uclinux-dist-devel] [PATCH] serial: bfin-uart: Request CTS GPIO PIN when the serial device starts up.

2011-12-05 Thread Alan Cox
> Signed-off-by: Sonic Zhang Acked-by: Alan Cox ___ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel

Re: [uclinux-dist-devel] [PATCH v2] serial:bfin_uart: Put TX IRQ in individual platform resource.

2011-08-11 Thread Alan Cox
On Thu, 11 Aug 2011 16:03:52 +0800 Sonic Zhang wrote: > Hi Alan, > > Any comments? > > Sonic Zhang Fine by me - doesn't really touch any tty specific code or tty interfacing code anyway ___ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.

Re: [Uclinux-dist-devel] [RFC] [PATCH] watchdog_info separation and constify

2010-01-19 Thread Alan Cox
On Tue, 19 Jan 2010 22:17:59 +0100 Wim Van Sebroeck wrote: > Hi All, > > please comment on following patch. Why move them out - why not just make them const ? ___ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin

Re: [Uclinux-dist-devel] [PATCH] Blackfin: sync termios header changes with x86

2009-06-12 Thread Alan Cox
> -#define FIOQSIZE 0x545E > +#define TIOCGHAYESESP 0x545E /* Get Hayes ESP configuration */ > +#define TIOCSHAYESESP 0x545F /* Set Hayes ESP configuration */ > +#define FIOQSIZE 0x5460 Umm.. probably better to leave FIOQSIZE where it is ;) The HAYES ones are obsolete for a specific

Re: [Uclinux-dist-devel] [PATCH 04/11] Blackfin SPORT UART: fix overrun errors

2009-06-03 Thread Alan Cox
> since the serial stuff is in a bit of orphaned state (going by > MAINTAINERS), should i merge the other changes through the Blackfin > tree ? The other bits are all merged into the ttydev tree Alan ___ Uclinux-dist-devel mailing list Uclinux-dist-dev

Re: [Uclinux-dist-devel] [PATCH] tty: bfin_jtag_comm: emulate a TTY over the Blackfin EMUDAT/JTAG interface

2009-06-03 Thread Alan Cox
On Tue, 2 Jun 2009 15:25:34 -0400 Mike Frysinger wrote: > The Blackfin JTAG interface has a 4 byte generic data field (EMUDAT). With > a little creative thinking, we can turn this into a TTY device. Nifty - queued ___ Uclinux-dist-devel mailing list

Re: [Uclinux-dist-devel] [PATCH 04/11] Blackfin SPORT UART: fix overrun errors

2009-06-03 Thread Alan Cox
> > This should have no effect on a modern kernel. > > well, we wouldnt be making changes if we werent seeing data overruns today If it has an effect then something else is going on. > > > There is 64K of queueing between you and the ldisc nowdays. > > i dont think that really matters ... we do

Re: [Uclinux-dist-devel] [PATCH 04/11] Blackfin SPORT UART: fix overrun errors

2009-06-03 Thread Alan Cox
On Tue, 2 Jun 2009 03:11:33 -0400 Mike Frysinger wrote: > From: Cliff Cai > > Push the ty_flip_buffer_push() call from the IRQ handler to a timer so as > to improve performance and decrease likelihood of overruns. This should have no effect on a modern kernel. There is 64K of queueing between