Re: [jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2007-01-22 Thread Adam Lally
On 1/20/07, Marshall Schor <[EMAIL PROTECTED]> wrote: The impl of JCas TOP has code in it to copy into the newly created feature structure in the CAS, the CAS's current sofa ref: if (casImpl.isAnnotationType(jcasType.casTypeCode)) { casImpl.setSofaFeat(addr, casImpl.getSofaRef()); But

Re: [jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2007-01-22 Thread Adam Lally
On 1/20/07, Marshall Schor <[EMAIL PROTECTED]> wrote: There's a general "rule" in Java that you should not store a ref to a partially-initialized instance in another object, because it allows another thread to potentially access a Java Object that is not yet fully initialized. The use of JCasReg

Re: [jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2007-01-20 Thread Marshall Schor
The impl of JCas TOP has code in it to copy into the newly created feature structure in the CAS, the CAS's current sofa ref: if (casImpl.isAnnotationType(jcasType.casTypeCode)) { casImpl.setSofaFeat(addr, casImpl.getSofaRef()); But this seems to not be general enough. I think it should

Re: [jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2007-01-20 Thread Marshall Schor
There's a general "rule" in Java that you should not store a ref to a partially-initialized instance in another object, because it allows another thread to potentially access a Java Object that is not yet fully initialized. The use of JCasRegistry might be doing this. It stores into an exter

[jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2007-01-17 Thread Adam Lally (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lally resolved UIMA-10. Resolution: Fixed Assignee: Marshall Schor (was: Adam Lally) Refactoring complete. Assigning to Marsha

[jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2006-12-28 Thread Marshall Schor (JIRA)
[ http://issues.apache.org/jira/browse/UIMA-10?page=all ] Marshall Schor resolved UIMA-10. Resolution: Fixed Assignee: Adam Lally (was: Marshall Schor) Thanks for pointing out the need to switch more things over to using JCas instead of JCasImpl.

[jira] Resolved: (UIMA-10) Split JCas into interface and implementation

2006-12-25 Thread Marshall Schor (JIRA)
[ http://issues.apache.org/jira/browse/UIMA-10?page=all ] Marshall Schor resolved UIMA-10. Resolution: Fixed Assignee: Adam Lally (was: Marshall Schor) This is now done. JCasGen has been fixed also to generate the right cover classes. Should we