Re: Lucas NOTICE file

2009-09-04 Thread Thilo Goetz
Rico Landefeld wrote: > I don't agree. There are also NotNullPredicates used in the > AnnotationTokenStream class, which avoid null checks of iterator > values. This is a really nice feature to clean up the code because > iterators are heavily used in this class. > > Rico I don't care either way.

Re: Lucas NOTICE file

2009-09-03 Thread Marshall Schor
Jörn Kottmann wrote: > Thilo Goetz wrote: >> The NOTICE file for Lucas currently does not list any >> external dependencies. However, looking at Lucas after >> it's been built, it seems to me we'll be shipping the >> google-collections.jar. > > The google collections jars is in most places just

Re: Lucas NOTICE file

2009-09-03 Thread Rico Landefeld
I don't agree. There are also NotNullPredicates used in the AnnotationTokenStream class, which avoid null checks of iterator values. This is a really nice feature to clean up the code because iterators are heavily used in this class. Rico On Thu, Sep 3, 2009 at 5:13 PM, Marshall Schor wrote: > >

Re: Lucas NOTICE file

2009-09-03 Thread Marshall Schor
Thilo Goetz wrote: > The NOTICE file for Lucas currently does not list any > external dependencies. However, looking at Lucas after > it's been built, it seems to me we'll be shipping the > google-collections.jar. Is that correct? We ship > everything that ends up in lib, and nothing else? >

Re: Lucas NOTICE file

2009-09-03 Thread Jörn Kottmann
Thilo Goetz wrote: The NOTICE file for Lucas currently does not list any external dependencies. However, looking at Lucas after it's been built, it seems to me we'll be shipping the google-collections.jar. The google collections jars is in most places just use to get an empty iterator, and in

Lucas NOTICE file

2009-09-03 Thread Thilo Goetz
The NOTICE file for Lucas currently does not list any external dependencies. However, looking at Lucas after it's been built, it seems to me we'll be shipping the google-collections.jar. Is that correct? We ship everything that ends up in lib, and nothing else? Thanks, Thilo