Re: Refactoring: org.apache.uima.cas.impl.ArrayFSImpl

2009-07-08 Thread Thilo Goetz
Marshall Schor wrote: > +1 -Marshall > > Jörn Kottmann wrote: >> Marshall Schor wrote: >>> +1 to remove it, from me, but Thilo could take a look too... >>> >>> I commented it out to test removing it, and didn't see any compile >>> errors. (didn't commit) >>> >> Actually I started to migrate the

Re: Refactoring: org.apache.uima.cas.impl.ArrayFSImpl

2009-07-08 Thread Marshall Schor
+1 -Marshall Jörn Kottmann wrote: > Marshall Schor wrote: >> +1 to remove it, from me, but Thilo could take a look too... >> >> I commented it out to test removing it, and didn't see any compile >> errors. (didn't commit) >> > Actually I started to migrate the cas.impl package to our > new gene

Re: Refactoring: org.apache.uima.cas.impl.ArrayFSImpl

2009-07-08 Thread Jörn Kottmann
Marshall Schor wrote: +1 to remove it, from me, but Thilo could take a look too... I commented it out to test removing it, and didn't see any compile errors. (didn't commit) Actually I started to migrate the cas.impl package to our new generic interfaces and have seen a few classes which hav

Re: Refactoring: org.apache.uima.cas.impl.ArrayFSImpl

2009-07-08 Thread Marshall Schor
+1 to remove it, from me, but Thilo could take a look too... I commented it out to test removing it, and didn't see any compile errors. (didn't commit) -Marshall Jörn Kottmann wrote: > Hi, > > the class has private constructor which is never used. > Is there a reason for it ? > > Otherwise I wou

Refactoring: org.apache.uima.cas.impl.ArrayFSImpl

2009-07-07 Thread Jörn Kottmann
Hi, the class has private constructor which is never used. Is there a reason for it ? Otherwise I would suggest to delete it. Jörn