Re: Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-17 Thread Marshall Schor
Thilo Goetz wrote: Marshall Schor wrote: Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. It might be good to clean these up. Typically, they are not changed, because that kind of a

Re: Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-17 Thread Marshall Schor
Adam Lally wrote: On 1/12/07, Marshall Schor [EMAIL PROTECTED] wrote: Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. I'm not sure what you mean exactly - did you mean because the

Re: Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-17 Thread Adam Lally
On 1/17/07, Marshall Schor [EMAIL PROTECTED] wrote: I don't think you need to remove catch blocks from user code. If the try/catch is left in, then the user would get the warning that we're getting. No, this is a different situation. void someMethod() throw SomeException { //Not a compile

Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-12 Thread Marshall Schor
Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. It might be good to clean these up. Typically, they are not changed, because that kind of a change in an API breaks user code. I'm

Re: Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-12 Thread Thilo Goetz
Marshall Schor wrote: Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. It might be good to clean these up. Typically, they are not changed, because that kind of a change in an API