Re: Bug#918916: Unicorn not reporting proper version for gemfile?

On 1/12/19, Dominik George wrote: >>The problem is not in Unicorn. The problem is in gem2deb which >>generated incorrect unicorn-0.gemspec for the package. > > OK... But, why was it fixed when I rebuilt with the patch? Different gem2deb versions? Have you tried to rebuild it without that patch?

Re: Bug#918916: Unicorn not reporting proper version for gemfile?

>I've checked debian's git, this patch was introduced when >ENV["VERSION"] was required to use the gemspec. Now as the upstream >gemspec provides the same it's not required. > >The problem is not in Unicorn. The problem is in gem2deb which >generated incorrect unicorn-0.gemspec for the package. OK

Re: Bug#918916: Unicorn not reporting proper version for gemfile?

On 1/10/19, Eric Wong wrote: >> +- s.version = (ENV['VERSION'] || '5.4.1').dup >> ++ s.version = '5.4.1' > > Why is ignoring ENV['VERSION'] necessary for the Debian build? > I can probably remove that check if desired from the upstream > package before the 5.5.0 release. I've checked debian's g

Re: Bug#918916: Unicorn not reporting proper version for gemfile?

(unicorn upstream here, adding unicorn-public to Cc, for context: ) Dominik George wrote: > +--- a/unicorn.gemspec > b/unicorn.gemspec > +@@ -11,7 +11,7 @@ end.compact > + > + Gem::Specification.new do |s| > + s.name = %q{unicorn} > +- s.version = (ENV['