Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-08-07 Thread Eric Wong
Jeremy Evans wrote: > On 07/24 01:25, Eric Wong wrote: > > Jeremy Evans wrote: > > > Running with GC.stress didn't catch the error for me. But I'm using a > > > fairly old compiler (GCC 4.2.1, the OpenBSD default), so this may be > > > something that

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-08-07 Thread Jeremy Evans
On 07/24 01:25, Eric Wong wrote: > Jeremy Evans wrote: > > Running with GC.stress didn't catch the error for me. But I'm using a > > fairly old compiler (GCC 4.2.1, the OpenBSD default), so this may be > > something that only shows up on a newer compiler that does more > >

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-23 Thread Eric Wong
Jeremy Evans wrote: > Running with GC.stress didn't catch the error for me. But I'm using a > fairly old compiler (GCC 4.2.1, the OpenBSD default), so this may be > something that only shows up on a newer compiler that does more > optimizations. Pere: just curious if

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-17 Thread Jeremy Evans
On 07/15 12:56, Jeremy Evans wrote: > On 07/15 04:45, Eric Wong wrote: > > Jeremy Evans wrote: > > > All of Sequel's postgres adapter tests still pass with this, so I merged > > > this into the master branch. I'll do some more testing of my apps, but > > > unless I run into

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-15 Thread Jeremy Evans
On 07/15 04:45, Eric Wong wrote: > Jeremy Evans wrote: > > All of Sequel's postgres adapter tests still pass with this, so I merged > > this into the master branch. I'll do some more testing of my apps, but > > unless I run into problems I plan to release this as sequel_pg

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-14 Thread Eric Wong
Jeremy Evans wrote: > All of Sequel's postgres adapter tests still pass with this, so I merged > this into the master branch. I'll do some more testing of my apps, but > unless I run into problems I plan to release this as sequel_pg 1.7.1 > early next week. Thanks for the

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-14 Thread Jeremy Evans
On 07/15 12:15, Eric Wong wrote: > Jeremy Evans wrote: > > Thanks for this patch. I'm not an RB_GC_GUARD expert, but the changes > > look fine to me. The existing RB_GC_GUARD calls were added by me in > > 2012 to fix an earlier segfault.[1] This is the first reported > >

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-14 Thread Eric Wong
Jeremy Evans wrote: > Thanks for this patch. I'm not an RB_GC_GUARD expert, but the changes > look fine to me. The existing RB_GC_GUARD calls were added by me in > 2012 to fix an earlier segfault.[1] This is the first reported > RB_GC_GUARD-related segfault in sequel_pg

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-14 Thread Jeremy Evans
On 07/14 09:16, Eric Wong wrote: > Pere Joan Martorell wrote: > > I suspect that the conflicting gem was 'sequel_pg' (sequel_pg > > overwrites the inner loop of the Sequel postgres adapter row fetching > > code with a C version. The C version is significantly faster than

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-14 Thread Eric Wong
Pere Joan Martorell wrote: > I suspect that the conflicting gem was 'sequel_pg' (sequel_pg > overwrites the inner loop of the Sequel postgres adapter row fetching > code with a C version. The C version is significantly faster than the > pure ruby version that Sequel uses

Re: Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-13 Thread Eric Wong
+Cc: Philip and Jonathan since they encountered this three years ago, but we never heard back from them: https://bogomips.org/unicorn-public/?q=T_NODE+d:..20170713 Pere Joan Martorell wrote: > >

Random crash when sending USR2 + QUIT signals to Unicorn process

2017-07-13 Thread Pere Joan Martorell
Hi, I'm experimenting with a Rack application and Unicorn and I have a random error occurring when upgrading my app. When upgrading (sending a USR2 + QUIT signals), 10% of the times unicorn master process and its 2 worker processes start and after serving the first request they crash. This the