Re: Contradictory docs: python.files config can include not only python files

2021-04-27 Thread Yik San Chan
Hi Dian, I created a PR to fix the docs. https://github.com/apache/flink/pull/15779 On Tue, Apr 27, 2021 at 2:08 PM Dian Fu wrote: > Thanks for the suggestion. It makes sense to me~. > > 2021年4月27日 上午10:28,Yik San Chan 写道: > > Hi Dian, > > If that's the case, shall we reword "Attach custom pyt

Re: Contradictory docs: python.files config can include not only python files

2021-04-26 Thread Dian Fu
Thanks for the suggestion. It makes sense to me~. > 2021年4月27日 上午10:28,Yik San Chan 写道: > > Hi Dian, > > If that's the case, shall we reword "Attach custom python files for job." > into "attach custom files that could be put in PYTHONPATH, e.g., .zip, .whl, > etc." > > Best, > Yik San > >

Re: Contradictory docs: python.files config can include not only python files

2021-04-26 Thread Yik San Chan
Hi Dian, If that's the case, shall we reword "Attach custom python files for job." into "attach custom files that could be put in PYTHONPATH, e.g., .zip, .whl, etc." Best, Yik San On Tue, Apr 27, 2021 at 10:08 AM Dian Fu wrote: > Hi Yik San, > > All the files which could be put in the PYTHONPA

Re: Contradictory docs: python.files config can include not only python files

2021-04-26 Thread Dian Fu
Hi Yik San, All the files which could be put in the PYTHONPATH are allowed here, e.g. .zip, .whl, etc. Regards, Dian > 2021年4月27日 上午8:16,Yik San Chan 写道: > > Hi Dian, > > It is still not clear to me - does it only allow Python files (.py), or not? > > Best, > Yik San > > On Mon, Apr 26, 20

Re: Contradictory docs: python.files config can include not only python files

2021-04-26 Thread Yik San Chan
Hi Dian, It is still not clear to me - does it only allow Python files (.py), or not? Best, Yik San On Mon, Apr 26, 2021 at 9:15 PM Dian Fu wrote: > Hi Yik San, > > 1) what `--pyFiles` is used for: > All the files specified via `--pyFiles` will be put in the PYTHONPATH of > the Python worker d

Re: Contradictory docs: python.files config can include not only python files

2021-04-26 Thread Dian Fu
Hi Yik San, 1) what `--pyFiles` is used for: All the files specified via `--pyFiles` will be put in the PYTHONPATH of the Python worker during execution and then they will be available for the Python user-defined functions during execution. 2) validate for the files passed to `--pyFiles` Curre

Contradictory docs: python.files config can include not only python files

2021-04-26 Thread Yik San Chan
Hi community, In https://ci.apache.org/projects/flink/flink-docs-stable/dev/python/python_config.html, regarding python.files: > Attach custom python files for job. This makes readers think only Python files are allowed here. However, in https://ci.apache.org/projects/flink/flink-docs-stable/dep