Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-14 Thread Averell
Thank you Gordon and Ken. My Flink job is now running well with 1.7.2 RC1, with failed ES request retried successfully. One more question I have on this is how to limit the number of retries for different types of errors with ES bulk request. Is there any guideline on that? My temporary

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Tzu-Li (Gordon) Tai
Hi, @Averell I renamed the `ElasticsearchFailureHandlerIndexer` to be `BufferingNoOpRequestIndexer`, which explains why you can't find it. The voting thread for RC#1 of 1.7.2 can be found at [1]. The actual commits which fixes the problem are d9c45af to 2f52227. Cheers, Gordon [1]

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Ken Krugler
Hi Averell, https://github.com/apache/flink/commit/35af99391dac431c85e30bcc98b89cba79bccfea#diff-51a12ea54593424e195dd5874309a08d …is the commit where Gordon made his changes

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Averell
Hi Ken, Thanks for that. But I could not find the changes included in Gordon's mentioned pull request in the repository you gave me (e.g: the new class /ElasticsearchFailureHandlerIndexer/). I have found this folder https://dist.apache.org/repos/dist/dev/flink/flink-1.7.2-rc1/, but it also

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Ken Krugler
Hi Averell, You can get release candidates from the Apache release candidate maven repo. For 1.7.2, I think it’s in: https://repository.apache.org/content/repositories/orgapacheflink-1206/ So just edit your pom.xml to

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Averell
Hi Gordon, Sorry for a noob question: How can I get the RC 1.7.2 build / code to build? I could not find any branch like that in Github. Thanks and regards, Averell -- Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Tzu-Li (Gordon) Tai
Thanks for testing it out. Will be great to get your feedback on whether the release candidate for 1.7.2 fixes this for you. On Wed, Feb 13, 2019 at 7:38 PM Averell wrote: > Thank you Gordon. > > That's my exact problem. Will try the fix in 1.7.2 now. > > Thanks and regards, > Averell > > > >

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-13 Thread Averell
Thank you Gordon. That's my exact problem. Will try the fix in 1.7.2 now. Thanks and regards, Averell -- Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/

Re: ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-09 Thread Tzu-Li (Gordon) Tai
Hi Averell, This seems to be the bug that you encountered: https://issues.apache.org/jira/browse/FLINK-11046. Cheers, Gordon On Sat, Feb 9, 2019 at 3:27 PM Averell wrote: > Hello, > > I am trying to follow this Flink guide [1] to handle errors in > ElasticSearchSink by re-adding the failed

ElasticSearchSink - retrying doesn't work in ActionRequestFailureHandler

2019-02-08 Thread Averell
Hello, I am trying to follow this Flink guide [1] to handle errors in ElasticSearchSink by re-adding the failed messages to the queue. The error scenarios that I got and going to retry are: (i) conflict in UpdateRequest document version and (ii) lost connection to ElasticSearch. These errors are