Re: Metrics for FileSource

2022-06-19 Thread Meghajit Mazumdar
Thanks folks. This is really helpful. Regards. Meghajit On Sun, Jun 19, 2022 at 1:24 AM Jing Ge wrote: > Hi Meghajit, > > Thanks for the feedback. I have fired a ticket: > https://issues.apache.org/jira/browse/FLINK-28117 > > Best regards, > Jing > > On Mon, Jun 13, 2022 at 7:23 AM Meghajit Maz

Re: Metrics for FileSource

2022-06-18 Thread Jing Ge
Hi Meghajit, Thanks for the feedback. I have fired a ticket: https://issues.apache.org/jira/browse/FLINK-28117 Best regards, Jing On Mon, Jun 13, 2022 at 7:23 AM Meghajit Mazumdar < meghajit.mazum...@gojek.com> wrote: > Hi folks, > > Thanks for the reply. > We have implemented our own SplitAssi

Re: Metrics for FileSource

2022-06-13 Thread Martijn Visser
Hi, I believe this is a case where for the FileSystem (both Source and Sink) the metrics that are defined as part of FLIP-33 [1] have not been implemented yet. I've created a ticket for that [2]. Best regards, Martijn [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+

Re: Metrics for FileSource

2022-06-12 Thread Meghajit Mazumdar
Hi folks, Thanks for the reply. We have implemented our own SplitAssigner, FileReaderFormat and FileReaderFormat.Reader implementations. Hence, we plan to add custom metrics such as these: 1. No. of splits SplitAssigner is initialized with, number of splits re-added back to the SplitAssigner 2. Re

Re: Metrics for FileSource

2022-06-10 Thread Jing Ge
Hi meghajit, I think it makes sense to extend the current metrics. Could you list all metrics you need? Thanks! Best regards, Jing On Fri, Jun 10, 2022 at 5:06 PM Lijie Wang wrote: > Hi Meghajit, > > As far as I know, currently, the FileSource does not have the metrics you > need. You can imp

Re: Metrics for FileSource

2022-06-10 Thread Lijie Wang
Hi Meghajit, As far as I know, currently, the FileSource does not have the metrics you need. You can implement your own source, and register custom metrics via `SplitEnumeratorContext#metricGroup` and `SourceReaderContext#metricGroup`. Best, Lijie Meghajit Mazumdar 于2022年6月10日周五 16:36写道: > He

Metrics for FileSource

2022-06-10 Thread Meghajit Mazumdar
Hello, We are working on a Flink project which uses FileSource to discover and read Parquet Files from GCS. ( using Flink 1.14) As part of this, we wanted to implement some health metrics around the code. I wanted to know whether Flink gathers some metrics by itself around FileSource, e;g, number