Re: Kinesis connector SHARD_GETRECORDS_MAX default value

2017-06-22 Thread Tzu-Li (Gordon) Tai
Hi Steffen, Thanks for bringing up the discussion! I think the reason why SHARD_GETRECORDS_INTERVAL_MILLIS was defaulted to 0 in the first place was because we didn’t want false impressions that the there was some latency introduced in Flink with the default settings. To this end, I’m leaning

Re: Kinesis connector SHARD_GETRECORDS_MAX default value

2017-04-23 Thread Tzu-Li (Gordon) Tai
Thanks for filing the JIRA! Would you also be up to open a PR to for the change? That would be very very helpful :) Cheers, Gordon On 24 April 2017 at 3:27:48 AM, Steffen Hausmann (stef...@hausmann-family.de) wrote: Hi Gordon, thanks for looking into this and sorry it took me so long to

Re: Kinesis connector SHARD_GETRECORDS_MAX default value

2017-04-23 Thread Steffen Hausmann
Hi Gordon, thanks for looking into this and sorry it took me so long to file the issue: https://issues.apache.org/jira/browse/FLINK-6365. Really appreciate your contributions for the Kinesis connector! Cheers, Steffen On 22/03/2017 20:21, Tzu-Li (Gordon) Tai wrote: Hi Steffan, I have to

Re: Kinesis connector SHARD_GETRECORDS_MAX default value

2017-03-22 Thread Tzu-Li (Gordon) Tai
Hi Steffan, I have to admit that I didn’t put too much thoughts in the default values for the Kinesis consumer. I’d say it would be reasonable to change the default values to follow KCL’s settings. Could you file a JIRA for this? In general, we might want to reconsider all the default values