Well, I'd guess we've been slightly off from right from the start.
It's those little things... f.ex:
neo-utils ('neo' in the beginning and utils with an 's') and
index-util (no 'neo' in there) and
sparql-engine-neo ('neo' at the end)
Also the package naming, f.ex. I don't think the best p
Cool. Thanks for that, Peter.
What shall we do about the naming? I am always hesitant about such
disruptive changes to an API, but the sooner the better if a change
must be made.
Am I right to think that the naming scheme has simply evolved
over time? This could be a good time to establish a mast
Andreas,
just committed that fix in order to get the packaging right. However,
there is a deeper inconsistency in the naming of components vs. their
package names, that I think we need to fix in the long run ...
/peter
GTalk: neubauer.peter
Skype peter.neubauer
Phone +46 704 1069
Yes, perfect, will start thinking of a good name ...
/peter
GTalk: neubauer.peter
Skype peter.neubauer
Phone +46 704 106975
LinkedIn http://www.linkedin.com/in/neubauer
Twitter http://twitter.com/peterneubauer
http://www.neo4j.org- Relationships count.
htt
2009/9/22 Mattias Persson :
> 2009/9/22 Peter Neubauer :
>> Hi there,
>>
>> On Tue, Sep 22, 2009 at 9:44 AM, Mattias Persson
>> wrote:
>>> 2009/9/22 Andreas Kollegger :
!${bundle.namespace}.internal.*,$
{bundle.namespace}.*;version="${pom.version}"
Which for neo-utils means any
2009/9/22 Peter Neubauer :
> Hi there,
>
> On Tue, Sep 22, 2009 at 9:44 AM, Mattias Persson
> wrote:
>> 2009/9/22 Andreas Kollegger :
>>> !${bundle.namespace}.internal.*,$
>>> {bundle.namespace}.*;version="${pom.version}"
>>>
>>> Which for neo-utils means any available class in the org.neo4j.util.
Hi there,
On Tue, Sep 22, 2009 at 9:44 AM, Mattias Persson
wrote:
> 2009/9/22 Andreas Kollegger :
>> !${bundle.namespace}.internal.*,$
>> {bundle.namespace}.*;version="${pom.version}"
>>
>> Which for neo-utils means any available class in the org.neo4j.util.*
>> packages
>> except for org.neo4j.u
2009/9/22 Andreas Kollegger :
> Looking at neo-utils, I don't see any embedded dependencies in the
> neo-utils jar. The manifest would have entries like "Include-Resource"
> or "Bundle-Classpath" and there'd be jars within the jar.
>
> Oh, wait. I think I see the problem. neo-utils depends on index
Looking at neo-utils, I don't see any embedded dependencies in the
neo-utils jar. The manifest would have entries like "Include-Resource"
or "Bundle-Classpath" and there'd be jars within the jar.
Oh, wait. I think I see the problem. neo-utils depends on index-util
which produce classes in overlapp
Hi Andreas,
basically getting rid of unwanted includes is the case. I am thinking
the master pom addition would clear things up and exclude deps in an
obvious way. via the bnd files we can then fine tune e.g. exports in
case that is necessary. WDYT?
Then, we could e.g. explicitely state the JTA ja
Hey, just catching up on this thread.
Adding an explicit provided scope to dependencies seems fine to me.
I'm not sure about adding Embed-Dependency to the parent pom, though.
Without an explicit Embed-Dependency instruction, I wouldn't expect
anything other than compiled source to be in the fina
Yeah, I guess I can do it, but need the rights first, alternatively I
can send you a patch that includes all the updates in the different
poms (basically just adding the right scope elements). Can work on it
more tomorrow.
/peter
GTalk: neubauer.peter
Skype peter.neubauer
Phone +
Oh, ok... I'd vote for someone with a little more OSGi knowledge
though, who could test it a bit before committing it. But I guess I
_could_ do it.
2009/9/21 Peter Neubauer :
> Well, I figure you have to commit the patch, since I don't have
> sufficient privileges for the master pom ...
>
> /peter
Well, I figure you have to commit the patch, since I don't have
sufficient privileges for the master pom ...
/peter
GTalk: neubauer.peter
Skype peter.neubauer
Phone +46 704 106975
LinkedIn http://www.linkedin.com/in/neubauer
Twitter http://twitter.com/peterneubauer
http:/
Bump.
Any progress here anyone? It should be dealt with rather soon do
prevent strange behaviour and confusion.
2009/9/20 Peter Neubauer :
> Hi folks,
> Mattias noted packaging problem where dependencies got embedded into
> e.g. the neo-utils final jar. I propose changing the master pom so
> that
Hi folks,
Mattias noted packaging problem where dependencies got embedded into
e.g. the neo-utils final jar. I propose changing the master pom so
that we will explicitely scope all dependencies and only deps with
scope "runtime" or "compile" get embedded and not imported into the
final bundles, som
16 matches
Mail list logo