Re: Cleaning out old mesos-slave sandbox directories

2015-07-09 Thread Vinod Kone
If the patch is clean I think so. But what makes you think a retry would succeed? @vinodkone > On Jul 9, 2015, at 1:26 AM, Tom Arnfeld wrote: > > Ok, do you think that'd be a change that would be accepted into Mesos if I > sent it in? > > Thanks Vinod, btw. > > -- > > Tom Arnfeld > Develop

Re: Cleaning out old mesos-slave sandbox directories

2015-07-09 Thread Tom Arnfeld
Ok, do you think that'd be a change that would be accepted into Mesos if I sent it in? Thanks Vinod, btw. -- Tom Arnfeld Developer // DueDil (+44) 7525940046 25 Christopher Street, London, EC2A 2BS On Wed, Jul 8, 2015 at 7:24 PM, Vinod Kone wrote: > On Wed, Jul 8, 2015 at 11:20

Re: Cleaning out old mesos-slave sandbox directories

2015-07-08 Thread Vinod Kone
On Wed, Jul 8, 2015 at 11:20 AM, Tom Arnfeld wrote: > Do you know if the mesos-slave will re-schedule something for GC if it > fails deletion? > No it doesn't.

Re: Cleaning out old mesos-slave sandbox directories

2015-07-08 Thread Tom Arnfeld
Good question, there are likely mounts, yup... though they should be being unmounted cleanly, though perhaps not in all cases and maybe we need to retry deleting things in the gc process. Do you know if the mesos-slave will re-schedule something for GC if it fails deletion? -- Tom Arnfe

Re: Cleaning out old mesos-slave sandbox directories

2015-07-08 Thread Vinod Kone
Are there any special files (mounts etc) in your slave directory? The logic Mesos uses to delete a directory is likely different from the shell utility 'rm'. On Wed, Jul 8, 2015 at 11:09 AM,

Re: Cleaning out old mesos-slave sandbox directories

2015-07-08 Thread Tom Arnfeld
In this instance there were three old slave directories, and there are three log lines in the mesos-slave.INFO file; I0708 11:24:52.023453  2425 slave.cpp:3499] Garbage collecting old slave 20150515-105200-84152492-5050-9915-S46 I0708 11:24:52.023923  2425 slave.cpp:3499] Garbage collecting

Re: Cleaning out old mesos-slave sandbox directories

2015-07-08 Thread Vinod Kone
On Wed, Jul 8, 2015 at 10:54 AM, Tom Arnfeld wrote: > When this happens the old slave directories appear not to be tracked by > the mesos GC process, and stay around indefinitely. Over time if enough > full slave restarts happen (say, due to reconfiguration) the disks can be > completely filled a

Cleaning out old mesos-slave sandbox directories

2015-07-08 Thread Tom Arnfeld
Hey, I'm wondering if anyone in the community has a decent solution to this; when a slave restarts and re-registers (perhaps it was offline for too long) it will get a new slave ID, and use a new directory inside the work_dir for sandboxes. When this happens the old slave directories appear n