Re: Promotions and Sales Tax

2007-06-14 Thread Scott Gray
Hi Amit It would be great if you could attach a patch to OFBIZ-225 once you are done, it would be good to get this fixed Thanks Scott On 14/06/07, Amit Shinde <[EMAIL PROTECTED]> wrote: Thanks Scott. Currently, the tax calculations are not taking promotions into account. I am implementing a

Re: Promotions and Sales Tax

2007-06-14 Thread Amit Shinde
Thanks Scott. Currently, the tax calculations are not taking promotions into account. I am implementing a fix for this by adding a flag 'taxPromotions' and then send one more 'calcTax' service param as 'orderPromotionsAmount' which will be a sum of all the promotion adjustments and will be of n

Re: Promotions and Sales Tax

2007-06-14 Thread Scott Gray
Hi Amit See here, https://issues.apache.org/jira/browse/OFBIZ-225 In my opinion tax calculations should always take promotions into account. Regards Scott On 14/06/07, Amit Shinde <[EMAIL PROTECTED]> wrote: Hey Everyone, Currently, we have an ability to exclude shippi

Promotions and Sales Tax

2007-06-14 Thread Amit Shinde
Hey Everyone,    Currently, we have an ability to exclude shipping from calculation of sales tax. This is easily done by setting a 'taxShipping' flag in the TaxAuthorityRateProduct table. There is no way to include/exclude promotion adjustments in calculation of sales tax.