Re: Why create transaction in Event?

2016-08-18 Thread Jacques Le Roux
Hi 叶双明, One thing we could do is introduce a parameter in the event handler to have or not a transaction. By default we would have one. This seems simple enough to implement. Please open a Jira and I'll take care of it, the same way we did for the metric attribute of the event element. This

Re: Why create transaction in Event?

2016-07-27 Thread 叶双明
Hi Scott, Yes,modify def results = dispatcher.runSync("createOrder", serviceCtx) to def results = dispatcher.runSync("createOrder", serviceCtx, 60, true) would make my secas works as expected. But i need to modify so many code in Event to resolve similar problem, I think it is a bad smell for

Re: Why create transaction in Event?

2016-07-26 Thread 叶双明
Sorry, my code is base on newest in branch release13.07, after release 13.07.03. 2016-07-26 15:02 GMT+08:00 叶双明 : > Hi all: > > After update ofbiz to 13.07.03, our system was Unstable. At last, I found > the cause was The transaction created in Event, introduced in

Re: Why create transaction in Event?

2016-07-26 Thread Scott Gray
You can leave your code mostly the same, but just require a new transaction for createOrder, you'll see the option available in the runSync overloaded methods. I've been working with an older version of OFBiz for the last few years so I wasn't aware of this change, but I believe it is better than

Why create transaction in Event?

2016-07-26 Thread 叶双明
Hi all: After update ofbiz to 13.07.03, our system was Unstable. At last, I found the cause was The transaction created in Event, introduced in revision 1,740,632. And found https://issues.apache.org/jira/browse/OFBIZ-6808. But I doubt whether it is good to do this. In my opinion: 1. It would