Re: struts2 design question

2008-02-21 Thread Maxx
On Thu, Feb 21, 2008 at 2:03 AM, Jeromy Evans [EMAIL PROTECTED] wrote: Just thought I'd mention that Dave followed this up for you in struts-dev: http://www.nabble.com/StrutsStatics...-td15595866.html Just to let you know this link does not work (seems incomplete).

Re: struts2 design question

2008-02-21 Thread Jeromy Evans
Maxx wrote: On Thu, Feb 21, 2008 at 2:03 AM, Jeromy Evans [EMAIL PROTECTED] wrote: Just thought I'd mention that Dave followed this up for you in struts-dev: http://www.nabble.com/StrutsStatics...-td15595866.html Just to let you know this link does not work (seems incomplete).

Re: struts2 design question

2008-02-21 Thread Dave Newton
--- Jeromy Evans [EMAIL PROTECTED] wrote: Maxx wrote: On Thu, Feb 21, 2008 at 2:03 AM, Jeromy Evans [EMAIL PROTECTED] wrote: http://www.nabble.com/StrutsStatics...-td15595866.html Just to let you know this link does not work (seems incomplete). Works for me in FF and IE6 and from

Re: struts2 design question

2008-02-21 Thread Maxx
Strangely it first freezes my browser. Re-testing it now and it's working. I also thought the three dots could come from a shortened url, while it's effectively not. Apologies. Maxx - To unsubscribe, e-mail: [EMAIL PROTECTED]

Re: struts2 design question

2008-02-21 Thread eric . jung
I wouldn't have seen that. Thanks, Jeromy. It's disturbing to see this kind of code in 2008 and makes me wonder what other antipatterns might exist in the struts2 codebase. Dave Newton wrote: --- [EMAIL PROTECTED] wrote: I'm curious why the developers of struts2 chose to define

Re: struts2 design question

2008-02-21 Thread Dave Newton
--- [EMAIL PROTECTED] wrote: I wouldn't have seen that. Thanks, Jeromy. It's disturbing to see this kind of code in 2008 and makes me wonder what other antipatterns might exist in the struts2 codebase. Funny; I was thinking the same thing about the static context stuff in JSF that makes it

Re: struts2 design question

2008-02-21 Thread Musachy Barroso
I am confused here. You do know that you don't need to extend/implement any class/interface right? Or I am missing the whole point. musachy On Thu, Feb 21, 2008 at 11:39 AM, [EMAIL PROTECTED] wrote: Funny; I was thinking the same thing about the static context stuff in JSF that makes it

[OT] Re: struts2 design question

2008-02-21 Thread Dave Newton
--- [EMAIL PROTECTED] wrote: 3. Classes can't stand on their own. Neither can a class that's using a static method. 4. It's easier for Java beginners to mix business logic with MVC framework code. Easier? Like... typing is actually easier with S2? Never mind, I don't get that one, and this

Re: struts2 design question

2008-02-21 Thread Dave Newton
--- Musachy Barroso [EMAIL PROTECTED] wrote: I am confused here. You do know that you don't need to extend/implement any class/interface right? Or I am missing the whole point. The original issue was regarding error messages and how they're stored in the action rather than in a thread/instance

Re: struts2 design question

2008-02-21 Thread eric . jung
Funny; I was thinking the same thing about the static context stuff in JSF that makes it really difficult to test in isolation. What makes you think that's difficult? I'm sure you're aware of mock objects. There are a number of mock JSF test frameworks---JMock and Shale come to mind. Writing

Re: struts2 design question

2008-02-21 Thread Jeromy Evans
[EMAIL PROTECTED] wrote: I wouldn't have seen that. Thanks, Jeromy. It's disturbing to see this kind of code in 2008 and makes me wonder what other antipatterns might exist in the struts2 codebase. Actually I only linked to that discussion to show that Dave had been courteous enough to

struts2 design question

2008-02-20 Thread eric . jung
Hi, I'm curious why the developers of struts2 chose to define constants in an interface (StrutsStatics) and then implement that interface in at least 18 classes (see http://struts.apache.org/2.x/struts2-core/apidocs/org/apache/struts2/StrutsStatics.html). Theinterface constant pattern has

Re: struts2 design question

2008-02-20 Thread Dave Newton
--- [EMAIL PROTECTED] wrote: I'm curious why the developers of struts2 chose to define constants in an interface (StrutsStatics) and then implement that interface in at least 18 classes It's likely you'd need to ask the original WebWork developers. Item #17, Use interfaces only to define

Re: struts2 design question

2008-02-20 Thread Jeromy Evans
Dave Newton wrote: --- [EMAIL PROTECTED] wrote: I'm curious why the developers of struts2 chose to define constants in an interface (StrutsStatics) and then implement that interface in at least 18 classes Just thought I'd mention that Dave followed this up for you in struts-dev: