Re: [RFR] ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed

2019-09-12 Thread Enrico Olivelli
Zili, Thank you for driving this. We must ensure that that change does not break 100% compatibility with 3.4 client. The best way to prove it is to setup some integration test that tests a compatibility matrix, it will be an huge work. In absence of that facility we need some Jute expert to

Re: [RFR] ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed

2019-09-11 Thread Zili Chen
I met this issue again when working on Pravega[1], a project using ZooKeeper. I think it is nice to have that we throw the exactly path that cause the multi-op fails. Could you help to review the pull request? Best, tison. [1] https://github.com/pravega/pravega/pull/4140#discussion_r322096138

[RFR] ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed

2019-08-24 Thread Zili Chen
Hi ZooKeepers, ZOOKEEPER-3290 has been revived and here is its pull request[1]. Basically it extends field of ErrorTxn/ErrorResponse/ErrorResult to reflect accurate path info when a transaction failed. For example, assumed we do check1(path1)-create1(path2) and fail with NoNodeException,