Re: [uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef _REGPARM's?

2006-08-21 Thread Jeff Dike
On Mon, Aug 21, 2006 at 11:56:41PM +0200, Adrian Bunk wrote: > arch/um/sys-i386/setjmp.S contains two #ifdef _REGPARM's. > > Even if regparm was used in i386 uml (which isn't currently done (why?)), > I don't see _REGPARM being defined anywhere. setjmp.S was stolen from klibc, and I'd just as soo

Re: [uml-devel] [PATCH] [RFC] uml: make activate_fd atomic

2006-08-21 Thread Jeff Dike
On Sat, Aug 19, 2006 at 05:52:37PM +0200, Blaisorblade wrote: > Have you found a tool for this or just done by hand? (I've seen Understanding > the Linux VMM talking about tools for call graphs). I spent an afternoon doing it by hand. > After the networking locking patch, I'll recheck, but uml_ne

[uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef _REGPARM's?

2006-08-21 Thread Adrian Bunk
arch/um/sys-i386/setjmp.S contains two #ifdef _REGPARM's. Even if regparm was used in i386 uml (which isn't currently done (why?)), I don't see _REGPARM being defined anywhere. Is this a bug waiting for happening when regparm will be used on uml or do I miss anything? cu Adrian -- Gentoo