Re: [uml-devel] [PATCH] UML utrace support, step 1

2007-02-22 Thread Roland McGrath
> OK, I'll do it this way. Your replacement patch still has utrace_regset stuff in it, so it doesn't compile without the later patches in the series. Try applying only utrace-tracehook.patch from the series, then get it to build and make your utrace-tracehook-um.patch. Then apply only utrace-reg

[uml-devel] [PATCH 2/2] UML - add back accidentally removed error

2007-02-22 Thread Jeff Dike
In the 2.6.20 hang patch, I accidentally threw out an error message. This puts it back. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/sigio.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-2.6.18-mm/arch/um/os-Linux/sigio.c ==

[uml-devel] [PATCH 1/2] UML - Fix host LDT lookup initialization locking, try 2

2007-02-22 Thread Jeff Dike
Add some locking to host_ldt_entries to prevent racing when reading LDT information from the host. The locking is somewhat more careful than my previous attempt. Now, only the check of host_ldt_entries is locked. The lock is dropped immediately afterwards, and if the LDT needs initializing, that

Re: [uml-devel] When opening /tmp/uml.ctl fails, what do we get?

2007-02-22 Thread Jeff Dike
On Thu, Feb 22, 2007 at 12:54:04AM +0100, Blaisorblade wrote: > I started uml_daemon as root by mistake, so /tmp/uml.ctl even if /dev/net/tun > was world-readable. Ok, I did it. This is the result (after trying many times > to do 'ifconfig eth0 up' inside UML): I don't see your irq stuff here when

Re: [uml-devel] [PATCH 4/4] UML - lock host ldt retrieval

2007-02-22 Thread Jeff Dike
On Wed, Feb 21, 2007 at 11:40:28PM +0100, Blaisorblade wrote: > Please remove GFP_KERNEL allocation under spin_lock Nice spotting - I'll redo the patch. Jeff -- Work email - jdike at linux dot intel dot com ---

Re: [uml-devel] When opening /tmp/uml.ctl fails, what do we get?

2007-02-22 Thread Jeff Dike
On Thu, Feb 22, 2007 at 12:54:04AM +0100, Blaisorblade wrote: > Looking into the code, I saw that: > 1) daemon_user_init is confusing because it saved any error into pri->fd, > instead of returning it to the caller. Yup. > Also, it would make sense to move this into daemon_open. The current be

Re: [uml-devel] [PATCH 2/3] UML - x86_64 thread fixes

2007-02-22 Thread Jeff Dike
On Thu, Feb 22, 2007 at 01:07:30AM +0100, Blaisorblade wrote: > Is there any reason for avoiding this treatment to %gs, apart that TLS code > usually does not need it, even if the API allows for it to exist? Is there any prospect that %gs will be getting similar treatment? %fs is set through CLO

[uml-devel] [PATCH] UML - Fix 2.6.20 hang

2007-02-22 Thread Jeff Dike
[ I mistyped the -stable email in my original posting ] A previous cleanup misused need_poll, which had a fairly broken interface. It implemented a growable array, changing the used elements count itself, but leaving it up to the caller to fill in the actual elements, including the entire array i