Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-18 Thread Tejun Heo
Hello, On 04/19/2010 01:37 AM, Jan Kiszka wrote: > We now have to to include linux/slab.h explicitly for kmalloc & friends. > Files that build against host headers already get their prototypes via > um_malloc.h, linux/slab.h may even be unavailable. Hmmm... my test um build was okay but I don't k

[uml-devel] uml: pthreads instead of manual clone()?

2010-04-18 Thread Jan Kiszka
Hi Jeff, is there (still) any reason to use explicit clone() instead of pthreads to spawn UML kernel threads? While playing with a patch to finally move os_nsecs to proper CLOCK_MONOTONIC, I noticed some subtle side-effect: We need to link against librt for clock_gettime, but that indirectly drag

[uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-18 Thread Jan Kiszka
We now have to to include linux/slab.h explicitly for kmalloc & friends. Files that build against host headers already get their prototypes via um_malloc.h, linux/slab.h may even be unavailable. Signed-off-by: Jan Kiszka --- arch/um/drivers/line.c|1 + arch/um/os-Linux/helper.c |1 -

Re: [uml-devel] [PATCH 1/1] uml: replace kmalloc() in line.c

2010-04-18 Thread Jan Kiszka
Tiger Yang wrote: > This patch replace kmalloc() with uml_kmalloc() in line.c and > remove an unused variable. This driver does not require the wrapping. I'll post a patch to unbreak uml build in a minute. Jan > > Signed-off-by: Tiger Yang > --- > arch/um/drivers/line.c |8 > 1 f