Re: [uml-devel] [PATCH] um: Fix compile errors for um architecture

2010-04-19 Thread Jan Kiszka
Lukas Czerner wrote: > arch/um/drivers/line.c > - need to include linux/slab.h since the code uses kmalloc. > - fix warning message with unused variable tty > > arch/um/os-Linux/helper.c > - there is no need to include linux/slab.h since allocations are > done with uml_kmalloc The build fixes

[uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-19 Thread Jan Kiszka
We can't pull in linux/sched.h, so just declare the struct. Signed-off-by: Jan Kiszka --- arch/um/sys-i386/asm/elf.h |2 ++ arch/um/sys-x86_64/asm/elf.h |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/um/sys-i386/asm/elf.h b/arch/um/sys-i386/asm/elf.h index e

[uml-devel] [PATCH 1/5] uml: Remove unused variable from line driver

2010-04-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- arch/um/drivers/line.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c index 7a656bd..7f7338c 100644 --- a/arch/um/drivers/line.c +++ b/arch/um/drivers/line.c @@ -19,7 +19,6 @@ static irqreturn_

[uml-devel] [PATCH 5/5] uml: Clean up asm/system.h

2010-04-19 Thread Jan Kiszka
Remove duplicates and unused prototypes. Signed-off-by: Jan Kiszka --- arch/um/include/asm/system.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/um/include/asm/system.h b/arch/um/include/asm/system.h index 753346e..93af1cf 100644 --- a/arch/um/include/asm/syste

[uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-19 Thread Jan Kiszka
Already defined in kernel.h. The official version assumes that 'n' is power of two - which it is in our case. Signed-off-by: Jan Kiszka --- arch/um/sys-x86_64/signal.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signa

[uml-devel] [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls

2010-04-19 Thread Jan Kiszka
The i386 subarch happens to pull in original NR_syscalls. Maybe we can make that work for all host arch, but for now just avoid the clash by using an all-upper-case name. Signed-off-by: Jan Kiszka --- arch/um/kernel/skas/syscall.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) di

[uml-devel] [PATCH 0/5] uml: Some trivial cleanups

2010-04-19 Thread Jan Kiszka
Some trivial build warning fixes and cleanups for UML. Jan Kiszka (5): uml: Remove unused variable from line driver uml: Drop private round_down definition uml: Fix warning due to missing task_struct declaration uml: i386: Avoid redefinition of NR_syscalls uml: Clean up asm/system.h ar

[uml-devel] [PATCH] um: Fix compile errors for um architecture

2010-04-19 Thread Lukas Czerner
arch/um/drivers/line.c - need to include linux/slab.h since the code uses kmalloc. - fix warning message with unused variable tty arch/um/os-Linux/helper.c - there is no need to include linux/slab.h since allocations are done with uml_kmalloc Signed-off-by: Lukas Czerner --- arch/um/drivers

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Jiri Kosina
On Mon, 19 Apr 2010, Jan Kiszka wrote: > >>> I suppose this patch will go through um tree? > >> Good question. Does such a tree exist? I'm sitting on a few more um > >> cleanups & fixes, and so far I'm working against Linus' tree as I failed > >> to find anything more recent. > > > > If these are

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Jan Kiszka
Jiri Kosina wrote: > On Mon, 19 Apr 2010, Jan Kiszka wrote: > >>> I suppose this patch will go through um tree? >> Good question. Does such a tree exist? I'm sitting on a few more um >> cleanups & fixes, and so far I'm working against Linus' tree as I failed >> to find anything more recent. > > I

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Jiri Kosina
On Mon, 19 Apr 2010, Jan Kiszka wrote: > > I suppose this patch will go through um tree? > > Good question. Does such a tree exist? I'm sitting on a few more um > cleanups & fixes, and so far I'm working against Linus' tree as I failed > to find anything more recent. If these are simple-enough c

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Tejun Heo
On 04/19/2010 01:37 AM, Jan Kiszka wrote: > We now have to to include linux/slab.h explicitly for kmalloc & friends. > Files that build against host headers already get their prototypes via > um_malloc.h, linux/slab.h may even be unavailable. > > Signed-off-by: Jan Kiszka applied to percpu#for-l

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Tejun Heo
On 04/19/2010 04:35 PM, Jan Kiszka wrote: > Good question. Does such a tree exist? I'm sitting on a few more um > cleanups & fixes, and so far I'm working against Linus' tree as I failed > to find anything more recent. Well, in that case, I'll route this one through percpu. Thanks. -- tejun --

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Jan Kiszka
Tejun Heo wrote: > Hello, > > On 04/19/2010 01:37 AM, Jan Kiszka wrote: >> We now have to to include linux/slab.h explicitly for kmalloc & friends. >> Files that build against host headers already get their prototypes via >> um_malloc.h, linux/slab.h may even be unavailable. > > Hmmm... my test u