Re: [uml-devel] [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls

2010-04-20 Thread Amerigo Wang
On Tue, Apr 20, 2010 at 07:14:43PM +0200, Jan Kiszka wrote: >Amerigo Wang wrote: >> On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote: >>> The i386 subarch happens to pull in original NR_syscalls. Maybe we can >>> make that work for all host arch, but for now just avoid the clash by >>> us

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-20 Thread Amerigo Wang
On Tue, Apr 20, 2010 at 07:09:15PM +0200, Jan Kiszka wrote: >Jeff Dike wrote: >> On Tue, Apr 20, 2010 at 06:09:49PM +0800, Amerigo Wang wrote: >>> On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote: We can't pull in linux/sched.h, so just declare the struct. >>> Did you meet any b

[uml-devel] [PATCH] UML: Fix gdbserver "Couldn't write debug register" error

2010-04-20 Thread Barry Friedman
Running gdbserver in a UML instance displays "Couldn't write debug register" after setting a breakpoint and continuing after attaching from a remote gdb on the host. This is on an AMD x86_64 machine. The error message was resulting from getting EIO error when making a PTRACE_POKEUSER call. I debug

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-20 Thread Jiri Kosina
On Tue, 20 Apr 2010, Jan Kiszka wrote: > >>> We can't pull in linux/sched.h, so just declare the struct. > >>> > >> Did you meet any build error? If yes, please include it. > > > > What does this patch fix, aside from being a bit cleaner? > > CC arch/um/sys-i386/elfcore.o > In file includ

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jiri Kosina
On Tue, 20 Apr 2010, Jeff Dike wrote: > > > Shouldn't this signal.c #include ? > > > > Well, it gets included implicitly through uaccess.h -> sched.h -> > > kernel.h. > > You're depending on the internal details of uaccess.h and sched.h. If > either of them changed, then this would cause unexp

Re: [uml-devel] [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls

2010-04-20 Thread Jan Kiszka
Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote: >> The i386 subarch happens to pull in original NR_syscalls. Maybe we can >> make that work for all host arch, but for now just avoid the clash by >> using an all-upper-case name. >> > > Where? Not sure if this answ

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-20 Thread Jan Kiszka
Jeff Dike wrote: > On Mon, Apr 19, 2010 at 10:12:04PM +0200, Jiri Kosina wrote: >> Well, if Jeff isn't actively maintaining UML any more, either you can take >> over the maintainership yourself, or feed the non-trivial patches through >> Andrew Morton. > > Yes, these generally go through Andrew.

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-20 Thread Jan Kiszka
Jeff Dike wrote: > On Tue, Apr 20, 2010 at 06:09:49PM +0800, Amerigo Wang wrote: >> On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote: >>> We can't pull in linux/sched.h, so just declare the struct. >>> >> Did you meet any build error? If yes, please include it. > > What does this patch f

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jeff Dike
On Tue, Apr 20, 2010 at 04:35:52PM +0200, Jiri Kosina wrote: > On Tue, 20 Apr 2010, Amerigo Wang wrote: > > Shouldn't this signal.c #include ? > > Well, it gets included implicitly through uaccess.h -> sched.h -> > kernel.h. You're depending on the internal details of uaccess.h and sched.h. If

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jiri Kosina
On Tue, 20 Apr 2010, Jeff Dike wrote: > > >Already defined in kernel.h. The official version assumes that 'n' is > > >power of two - which it is in our case. > > > > > >Signed-off-by: Jan Kiszka > > >--- > > > arch/um/sys-x86_64/signal.c |2 -- > > > 1 files changed, 0 insertions(+), 2 deletio

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-20 Thread Jeff Dike
On Mon, Apr 19, 2010 at 10:12:04PM +0200, Jiri Kosina wrote: > Well, if Jeff isn't actively maintaining UML any more, either you can take > over the maintainership yourself, or feed the non-trivial patches through > Andrew Morton. Yes, these generally go through Andrew.

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jeff Dike
On Tue, Apr 20, 2010 at 04:33:58PM +0800, Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:05PM +0200, Jan Kiszka wrote: > >Already defined in kernel.h. The official version assumes that 'n' is > >power of two - which it is in our case. > > > >Signed-off-by: Jan Kiszka > >--- > > arch/um/sys-x8

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-20 Thread Jeff Dike
On Tue, Apr 20, 2010 at 06:09:49PM +0800, Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote: > >We can't pull in linux/sched.h, so just declare the struct. > > > > Did you meet any build error? If yes, please include it. What does this patch fix, aside from being a

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jiri Kosina
On Tue, 20 Apr 2010, Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:05PM +0200, Jan Kiszka wrote: > >Already defined in kernel.h. The official version assumes that 'n' is > >power of two - which it is in our case. > > > >Signed-off-by: Jan Kiszka > >--- > > arch/um/sys-x86_64/signal.c |2

Re: [uml-devel] [PATCH 5/5] uml: Clean up asm/system.h

2010-04-20 Thread Jiri Kosina
On Mon, 19 Apr 2010, Jan Kiszka wrote: > Remove duplicates and unused prototypes. > > Signed-off-by: Jan Kiszka Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- Download IntelĀ® Parallel Studio Eval Try the n

Re: [uml-devel] [PATCH 1/5] uml: Remove unused variable from line driver

2010-04-20 Thread Jiri Kosina
On Mon, 19 Apr 2010, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka > --- > arch/um/drivers/line.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c > index 7a656bd..7f7338c 100644 > --- a/arch/um/drivers/line.c > +++ b/

Re: [uml-devel] [PATCH 5/5] uml: Clean up asm/system.h

2010-04-20 Thread Amerigo Wang
On Mon, Apr 19, 2010 at 11:53:08PM +0200, Jan Kiszka wrote: >Remove duplicates and unused prototypes. > >Signed-off-by: Jan Kiszka Acked-by: WANG Cong >--- > arch/um/include/asm/system.h |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > >diff --git a/arch/um/include/asm/system.h

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-20 Thread Amerigo Wang
On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote: >We can't pull in linux/sched.h, so just declare the struct. > Did you meet any build error? If yes, please include it. Thanks. >Signed-off-by: Jan Kiszka >--- > arch/um/sys-i386/asm/elf.h |2 ++ > arch/um/sys-x86_64/asm/elf.h |

Re: [uml-devel] [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls

2010-04-20 Thread Amerigo Wang
On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote: >The i386 subarch happens to pull in original NR_syscalls. Maybe we can >make that work for all host arch, but for now just avoid the clash by >using an all-upper-case name. > Where? >Signed-off-by: Jan Kiszka >--- > arch/um/kernel/ska

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Amerigo Wang
On Mon, Apr 19, 2010 at 11:53:05PM +0200, Jan Kiszka wrote: >Already defined in kernel.h. The official version assumes that 'n' is >power of two - which it is in our case. > >Signed-off-by: Jan Kiszka >--- > arch/um/sys-x86_64/signal.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) >

Re: [uml-devel] [PATCH 1/5] uml: Remove unused variable from line driver

2010-04-20 Thread Amerigo Wang
On Mon, Apr 19, 2010 at 11:53:04PM +0200, Jan Kiszka wrote: >Signed-off-by: Jan Kiszka Acked-by: WANG Cong >--- > arch/um/drivers/line.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > >diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c >index 7a656bd..7f7338c 100644 >