Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Borislav Petkov
From: Jeff Dike Date: Mon, May 31, 2010 at 11:56:19AM -0400 > On Mon, May 31, 2010 at 03:51:32PM +0200, Borislav Petkov wrote: > > includes which are > > the optimized variants. > > But how does UML get to arch/x86/include/asm/bitops.h in the first place? > > It must go through an arch/um/inc

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Borislav Petkov
From: Toralf Förster Date: Mon, May 31, 2010 at 09:55:53AM -0400 > Borislav Petkov wrote at 22:17:38 > > LKML-Reference: <201005271944.09541.toralf.foers...@gmx.de> > > Signed-off-by: Borislav Petkov > > --- > > arch/um/include/asm/arch_hweight.h |6 ++ > > 1 files changed, 6 insertions

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Borislav Petkov
From: Jeff Dike Date: Sun, May 30, 2010 at 10:32:12PM -0400 > On Sun, May 30, 2010 at 09:39:56PM +0200, Borislav Petkov wrote: > > Which begs the question why _is_ UML sucking in x86 stuff and can anyone > > provide us with some sensible reasons? Because if there aren't any, it > > is their inclu

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Jeff Dike
On Mon, May 31, 2010 at 03:51:32PM +0200, Borislav Petkov wrote: > includes which are > the optimized variants. But how does UML get to arch/x86/include/asm/bitops.h in the first place? It must go through an arch/um/include/asm/something.h (where something might be bitops) first, right?

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Boaz Harrosh
On 05/31/2010 04:55 PM, Toralf Förster wrote: > > Borislav Petkov wrote at 22:17:38 >> LKML-Reference: <201005271944.09541.toralf.foers...@gmx.de> >> Signed-off-by: Borislav Petkov >> --- >> arch/um/include/asm/arch_hweight.h |6 ++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >>

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Toralf Förster
Borislav Petkov wrote at 16:10:58 > Did you do 'make mrproper' before rebuilding UML with it? Yes, I did "make mrproper ARC H= um" and "make mrproper" > Also, can you do > > grep -EriIn 'x86.*hweight\.h' arch/um/ tfoer...@n22 ~/devel/linux-2.6 $ grep -EriIn 'x86.*hweight\.h' arch/um/ tfoer...@n

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Jeff Dike
On Sun, May 30, 2010 at 09:39:56PM +0200, Borislav Petkov wrote: > Which begs the question why _is_ UML sucking in x86 stuff and can anyone > provide us with some sensible reasons? Because if there aren't any, it > is their includes that should be fixed. Let me see what I can do to > redirect hweig

Re: [uml-devel] [PATCH] x86, hweight: Fix UML boot crash

2010-05-31 Thread Toralf Förster
Borislav Petkov wrote at 22:17:38 > LKML-Reference: <201005271944.09541.toralf.foers...@gmx.de> > Signed-off-by: Borislav Petkov > --- > arch/um/include/asm/arch_hweight.h |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > create mode 100644 arch/um/include/asm/arch_hweight.h >