From: Linus Torvalds
Date: Wed, 29 Sep 2010 08:05:04 -0700
> On Wed, Sep 29, 2010 at 1:34 AM, Boaz Harrosh wrote:
>>
>> On the other hand patch [f25c80a4] was trying to use eth_mac_addr()
>> in eth_configure(), *which was the real fallout*. Because of state
>> checks done inside eth_mac_addr() t
From: Linus Torvalds
Date: Wed, 29 Sep 2010 08:01:07 -0700
> On Wed, Sep 29, 2010 at 1:41 AM, Boaz Harrosh wrote:
>>
>> With this I'm now back to my usual: boots fine but half of the times
>> not halting. But I think that's a Fedora12 problem with interaction
>> with uml. (Which I do not have ti
> Oh, joy... I'm regulary using uml, with some of these drivers used
> from time to time, but I've no fscking clue on e.g. VDE - even on
> the "what the hell it is" level ;-/
VDE is Virtual Distributed Ethernet.
http://wiki.virtualsquare.org/wiki/index.php/Introduction#Virtual_Square_Networking
I
On Wed, Sep 29, 2010 at 1:41 AM, Boaz Harrosh wrote:
>
> With this I'm now back to my usual: boots fine but half of the times
> not halting. But I think that's a Fedora12 problem with interaction
> with uml. (Which I do not have time to investigate)
So that "half of the time not halting" happened
On Wed, Sep 29, 2010 at 1:34 AM, Boaz Harrosh wrote:
>
> On the other hand patch [f25c80a4] was trying to use eth_mac_addr()
> in eth_configure(), *which was the real fallout*. Because of state
> checks done inside eth_mac_addr() the address was never set. I have
> not reintroduced the memcpy wrap
On 09/28/2010 10:57 PM, Linus Torvalds wrote:
> On Tue, Sep 28, 2010 at 1:47 PM, Andrew Morton
> wrote:
>>
>> And I misread that, assuming that it's just a wrapper around
>> eth_mac_addr(). Only it isn't, because it passes eth_mac_addr() the
>> MAC address's address directly (with ->sa_data). Bu
uml_net_set_mac() was broken and luckily it was never used, before.
What it was trying to do is spin_lock before memcopy the mac address.
Linus attempted to fix it in assumption that someone decided the
lock was needed. But since it was never ever used at all, and was
just dead code, I think we ca
