Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 11:33, schrieb Chen Gang: On 06/26/2013 05:03 PM, Richard Weinberger wrote: Am 26.06.2013 10:58, schrieb Chen Gang: On 06/26/2013 04:39 PM, Richard Weinberger wrote: The drivers internal code has already check the related return value, so it is the architecture's duty to

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 10:34, schrieb Chen Gang: On 06/26/2013 04:05 PM, Richard Weinberger wrote: diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index d5afe96..e80331d 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -303,10 +303,10 @@ static inline void

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 04:39 PM, Richard Weinberger wrote: The drivers internal code has already check the related return value, so it is the architecture's duty to 'tell' the driver whether support io memory (e.g. define ioremap, but return NULL). It does so already by setting CONFIG_HAS_IOMEM=n

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 12:01, schrieb Chen Gang: On 06/26/2013 05:48 PM, Geert Uytterhoeven wrote: On Wed, Jun 26, 2013 at 11:38 AM, Richard Weinberger rich...@nod.at wrote: Since the API itself already contents the meaning: return NULL means the arch has no related io memory, No, NULL means it could

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 05:38 PM, Richard Weinberger wrote: Am 26.06.2013 11:33, schrieb Chen Gang: On 06/26/2013 05:03 PM, Richard Weinberger wrote: Am 26.06.2013 10:58, schrieb Chen Gang: On 06/26/2013 04:39 PM, Richard Weinberger wrote: The drivers internal code has already check the related

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 10:58, schrieb Chen Gang: On 06/26/2013 04:39 PM, Richard Weinberger wrote: The drivers internal code has already check the related return value, so it is the architecture's duty to 'tell' the driver whether support io memory (e.g. define ioremap, but return NULL). It does so

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Hi! Am 26.06.2013 08:31, schrieb Chen Gang: For User Mode Linux, it may enable 'MMU', but not need implement ioremap and iounmap, so include/asm-generic/io.h need notice this case to keep itself 'generic'. The related error (with allmodconfig, without pcap): CC [M]

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Hi! Am 26.06.2013 09:56, schrieb Chen Gang: On 06/26/2013 02:54 PM, Richard Weinberger wrote: Hi! Am 26.06.2013 08:31, schrieb Chen Gang: For User Mode Linux, it may enable 'MMU', but not need implement ioremap and iounmap, so include/asm-generic/io.h need notice this case to keep itself

Re: [uml-devel] [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 05:03 PM, Richard Weinberger wrote: Am 26.06.2013 10:58, schrieb Chen Gang: On 06/26/2013 04:39 PM, Richard Weinberger wrote: The drivers internal code has already check the related return value, so it is the architecture's duty to 'tell' the driver whether support io