Re: [uml-devel] [PATCH] arch: um: kernel: skas: mmu: remove pmd_free() and pud_free() for failure processing in init_stub_pte()

2013-11-14 Thread Chen Gang
On 11/14/2013 03:33 PM, Chen Gang wrote: > On 11/14/2013 02:48 PM, Chen Gang wrote: >>> >From the look of it, if an error did occur in init_stub_pte(), then the special mapping of STUB_CODE and STUB_DATA would not be installed, so this area would be invisible to munmap and exit, and

[uml-devel] [PATCH] um: hostfs: make functions static

2013-11-14 Thread James Hogan
The hostfs_*() callback functions are all only used within hostfs_kern.c, so make them static. Signed-off-by: James Hogan Cc: Jeff Dike Cc: Richard Weinberger Cc: user-mode-linux-devel@lists.sourceforge.net --- fs/hostfs/hostfs_kern.c | 53 ++--- 1 f

Re: [uml-devel] [PATCH] uml: Simplify tempdir logic.

2013-11-14 Thread Tristan Schmelcher
On 14 November 2013 08:25, wrote: > You should probably add /run/shm to the list of tmpfs directories to > test for (ubuntu systems atleast use this). On such systems /dev/shm is typically a symlink to /run/shm, so that's covered.

Re: [uml-devel] [PATCH] uml: Simplify tempdir logic.

2013-11-14 Thread stian
Den 2013-11-11 19:03, skrev Tristan Schmelcher: > + static const char fallback_dir[] = "/tmp"; > + static const char * const tmpfs_dirs[] = { > + "/dev/shm", > + fallback_dir, > + NULL > + }; You should probably add /run/shm to the list of tmpfs dire

Re: [uml-devel] [PATCH] arch: um: kernel: skas: mmu: remove pmd_free() and pud_free() for failure processing in init_stub_pte()

2013-11-14 Thread Chen Gang
On 11/14/2013 03:55 PM, Richard Weinberger wrote: > Am 14.11.2013 08:33, schrieb Chen Gang: >> > On 11/14/2013 02:48 PM, Chen Gang wrote: >>> >From the look of it, if an error did occur in init_stub_pte(), > then the special mapping of STUB_CODE and STUB_DATA would not > be i