Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread David Binderman
Hello there Geert, > Thanks for your patch! You are welcome. > As Jeff already commented, you should include a proper patch description. How about [PATCH]: Add missing va_end to split_if_spec > Unfortunately the patch is whitespace-damaged. > Did you p

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Toralf Förster
On 07/13/2015 05:46 PM, Geert Uytterhoeven wrote: > For hotmail, port 465? Ick - right, I use GMX, where tls works flawlessly (BTW I didn't specify the port in .gitconfig) -- Toralf, pgp key: 872AE508 0076E94E -- Don't

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Geert Uytterhoeven
On Mon, Jul 13, 2015 at 5:40 PM, Toralf Förster wrote: > On 07/13/2015 05:26 PM, Geert Uytterhoeven wrote: >> smtpencryption = ssl > I do have : > smtpencryption = tls For hotmail, port 465? I use tls, too, for gmail port 587. Gr{oetje,eeting}s, Geert -- Geert

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Toralf Förster
On 07/13/2015 05:26 PM, Geert Uytterhoeven wrote: > smtpencryption = ssl I do have : smtpencryption = tls -- Toralf, pgp key: 872AE508 0076E94E -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Geert Uytterhoeven
Hi David, On Mon, Jul 13, 2015 at 4:57 PM, David Binderman wrote: > Hello there Geert, > > >> In that case we feel obliged to guide you to a proper patch submission. >> >> Please give it a try. We won't bite ;-) > > Since you've been so nice about it, here

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread David Binderman
Hello there Jeff, > Just eyeballing it, that looks right to me. It just needs your > original bug report above the Signed-off-by. Righto. Second try: Hello there, [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not c

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Jeff Dike
> Since you've been so nice about it, here is my umpteenth go at a > linux kernel patch. Just eyeballing it, that looks right to me. It just needs your original bug report above the Signed-off-by. Jeff -- Jeff Dike AddToIt 978-254-0789 (o) 978-394-8986 (c) -

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Thomas Meyer
Am Montag, den 13.07.2015, 17:11 +0200 schrieb Richard Weinberger: > Am 13.07.2015 um 17:08 schrieb Thomas Meyer: > > Am Montag, den 13.07.2015, 16:41 +0200 schrieb Richard Weinberger: > > > Am 13.07.2015 um 16:24 schrieb Thomas Meyer: > > > > > Yeah. And please add a dump_stack() to figure out whe

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 17:08 schrieb Thomas Meyer: > Am Montag, den 13.07.2015, 16:41 +0200 schrieb Richard Weinberger: >> Am 13.07.2015 um 16:24 schrieb Thomas Meyer: Yeah. And please add a dump_stack() to figure out where it was called. >>> >>> I think calling dump_stack() somehow changed th

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Thomas Meyer
Am Montag, den 13.07.2015, 16:41 +0200 schrieb Richard Weinberger: > Am 13.07.2015 um 16:24 schrieb Thomas Meyer: > > > Yeah. And please add a dump_stack() to figure out where it was > > > called. > > > > I think calling dump_stack() somehow changed the errno to 25?! > > > > > +extern __attrib

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread David Binderman
Hello there Geert, > In that case we feel obliged to guide you to a proper patch submission. > > Please give it a try. We won't bite ;-) Since you've been so nice about it, here is my umpteenth go at a linux kernel patch. Signed-off-by: David Binderman

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 16:24 schrieb Thomas Meyer: >> Yeah. And please add a dump_stack() to figure out where it was >> called. > > I think calling dump_stack() somehow changed the errno to 25?! > > +extern __attribute__((regparm(0))) void dump_stack(void); Hmm, maybe the regparm(0) kills your stac

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Thomas Meyer
Am Montag, den 13.07.2015, 16:00 +0200 schrieb Richard Weinberger: > Am 13.07.2015 um 15:58 schrieb Thomas Meyer: > > Am Montag, den 13.07.2015, 15:52 +0200 schrieb Richard Weinberger: > > > On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer > > > wrote: > > > > Hi, > > > > > > > > The uml_net networ

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 15:58 schrieb Thomas Meyer: > Am Montag, den 13.07.2015, 15:52 +0200 schrieb Richard Weinberger: >> On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer >> wrote: >>> Hi, >>> >>> The uml_net network setup "fails" on my computer with: >>> >>> [ 15.93] helper_wait : waitpid process

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Thomas Meyer
Am Montag, den 13.07.2015, 15:52 +0200 schrieb Richard Weinberger: > On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer > wrote: > > Hi, > > > > The uml_net network setup "fails" on my computer with: > > > > [ 15.93] helper_wait : waitpid process 11673 failed, errno = > > 10 > > [ 15.93

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer wrote: > Hi, > > The uml_net network setup "fails" on my computer with: > > [ 15.93] helper_wait : waitpid process 11673 failed, errno = 10 > [ 15.93] * modprobe tun >* ifconfig tap0 192.168.10.1 netmask 255.255.255.255 up >

[uml-devel] uml_net zombie processes

2015-07-13 Thread Thomas Meyer
Hi, The uml_net network setup "fails" on my computer with: [ 15.93] helper_wait : waitpid process 11673 failed, errno = 10 [ 15.93] * modprobe tun * ifconfig tap0 192.168.10.1 netmask 255.255.255.255 up * bash -c echo 1 > /proc/sys/net/ipv4/ip_forward [

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 14:58 schrieb Geert Uytterhoeven: > Hi David, > > On Mon, Jul 13, 2015 at 2:52 PM, David Binderman wrote: >> >>> Can you please render this into a proper patch and re-send to the >>> mailinglist? >> >> I have a 100% failure rate with patc

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Geert Uytterhoeven
Hi David, On Mon, Jul 13, 2015 at 2:52 PM, David Binderman wrote: > >> Can you please render this into a proper patch and re-send to the >> mailinglist? > > I have a 100% failure rate with patches, so doing a proper patch is beyond my > skill set. Sorry.

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread David Binderman
Hello there Richard, > Can you please render this into a proper patch and re-send to the mailinglist? I have a 100% failure rate with patches, so doing a proper patch is beyond my skill set. Sorry. Regards David Binderman

[uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread David Binderman
Hello there, [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end(). Source code is     va_start(ap, str);     while ((arg = va_arg(ap, char **)) != NULL) {     if (*str == '\0')     return NULL;     end = strchr(str, ',');    

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Richard Weinberger
Hi! Can you please render this into a proper patch and re-send to the mailinglist? Thanks, //richard Am 13.07.2015 um 11:08 schrieb David Binderman: > Hello there, > > [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was > opened but not closed by va_end(). > > Source code