Re: [uml-devel] [PATCH] um: Fix pointer cast

2015-12-22 Thread Richard Weinberger
Am 22.12.2015 um 21:44 schrieb Mickaël Salaün: > Fix a pointer cast typo introduced in v4.4-rc5 especially visible for > the i386 subarchitecture where it results in a kernel crash. > > Fixes: 8090bfd2bb9a ("um: Fix fpstate handling") > > Signed-off-by: Mickaël Salaün > Cc:

Re: [uml-devel] [PATCH] um: Fix build error and kconfig for i386

2015-12-22 Thread Richard Weinberger
Am 22.12.2015 um 22:44 schrieb Mickaël Salaün: > Fix build error by selecting COREDUMP when X86_32 is selected: > > arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': > (.text+0x3e62): undefined reference to `dump_emit' > arch/x86/um/built-in.o: In function

Re: [uml-devel] [PATCH] um: Fix pointer cast

2015-12-22 Thread Al Viro
On Tue, Dec 22, 2015 at 09:44:01PM +0100, Mickaël Salaün wrote: > Fix a pointer cast typo introduced in v4.4-rc5 especially visible for > the i386 subarchitecture where it results in a kernel crash. Why the hell bother casting it at all? _Any_ pointer will quietly convert to void *, no typecasts