[uml-devel] [PATCH] um: Fix _print_addr()

2017-03-12 Thread Richard Weinberger
Recent changes to printk() broke UML's stack trace output. Kill the root of the problem by using a single printk() statement. Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing continuation lines") Cc: sta...@vger.kernel.org Cc: Vegard Nossum Tested-by: Vegard Nossum Reported-by:

Re: [uml-devel] [PATCH] um: use KERN_CONT in stack dump

2017-03-12 Thread Vegard Nossum
On 12/03/2017 10:45, Richard Weinberger wrote: > Am 12.03.2017 um 10:38 schrieb Vegard Nossum: >> Without KERN_CONT, the symbol will appear on a new line, making stack >> traces completely unreadable: [snip] > I think it is better to fix the root of the problem by using a single printk. > i.e. > >

Re: [uml-devel] [PATCH] um: use KERN_CONT in stack dump

2017-03-12 Thread Richard Weinberger
Vegard, Am 12.03.2017 um 10:38 schrieb Vegard Nossum: > Without KERN_CONT, the symbol will appear on a new line, making stack > traces completely unreadable: > > Call Trace: > [<6008e891>] ? > printk+0x0/0x94 > [<6001cce6>] > show_stack+0xfe/0x15b > [<600666ec>] ? >

[uml-devel] [PATCH] um: use KERN_CONT in stack dump

2017-03-12 Thread Vegard Nossum
Without KERN_CONT, the symbol will appear on a new line, making stack traces completely unreadable: Call Trace: [<6008e891>] ? printk+0x0/0x94 [<6001cce6>] show_stack+0xfe/0x15b [<600666ec>] ? dump_stack_print_info+0xe1/0xea [<6008e891>] ? printk+0x0/0x94