Re: [uml-devel] [RFC PATCH 1/7] um: Use printk instead of printf in make_uml_dir

2017-05-21 Thread Richard Weinberger
On Wed, May 17, 2017 at 10:35 AM, Thomas Meyer wrote: >> On Tue, 16 May 2017 17:46:47 +0200 >> Thomas Meyer wrote: >> >>> Hi, >>> >>> as far as I understand everything under os-Linux should be OS specific >>> and shouldn't rely on kernel functions. >> >> I see,

Re: [uml-devel] [RFC][PATCH] um: Remove proc command from mconsole

2017-05-21 Thread Al Viro
On Sun, May 21, 2017 at 11:19:03PM +0200, Richard Weinberger wrote: > This feature is another abuser of set_fs(). > Reading proc files from the host side is a debugging feature > with no security checks at all. The path is not sanitized, therefore > any file could be read. ITYM "any file on

Re: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins

2017-05-21 Thread Richard Weinberger
Thomas, On Wed, May 17, 2017 at 10:41 PM, Thomas Meyer wrote: > For some reasons I don't know users-offsets.s get's build before the > gcc-plugins itself. Can you please figure? I want to make sure that we really fix the root cause and not just papering over a symptom. --

Re: [uml-devel] [PATCH] um: Add mark_rodata_ro support.

2017-05-21 Thread Richard Weinberger
Thomas, On Thu, May 18, 2017 at 12:11 AM, Thomas Meyer wrote: > This is actually a no-op as all read-only should be read-only in the ELF. What problem does this patch fix? Or what is the purpose? -- Thanks, //richard

[uml-devel] [RFC][PATCH] um: Remove proc command from mconsole

2017-05-21 Thread Richard Weinberger
This feature is another abuser of set_fs(). Reading proc files from the host side is a debugging feature with no security checks at all. The path is not sanitized, therefore any file could be read. Let's get rid of it. Signed-off-by: Richard Weinberger --- Hi! Unless I miss