Jan Kiszka wrote:
> Paolo Giarrusso wrote:
>> On Mon, May 10, 2010 at 19:43, Jan Kiszka wrote:
>>> Lukas Czerner wrote:
>>>> Hi,
>>>>
>>>> I have got an error when booting uml with Linked list manipulation
>>>> debugging turned o
Paolo Giarrusso wrote:
> On Mon, May 10, 2010 at 19:43, Jan Kiszka wrote:
>> Lukas Czerner wrote:
>>> Hi,
>>>
>>> I have got an error when booting uml with Linked list manipulation
>>> debugging turned on. The crash occurs in the exact moment when the
Lukas Czerner wrote:
> Hi,
>
> I have got an error when booting uml with Linked list manipulation
> debugging turned on. The crash occurs in the exact moment when the
> consoles are showing up - it just blinks and crush. Here is the
> backtrace:
>
>
> #0 0x003cb8233e14 in abort () from /lib
Amerigo Wang wrote:
> On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote:
>> The i386 subarch happens to pull in original NR_syscalls. Maybe we can
>> make that work for all host arch, but for now just avoid the clash by
>> using an all-upper-case name.
>>
&g
Jeff Dike wrote:
> On Mon, Apr 19, 2010 at 10:12:04PM +0200, Jiri Kosina wrote:
>> Well, if Jeff isn't actively maintaining UML any more, either you can take
>> over the maintainership yourself, or feed the non-trivial patches through
>> Andrew Morton.
>
> Yes, these generally go through Andrew.
Jeff Dike wrote:
> On Tue, Apr 20, 2010 at 06:09:49PM +0800, Amerigo Wang wrote:
>> On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote:
>>> We can't pull in linux/sched.h, so just declare the struct.
>>>
>> Did you meet any build error? If yes, please
Lukas Czerner wrote:
> arch/um/drivers/line.c
> - need to include linux/slab.h since the code uses kmalloc.
> - fix warning message with unused variable tty
>
> arch/um/os-Linux/helper.c
> - there is no need to include linux/slab.h since allocations are
> done with uml_kmalloc
The build fixes
We can't pull in linux/sched.h, so just declare the struct.
Signed-off-by: Jan Kiszka
---
arch/um/sys-i386/asm/elf.h |2 ++
arch/um/sys-x86_64/asm/elf.h |2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/um/sys-i386/asm/elf.h b/arch/um/sys-i386/asm/elf.h
Signed-off-by: Jan Kiszka
---
arch/um/drivers/line.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index 7a656bd..7f7338c 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -19,7 +19,6 @@ static
Remove duplicates and unused prototypes.
Signed-off-by: Jan Kiszka
---
arch/um/include/asm/system.h |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/um/include/asm/system.h b/arch/um/include/asm/system.h
index 753346e..93af1cf 100644
--- a/arch/um/include/asm
Already defined in kernel.h. The official version assumes that 'n' is
power of two - which it is in our case.
Signed-off-by: Jan Kiszka
---
arch/um/sys-x86_64/signal.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/
The i386 subarch happens to pull in original NR_syscalls. Maybe we can
make that work for all host arch, but for now just avoid the clash by
using an all-upper-case name.
Signed-off-by: Jan Kiszka
---
arch/um/kernel/skas/syscall.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions
Some trivial build warning fixes and cleanups for UML.
Jan Kiszka (5):
uml: Remove unused variable from line driver
uml: Drop private round_down definition
uml: Fix warning due to missing task_struct declaration
uml: i386: Avoid redefinition of NR_syscalls
uml: Clean up asm/system.h
Jiri Kosina wrote:
> On Mon, 19 Apr 2010, Jan Kiszka wrote:
>
>>> I suppose this patch will go through um tree?
>> Good question. Does such a tree exist? I'm sitting on a few more um
>> cleanups & fixes, and so far I'm working against Linus' tr
Tejun Heo wrote:
> Hello,
>
> On 04/19/2010 01:37 AM, Jan Kiszka wrote:
>> We now have to to include linux/slab.h explicitly for kmalloc & friends.
>> Files that build against host headers already get their prototypes via
>> um_malloc.h, linux/slab.h may even be un
Hi Jeff,
is there (still) any reason to use explicit clone() instead of pthreads
to spawn UML kernel threads?
While playing with a patch to finally move os_nsecs to proper
CLOCK_MONOTONIC, I noticed some subtle side-effect: We need to link
against librt for clock_gettime, but that indirectly drag
We now have to to include linux/slab.h explicitly for kmalloc & friends.
Files that build against host headers already get their prototypes via
um_malloc.h, linux/slab.h may even be unavailable.
Signed-off-by: Jan Kiszka
---
arch/um/drivers/line.c|1 +
arch/um/os-Linux/helper.c |
Tiger Yang wrote:
> This patch replace kmalloc() with uml_kmalloc() in line.c and
> remove an unused variable.
This driver does not require the wrapping. I'll post a patch to unbreak
uml build in a minute.
Jan
>
> Signed-off-by: Tiger Yang
> ---
> arch/um/drivers/line.c |8
> 1 f
18 matches
Mail list logo
