Re: [uml-devel] [PATCH v2.6.36-rc7] ubd: fix incorrect sector handling during request restart

2010-10-15 Thread Jens Axboe
d use it to > correctly restart io_req issue. Thanks Tejun, good to see this one resolved. -- Jens Axboe -- Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-08 Thread Jens Axboe
return; } + dev->rq_offset += sg->length >> 9; dev->start_sg++; } dev->end_sg = 0; -- Jens Axboe ---

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-01 Thread Jens Axboe
truct scatterlist *sg = &dev->sg[dev->start_sg]; @@ -1273,6 +1275,7 @@ static void do_ubd_request(struct request_queue *q) } dev->start_sg++; +

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-01 Thread Jens Axboe
On 2010-09-29 10:29, Chris Frey wrote: > On Wed, Sep 29, 2010 at 08:10:06AM +0900, Jens Axboe wrote: >> It looks like that if we need to restart the requeue, then >> we use the initial position and not the current index. Does >> this help? >> >> diff --git a/arc

Re: [uml-devel] [Git Patch] arch/um/drivers/ubd_kern.c: fix a building error

2007-10-24 Thread Jens Axboe
c:1118: warning: passing argument 6 of > 'prepare_request' makes pointer from integer without a cast > make[1]: *** [arch/um/drivers/ubd_kern.o] Error 1 > make: *** [arch/um/drivers] Error 2 > > Signed-off-by:

Re: [uml-devel] [PATCH 06/11] uml ubd driver: ubd_io_lock usage fixup

2006-10-30 Thread Jens Axboe
27;s a residual of 2.4 block layer interface). Sometimes you need to. I'd probably just remove the do_ubd check and always recall the request function when handling completions, it's easier and safe. -- Jens Axboe -

[uml-devel] Re: [patch 7/7] uml ubd: handle readonly status

2005-04-26 Thread Jens Axboe
On Mon, Apr 25 2005, Blaisorblade wrote: > On Monday 25 April 2005 12:16, Jens Axboe wrote: > > On Sun, Apr 24 2005, [EMAIL PROTECTED] wrote: > > > @@ -1099,6 +1104,7 @@ static int prepare_request(struct reques > > > if((rq_data_dir(req) == WRITE) && !dev-&g

[uml-devel] Re: [patch 7/7] uml ubd: handle readonly status

2005-04-25 Thread Jens Axboe
ce for something interesting. As the io happens async, you will get a boring trace that doesn't contain any valuable information. -- Jens Axboe --- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds