[uml-devel] [PATCH] um: vDSO: fix vdsop allocation

2011-11-01 Thread Jiri Kosina
The kmalloc() call in init_vdso() has reverse order of arguments. Signed-off-by: Jiri Kosina --- arch/um/sys-x86_64/vdso/vma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/um/sys-x86_64/vdso/vma.c b/arch/um/sys-x86_64/vdso/vma.c index 9495c8d..91f4ec9 100644

Re: [uml-devel] [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls

2010-05-10 Thread Jiri Kosina
de/asm/unistd_32.h:349:1: warning: this is > >the location of the previous definition > > > > Ah, sure. I misunderstood your purpose, please do include the warning > messages you are trying to fix in your patch description. The patch doesn't seem to be pre

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-21 Thread Jiri Kosina
;t care that much. If you want to avoid trivial tree for some reason, feel free to do so. -- Jiri Kosina SUSE Labs, Novell Inc. -- ___ User-mode-linux-devel maili

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-21 Thread Jiri Kosina
; This is the right reason to do this. Ok then, thanks. > > But it looks like x86_64 needs this too. > > > BTW, I don't think compile warning fixes are trivial enough to go > to triv...@kernel.org. Why? -- Jiri Kosina SUSE Labs, Novell Inc.

Re: [uml-devel] [PATCH 3/5] uml: Fix warning due to missing task_struct declaration

2010-04-20 Thread Jiri Kosina
he other question in this thread: We have a circular > dependency that prevents including sched.h. > > I can add all these information to some v2 of this patch if it is > required to get this merged. Please let me know. I have updated

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jiri Kosina
f > either of them changed, then this would cause unexpected compile > failures here. > > Better to explicitly include kernel.h. Yeah, I have that already in my tree. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. --

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jiri Kosina
> > > struct k_sigaction *ka, struct pt_regs * regs, > > > siginfo_t *info, sigset_t *set) > > > > Shouldn't this signal.c #include ? > > I agree - if this is going to depend on kernel.h, it should be > explic

Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition

2010-04-20 Thread Jiri Kosina
struct k_sigaction *ka, struct pt_regs * regs, > > siginfo_t *info, sigset_t *set) > > Shouldn't this signal.c #include ? Well, it gets included implicitly through uaccess.h -> sched.h -> kernel.h. Applied, thanks. -- Jiri Kosina SUSE Labs,

Re: [uml-devel] [PATCH 5/5] uml: Clean up asm/system.h

2010-04-20 Thread Jiri Kosina
On Mon, 19 Apr 2010, Jan Kiszka wrote: > Remove duplicates and unused prototypes. > > Signed-off-by: Jan Kiszka Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- Download Intel® Parallel Studio Eva

Re: [uml-devel] [PATCH 1/5] uml: Remove unused variable from line driver

2010-04-20 Thread Jiri Kosina
chan_interrupt(&line->chan_list, &line->task, line->tty, irq); Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- Download Intel® Parallel Studio Eval Try the new software tools for yourself.

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Jiri Kosina
simpler to keep the queue. Well, if Jeff isn't actively maintaining UML any more, either you can take over the maintainership yourself, or feed the non-trivial patches through Andrew Morton. -- Jiri Kosina SUSE Labs, Novell Inc. ---

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Jiri Kosina
e recent. If these are simple-enough cleanups and/or compile fixes, feel free to send them to triv...@kernel.org. -- Jiri Kosina SUSE Labs, Novell Inc. -- Download Intel® Parallel Studio Eval Try the new software tool

Re: [uml-devel] uml compile error

2008-02-08 Thread Jiri Kosina
27;: > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c:328: error: > dereferencing pointer to incomplete type > make[3]: *** [fs/hostfs/hostfs_kern.o] Error 1 I guess we need this one? From: Jiri Kosina <[EMAIL PROTECTED]> UML: fix hostfs build We need to incl