[uml-devel] Advice to all glibc 2.12 users

2011-10-09 Thread Richard Weinberger
glibc 2.12's pthread_cond_signal() is broken on UML because it does not have FUTEX_WAKE_OP. The issue got fixed in 2.12.2: http://sourceware.org/ml/libc-alpha/2010-08/msg00019.html Sadly, some distros (like CentOS 6.0) still ship glibc 2.12.1. So you have to expect problems when them on top of

Re: [uml-devel] [PATCH 19/55] um: irq: Remove IRQF_DISABLED

2011-09-22 Thread Richard Weinberger
when handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Richard Weinberger rich...@nod.at signature.asc Description: OpenPGP digital signature

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-30 Thread Richard Weinberger
Am 30.08.2011 04:48, schrieb Al Viro: On Tue, Aug 30, 2011 at 01:23:31AM +0100, Al Viro wrote: On Tue, Aug 30, 2011 at 12:25:25AM +0200, Richard Weinberger wrote: I'm building most of the time static. Using defconfig and CONFIG_STATIC_LINK=y it builds fine here (x86_64 and i386) 32bit

[uml-devel] [PATCH] um: fix strrchr problems

2011-08-30 Thread Richard Weinberger
implementation. This workaround comes originally from Jeff Dike: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494995#35 ] CC: jd...@addtoit.com Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Makefile |2 +- 1 files changed, 1

[uml-devel] [PATCH 2/9] um: drivers/xterm.c: fix a file descriptor leak

2011-08-29 Thread Richard Weinberger
j.neuschae...@gmx.net Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/xterm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c index 8ac7146..2e1de57 100644 --- a/arch/um/drivers/xterm.c +++ b/arch/um/drivers

[uml-devel] UML fixes for 3.1-rcX

2011-08-29 Thread Richard Weinberger
[PATCH 1/9] um: disable CMPXCHG_DOUBLE as it breaks UML build [PATCH 2/9] um: drivers/xterm.c: fix a file descriptor leak [PATCH 3/9] um: Save FPU registers between task switches [PATCH 4/9] um: fix oopsable race in line_close() [PATCH 5/9] um: winch_interrupt() can happen inside of free_winch()

[uml-devel] [PATCH 1/9] um: disable CMPXCHG_DOUBLE as it breaks UML build

2011-08-29 Thread Richard Weinberger
is disabled for UML. Signed-off-by: Thadeu Lima de Souza Cascardo casca...@holoscopio.com Cc: Christoph Lameter c...@linux.com Cc: Jeff Dike jd...@addtoit.com Cc: Richard Weinberger rich...@nod.at Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Kconfig.x86 |4 1 files changed

[uml-devel] [PATCH 4/9] um: fix oopsable race in line_close()

2011-08-29 Thread Richard Weinberger
will blow up trying to dereference pointers from kfree'd struct tty. Fix is obvious: we need to use a counter of our own. Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/line.c| 25 - arch/um/include

[uml-devel] [PATCH 7/9] um: PTRACE_[GS]ETFPXREGS had been wired on the wrong subarch

2011-08-29 Thread Richard Weinberger
From: Al Viro v...@ftp.linux.org.uk It's 32bit-only, not 64bit-only... And while we are at it, it's set_fpxregs(), not set_fpregs()... Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/sys-i386/ptrace.c | 14 +- arch/um

[uml-devel] [PATCH 5/9] um: winch_interrupt() can happen inside of free_winch()

2011-08-29 Thread Richard Weinberger
From: Al Viro v...@ftp.linux.org.uk ... so set winch-fd to -1 before doing free_irq(), to avoid having winch_interrupt() come from/during the latter and attempt to do reactivate_fd() on something that's already gone. Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard

[uml-devel] [PATCH 6/9] um: fix free_winch() mess

2011-08-29 Thread Richard Weinberger
...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/line.c | 38 -- 1 files changed, 24 insertions(+), 14 deletions(-) diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c index 91bf1894..364c8a1 100644 --- a/arch

[uml-devel] [PATCH 3/9] um: Save FPU registers between task switches

2011-08-29 Thread Richard Weinberger
process. The patch below reintroduces the saving and restoring of the FP context between task switches. Signed-off-by: Ingo van Lil ing...@gmx.de Signed-off-by: Richard Weinberger rich...@nod.at Reported-by: gunnarlindr...@hotmail.com Tested-by: gunnarlindr...@hotmail.com CC: Stanislav Meduna st

[uml-devel] [PATCH 2/9] um: drivers/xterm.c: fix a file descriptor leak

2011-08-29 Thread Richard Weinberger
j.neuschae...@gmx.net Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/xterm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c index 8ac7146..2e1de57 100644 --- a/arch/um/drivers/xterm.c +++ b/arch/um/drivers

[uml-devel] [PATCH 6/9] um: fix free_winch() mess

2011-08-29 Thread Richard Weinberger
...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/line.c | 38 -- 1 files changed, 24 insertions(+), 14 deletions(-) diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c index 91bf1894..364c8a1 100644 --- a/arch

[uml-devel] UML fixes for 3.1-rcX (2nd try)

2011-08-29 Thread Richard Weinberger
Sorry for sending this patch series again. My mail server thought I'm a spammer. :-\ [PATCH 1/9] um: disable CMPXCHG_DOUBLE as it breaks UML build [PATCH 2/9] um: drivers/xterm.c: fix a file descriptor leak [PATCH 3/9] um: Save FPU registers between task switches [PATCH 4/9] um: fix oopsable race

[uml-devel] [PATCH 1/9] um: disable CMPXCHG_DOUBLE as it breaks UML build

2011-08-29 Thread Richard Weinberger
is disabled for UML. Signed-off-by: Thadeu Lima de Souza Cascardo casca...@holoscopio.com Cc: Christoph Lameter c...@linux.com Cc: Jeff Dike jd...@addtoit.com Cc: Richard Weinberger rich...@nod.at Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Kconfig.x86 |4 1 files changed

[uml-devel] [PATCH 3/9] um: Save FPU registers between task switches

2011-08-29 Thread Richard Weinberger
process. The patch below reintroduces the saving and restoring of the FP context between task switches. Signed-off-by: Ingo van Lil ing...@gmx.de Signed-off-by: Richard Weinberger rich...@nod.at Reported-by: gunnarlindr...@hotmail.com Tested-by: gunnarlindr...@hotmail.com CC: Stanislav Meduna st

[uml-devel] [PATCH 9/9] um: clean arch_ptrace() up a bit

2011-08-29 Thread Richard Weinberger
From: Al Viro v...@ftp.linux.org.uk 1) take subarch-specific stuff to subarch_ptrace() 2) PTRACE_{PEEK,POKE}{TEXT,DATA} is handled by ptrace_request() just fine... Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/ptrace

[uml-devel] [PATCH 4/9] um: fix oopsable race in line_close()

2011-08-29 Thread Richard Weinberger
will blow up trying to dereference pointers from kfree'd struct tty. Fix is obvious: we need to use a counter of our own. Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/line.c| 25 - arch/um/include

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
Am 29.08.2011 23:27, schrieb Andrew Morton: Subject: [PATCH 8/9] um: fix strrchr problems What are the problems? On Mon, 29 Aug 2011 18:13:38 +0200 Richard Weinbergerrich...@nod.at wrote: From: Al Virov...@ftp.linux.org.uk Several years old patch, originally by jdike, I think...

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
Am 30.08.2011 00:12, schrieb Al Viro: On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: ok, I give up. How does this work? *grrr*, you can drop this patch. To my excuse, I've dropped it already from my queue but after pulling a second time from Al's git branch it made

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
Am 30.08.2011 00:19, schrieb Al Viro: On Tue, Aug 30, 2011 at 12:15:59AM +0200, Richard Weinberger wrote: Am 30.08.2011 00:12, schrieb Al Viro: On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: ok, I give up. How does this work? *grrr*, you can drop this patch. To my

Re: [uml-devel] SYSCALL, ptrace and syscall restart breakages (Re: [RFC] weird crap with vdso on uml/i386)

2011-08-24 Thread Richard Weinberger
Am 23.08.2011 19:07, schrieb Al Viro: On Tue, Aug 23, 2011 at 06:58:18PM +0200, Richard Weinberger wrote: What about this hack/solution? While booting UML can check whether the host's vDSO contains a SYSCALL instruction. If so, UML will not make the host's vDSO available to it's processes

Re: [uml-devel] SYSCALL, ptrace and syscall restart breakages (Re: [RFC] weird crap with vdso on uml/i386)

2011-08-23 Thread Richard Weinberger
Am 23.08.2011 18:53, schrieb Al Viro: On Tue, Aug 23, 2011 at 09:29:29AM -0700, Linus Torvalds wrote: Oh yes. System call performance is *important*. And x86 is *important*. UML? In comparison, not that important. So quite frankly, if this is purely an UML issue (and unless we're missing

Re: [uml-devel] SYSCALL, ptrace and syscall restart breakages (Re: [RFC] weird crap with vdso on uml/i386)

2011-08-23 Thread Richard Weinberger
Am 23.08.2011 19:07, schrieb Al Viro: On Tue, Aug 23, 2011 at 06:58:18PM +0200, Richard Weinberger wrote: What about this hack/solution? While booting UML can check whether the host's vDSO contains a SYSCALL instruction. If so, UML will not make the host's vDSO available to it's processes

[uml-devel] [RFC] UML/x86_64 module loader

2011-08-22 Thread Richard Weinberger
Hi! UserModeLinux is using the arch specific module functions from arch/x86/kernel/module.c. On i386 this works perfectly fine but on x86_64 it causes problems. apply_relocate_add() assumes modules compiled with -mcmodel=kernel because the kernel lives in the negative 2GiB of the address

Re: [uml-devel] [RFC] weird crap with vdso on uml/i386

2011-08-20 Thread Richard Weinberger
Am 20.08.2011 03:18, schrieb Al Viro: 3) with the previous two issues dealt with, we get the following magical mistery shite when running 32bit uml kernel + userland on 64bit host: * the system boots all the way to getty/login and sshd (i.e. gets through the debian /etc/init.d

Re: [uml-devel] [RFC] weird crap with vdso on uml/i386

2011-08-20 Thread Richard Weinberger
Am 20.08.2011 22:14, schrieb Al Viro: On Sat, Aug 20, 2011 at 05:22:23PM +0200, Richard Weinberger wrote: Hmmm, very strange. Sadly I cannot reproduce the issue. :( Everything works fine within UML. (Of course I've applied your vDSO/i386 patches) My test setup: Host kernel: 2.6.37

Re: [uml-devel] [RFC] weird crap with vdso on uml/i386

2011-08-20 Thread Richard Weinberger
Am 20.08.2011 23:26, schrieb Andrew Lutomirski: On Sat, Aug 20, 2011 at 4:55 PM, Richard Weinbergerrich...@nod.at wrote: Am 20.08.2011 22:14, schrieb Al Viro: On Sat, Aug 20, 2011 at 05:22:23PM +0200, Richard Weinberger wrote: Hmmm, very strange. Sadly I cannot reproduce the issue

Re: [uml-devel] Subject: [PATCH 00/91] pending uml patches

2011-08-19 Thread Richard Weinberger
Am 19.08.2011 06:31, schrieb Al Viro: On Thu, Aug 18, 2011 at 08:19:46PM +0100, Al Viro wrote: On Thu, Aug 18, 2011 at 09:12:47PM +0200, Richard Weinberger wrote: Have you touched your patches since yesterday? I've already pulled and uploaded them to my shiny new git repo at: git

Re: [uml-devel] Floating point problems on UML - help needed

2011-08-18 Thread Richard Weinberger
Am 18.08.2011 08:29, schrieb Stanislav Meduna: On 17.08.2011 22:58, Richard Weinberger wrote: It looks like FPU registers get sometimes lost after switching between two or more threads. This is probably a bug in UML I reported nearly three years ago. For me mode=skas0 worked aruond

Re: [uml-devel] Subject: [PATCH 00/91] pending uml patches

2011-08-18 Thread Richard Weinberger
Al, Am 18.08.2011 20:58, schrieb Al Viro: My apologies for mailbomb from hell. *All* this stuff is available in git://git.kernel.org/pub/scm/linux/kernel/git/viro/um-header.git/ #master, but since uml folks had been stuck with mail and patch for a long time... Have you touched your patches

[uml-devel] shm updates broke UML

2011-08-01 Thread Richard Weinberger
call_usermodehelper, arg=0x9c6bce0, jmp_ptr=0x9c73d94) at arch/um/os-Linux/process.c:268 #24 0x080588cb in new_thread_handler () at arch/um/kernel/process.c:153 #25 0x in ?? () ---cut--- Not-Signed-off-by: Richard Weinberger rich...@nod.at --- diff --git a/ipc/shm.c b/ipc/shm.c index

Re: [uml-devel] shm updates broke UML

2011-08-01 Thread Richard Weinberger
Hi Vasiliy, On Montag 01 August 2011 15:49:11 Vasiliy Kulikov wrote: Hi Richard, On Mon, Aug 01, 2011 at 15:41 +0200, Richard Weinberger wrote: 5774ed01 (shm: handle separate PID namespaces case) b34a6b1d (ipc: introduce shm_rmid_forced sysctl) 4c677e2e (shm: optimize locking

Re: [uml-devel] shm updates broke UML

2011-08-01 Thread Richard Weinberger
On Montag 01 August 2011 19:10:42 Vasiliy Kulikov wrote: On Mon, Aug 01, 2011 at 18:01 +0200, Marc Zyngier wrote: It also breaks ARM (at least 11MPCore and Cortex A9). The same workaround gets the kernel booting again. Can you please apply this patch and show the output? I suppose all

Re: [uml-devel] [PATCH 07/10] um: Set __HAVE_ARCH_GATE_AREA for x86_64

2011-07-23 Thread Richard Weinberger
Am Samstag 23 Juli 2011, 01:01:27 schrieb Andrew Morton: On Thu, 21 Jul 2011 11:18:31 +0200 Richard Weinberger rich...@nod.at wrote: Implement arch_vma_name() and make get_gate_vma(), in_gate_area() and in_gate_area_no_mm() a nop. We need arch_vma_name() to support vDSO. Well

[uml-devel] [PATCH 03/10] uml: drivers/slip_user.c memory leak fix

2011-07-21 Thread Richard Weinberger
From: Vitaliy Ivanov vitaliva...@gmail.com Do not free memory when you failed to allocate it. Signed-off-by: Vitaliy Ivanov vitaliva...@gmail.com Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/slip_user.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

[uml-devel] [PATCH 10/10] um: Remove dead code

2011-07-21 Thread Richard Weinberger
GCC 4.6's -Wunused-but-set-variable found some dead code. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/chan_kern.c |3 +-- arch/um/drivers/line.c |3 +-- arch/um/kernel/reboot.c |3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git

[uml-devel] [PATCH 07/10] um: Set __HAVE_ARCH_GATE_AREA for x86_64

2011-07-21 Thread Richard Weinberger
Implement arch_vma_name() and make get_gate_vma(), in_gate_area() and in_gate_area_no_mm() a nop. We need arch_vma_name() to support vDSO. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/sys-x86_64/asm/elf.h |1 + arch/um/sys-x86_64/mem.c | 22 ++ 2

[uml-devel] [PATCH 08/10] um: Implement a x86_64 vDSO

2011-07-21 Thread Richard Weinberger
still uses the vsyscall page for static binaries this patch improves the situation only for dynamic binaries. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/sys-x86_64/Makefile |2 + arch/um/sys-x86_64/asm/elf.h |9 +++ arch/um/sys-x86_64/vdso/Makefile

[uml-devel] [PATCH 06/10] um: Set __HAVE_ARCH_GATE_AREA for i386

2011-07-21 Thread Richard Weinberger
When UML is unable to reuse the host's vDSO FIXADDR_USER_START is zero. To handle this special case correclty we have to implement custom gate area helper methods. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/sys-i386/Makefile |2 +- arch/um/sys-i386/asm/elf.h |2 + arch

[uml-devel] [PATCH 04/10] uml: free resources

2011-07-21 Thread Richard Weinberger
From: Davidlohr Bueso d...@gnu.org When creating the temp file there's a memory and file descriptor leak upon error. Signed-off-by: Davidlohr Bueso d...@gnu.org Signed-off-by: Richard Weinberger rich...@nod.at Reviewed-by: Vitaliy Ivanov vitaliva...@gmail.com --- arch/um/os-Linux/mem.c |6

[uml-devel] [PATCH 09/10] um: Ajdust size of pid_buf

2011-07-21 Thread Richard Weinberger
Linux can have pids up to 4*1024*1024. To handle such huge numbers pid_buf needs to be larger. Reported-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/harddog_user.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[uml-devel] [PATCH 05/10] um: Disable scan_elf_aux() on x86_64

2011-07-21 Thread Richard Weinberger
Reusing the host's vDSO makes only sense on x86_32. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/Makefile |4 +++- arch/um/os-Linux/elf_aux.c |7 +-- arch/um/os-Linux/main.c|4 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/arch

[uml-devel] [PATCH] uml: drivers/net_user.c memory leak fix

2011-07-21 Thread Richard Weinberger
From: Vitaliy Ivanov vitaliva...@gmail.com Perform memory cleanup on exit. On receiving invalid 'pid' we still should clean 'output' variable. Signed-off-by: Vitaliy Ivanov vitaliva...@gmail.com Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/net_user.c |5 - 1

Re: [uml-devel] [PATCH 3/3] um: Implement a x86_64 vDSO

2011-07-20 Thread Richard Weinberger
Am Mittwoch 20 Juli 2011, 19:54:02 schrieb Andy Lutomirski: On 07/18/2011 09:07 AM, Richard Weinberger wrote: Until now UML had no x86_64 vDSO. So glibc always used the vsyscall page for gettimeday() and friends. Calls to gettimeday() returned falsely the host time and confused some

[uml-devel] [PATCH 3/3] um: Implement a x86_64 vDSO

2011-07-18 Thread Richard Weinberger
still uses the vsyscall page for static binaries this patch improves the situation only for dynamic binaries. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/sys-x86_64/Makefile |2 + arch/um/sys-x86_64/asm/elf.h |9 +++ arch/um/sys-x86_64/vdso/Makefile

[uml-devel] [PATCH 1/3] um: Disable scan_elf_aux() on x86_64

2011-07-18 Thread Richard Weinberger
Reusing the host's vsyscall area makes only sense on x86_32. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/Makefile |4 +++- arch/um/os-Linux/elf_aux.c |7 +-- arch/um/os-Linux/main.c|4 3 files changed, 8 insertions(+), 7 deletions(-) diff

[uml-devel] [PATCH 2/3] um: Set __HAVE_ARCH_GATE_AREA

2011-07-18 Thread Richard Weinberger
Implement arch_vma_name() and make get_gate_vma(), in_gate_area() and in_gate_area_no_mm() a nop. We need arch_vma_name() to support vDSO. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/sys-x86_64/asm/elf.h |1 + arch/um/sys-x86_64/mem.c | 22 ++ 2

Re: [uml-devel] [PATCH 3/3] uml: os-Linux/main.c memory leak fix

2011-07-08 Thread Richard Weinberger
Am Freitag 08 Juli 2011, 12:16:20 schrieb Vitaliy Ivanov: On Thu, Jul 7, 2011 at 7:48 PM, Richard Weinberger rich...@nod.at wrote: Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov: From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov

Re: [uml-devel] [PATCH 1/3] uml: drivers/net_user.c memory leak fix

2011-07-08 Thread Richard Weinberger
Am Freitag 08 Juli 2011, 12:30:56 schrieb Vitaliy Ivanov: On Thu, Jul 7, 2011 at 8:27 PM, Richard Weinberger rich...@nod.at wrote: Am Donnerstag 07 Juli 2011, 18:36:02 schrieb Vitaliy Ivanov: From 9b9f36f46aa708c3245f5ded83f96421966b2edf Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov

Re: [uml-devel] [PATCH 1/3] uml: drivers/net_user.c memory leak fix

2011-07-08 Thread Richard Weinberger
vitaliva...@gmail.com Signed-off-by: Richard Weinberger rich...@nod.at Why are you adding my Signed-off-by?! That's my job... --- arch/um/drivers/net_user.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/um/drivers/net_user.c b/arch/um/drivers/net_user.c

Re: [uml-devel] [PATCH] uml: free resources

2011-07-07 Thread Richard Weinberger
Am Donnerstag 07 Juli 2011, 15:08:22 schrieb Vitaliy Ivanov: On Thu, Jul 7, 2011 at 7:02 AM, Davidlohr Bueso d...@gnu.org wrote: From: Davidlohr Bueso d...@gnu.org When creating the temp file there's a memory and file descriptor leak upon error. Signed-off-by: Davidlohr Bueso

Re: [uml-devel] [PATCH 3/3] uml: os-Linux/main.c memory leak fix

2011-07-07 Thread Richard Weinberger
Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov: From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov vitaliva...@gmail.com Date: Thu, 7 Jul 2011 19:29:06 +0300 Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix We should cleanup

Re: [uml-devel] [PATCH 1/3] uml: drivers/net_user.c memory leak fix

2011-07-07 Thread Richard Weinberger
Am Donnerstag 07 Juli 2011, 18:36:02 schrieb Vitaliy Ivanov: From 9b9f36f46aa708c3245f5ded83f96421966b2edf Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov vitaliva...@gmail.com Date: Thu, 7 Jul 2011 19:23:13 +0300 Subject: [PATCH 1/3] uml: drivers/net_user.c memory leak fix Perform memory

Re: [uml-devel] [PATCH 1/4] uml: cow_user.c warning corrections

2011-07-05 Thread Richard Weinberger
Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov: From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov vitaliva...@gmail.com Date: Tue, 5 Jul 2011 01:57:51 +0300 Subject: [PATCH 1/4] uml: cow_user.c warning corrections MIME-Version: 1.0

Re: [uml-devel] [PATCH 2/4] uml: helper.c warning corrections

2011-07-05 Thread Richard Weinberger
Am Dienstag 05 Juli 2011, 01:15:47 schrieb Vitaliy Ivanov: From 7296c5b9770e95cd6ad4e9e71d2d14c972abdfe1 Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov vitaliva...@gmail.com Date: Tue, 5 Jul 2011 02:03:06 +0300 Subject: [PATCH 2/4] uml: helper.c warning corrections MIME-Version: 1.0

Re: [uml-devel] [PATCH 1/4] uml: cow_user.c warning corrections

2011-07-05 Thread Richard Weinberger
Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov: On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger rich...@nod.at wrote: Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov: From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov

Re: [uml-devel] [PATCH 1/4] um: Fix _FORTIFY_SOURCE=2 support for kernel modules

2011-06-29 Thread Richard Weinberger
Am Mittwoch 29 Juni 2011, 17:37:54 schrieb Vitaliy Ivanov: On Tue, Jun 28, 2011 at 1:15 AM, Richard Weinberger rich...@nod.at wrote: When UML is compiled with _FORTIFY_SOURCE we have to export all _chk() functions which are used in modules. For now it's only the case for __sprintf_chk

Re: [uml-devel] [PATCH 1/4] um: Fix _FORTIFY_SOURCE=2 support for kernel modules

2011-06-29 Thread Richard Weinberger
Am Mittwoch 29 Juni 2011, 18:42:43 schrieb Geert Uytterhoeven: On Wed, Jun 29, 2011 at 17:42, Richard Weinberger rich...@nod.at wrote: Am Mittwoch 29 Juni 2011, 17:37:54 schrieb Vitaliy Ivanov: On Tue, Jun 28, 2011 at 1:15 AM, Richard Weinberger rich...@nod.at wrote: When UML is compiled

Re: [uml-devel] linux-next: Tree for June 27 (uml)

2011-06-27 Thread Richard Weinberger
Am Montag 27 Juni 2011, 17:27:33 schrieb Randy Dunlap: On Mon, 27 Jun 2011 16:16:56 +1000 Stephen Rothwell wrote: Hi all, Changes since 20110624: uml defconfig builds on x86 (32-bit and 64-bit) fail with: fs/hostfs/hostfs_kern.c:756: error: 'mask' undeclared (first use in this

[uml-devel] [PATCH 1/4] um: Fix _FORTIFY_SOURCE=2 support for kernel modules

2011-06-27 Thread Richard Weinberger
When UML is compiled with _FORTIFY_SOURCE we have to export all _chk() functions which are used in modules. For now it's only the case for __sprintf_chk(). Tested-by: Florian Fainelli flor...@openwrt.org Reported-by: Florian Fainelli flor...@openwrt.org Signed-off-by: Richard Weinberger rich

[uml-devel] [PATCH 2/4] um: Add netpoll support

2011-06-27 Thread Richard Weinberger
To make netconsole usable on UML, it's ethernet driver needs netpoll support. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/net_kern.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers

[uml-devel] [PATCH 3/4] um, exec: remove redundant set_fs(USER_DS)

2011-06-27 Thread Richard Weinberger
From: Mathias Krause mini...@googlemail.com The address limit is already set in flush_old_exec() so this set_fs(USER_DS) is redundant. Signed-off-by: Mathias Krause mini...@googlemail.com Cc: Richard Weinberger rich...@nod.at Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/kernel

[uml-devel] [PATCH 4/4] um: Reinstate kernel version in generated .config

2011-06-27 Thread Richard Weinberger
, kconfig falls back to the default string Linux Kernel Configuration. Add a suitable mainmenu to the main UML Kconfig file to fix this. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Kconfig.x86 |2 ++ 1 files changed, 2

[uml-devel] [PATCH v2] um: Clean up delay functions

2011-06-18 Thread Richard Weinberger
Both sys-i386 and sys-x86_64 support now ndelay(). The delay functions are based on arch/x86/lib/delay.c. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/delay.h | 10 +++ arch/um/sys-i386/delay.c| 59 -- arch/um/sys

Re: [uml-devel] [PATCH] um: Reinstate kernel version in generated .config

2011-06-18 Thread Richard Weinberger
Am Samstag 18 Juni 2011, 23:34:25 schrieb Geert Uytterhoeven: commit 0954828fcbf3bd13d593499b16b901a4e801b0b9 (kconfig: replace KERNELVERSION usage by the mainmenu's prompt) made the kernel version disappear from the generated .config file when configuring for UML. As UML's Kconfig doesn't

[uml-devel] [PATCH] um: Clean up vm-flags.h

2011-06-16 Thread Richard Weinberger
There is no need to define VM_{STACK,DATA}_DEFAULT_FLAGS as variable. It's also useless to test for TIF_IA32 as 64bit UML has no IA32 emulation. Signed-off-by: Richard Weinberger rich...@nod.at CC: randy.dun...@oracle.com CC: mho...@suse.cz CC: torva...@linux-foundation.org --- arch/um/sys

[uml-devel] [PATCH] Fix infinite loop in search_binary_handler()

2011-06-16 Thread Richard Weinberger
-by: Richard Weinberger rich...@nod.at --- fs/exec.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index 97e0d52..7271b22 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1411,7 +1411,10 @@ int search_binary_handler(struct linux_binprm *bprm,struct

Re: [uml-devel] [PATCH 2/2] um: disable compile-time buffer checks

2011-06-12 Thread Richard Weinberger
Am Sonntag 12 Juni 2011, 13:14:41 schrieb Florian Fainelli: From: Nicolas Thill n...@openwrt.org Ubuntu 8.10 and newer enable compile-time buffer checks by default, which can sometime cause build failures like this: LD vmlinux SYSMAP System.map SYSMAP .tmp_System.map LINK

Re: [uml-devel] [PATCH 1/2] um: disable funit-at-a-time for gcc 4.3

2011-06-12 Thread Richard Weinberger
Am Sonntag 12 Juni 2011, 13:14:39 schrieb Florian Fainelli: From: Nicolas Thill n...@openwrt.org Building UML with gcc 4.3 with -funit-at-a-time for i386 causes startup crashes, disabling funit-at-a-time works around it. Can you show me such a crash? How can I reproduce the issue? UML

Re: [uml-devel] [PATCH 2/2] um: disable compile-time buffer checks

2011-06-12 Thread Richard Weinberger
Am Sonntag 12 Juni 2011, 23:52:35 schrieb Florian Fainelli: Le dimanche 12 juin 2011 13:56:14, Richard Weinberger a écrit : Am Sonntag 12 Juni 2011, 13:14:41 schrieb Florian Fainelli: From: Nicolas Thill n...@openwrt.org Ubuntu 8.10 and newer enable compile-time buffer checks

Re: [uml-devel] [PATCH] um, exec: remove redundant set_fs(USER_DS)

2011-06-10 Thread Richard Weinberger
Am Freitag 10 Juni 2011, 15:10:57 schrieb Mathias Krause: The address limit is already set in flush_old_exec() so this set_fs(USER_DS) is redundant. Signed-off-by: Mathias Krause mini...@googlemail.com Cc: Richard Weinberger rich...@nod.at Applied. Thanks, //richard

[uml-devel] [PATCH 2/2] um: Clean up delay functions

2011-06-07 Thread Richard Weinberger
Both sys-i386 and sys-x86_64 support now ndelay(). The delay functions are based on arch/x86/lib/delay.c. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/delay.h |8 + arch/um/sys-i386/delay.c| 63 --- arch/um/sys

[uml-devel] [PATCH 1/2] um: Add asm/percpu.h

2011-06-07 Thread Richard Weinberger
To make SLUB work on UML we need this_cpu_cmpxchg from asm-generic/percpu.h. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/percpu.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) create mode 100644 arch/um/include/asm/percpu.h diff --git a/arch/um

Re: [uml-devel] [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-04 Thread Richard Weinberger
[for x86 portion] The UML part is now fine for me. :-) Acked-by: Richard Weinberger rich...@nod.at Thanks, //richard -- Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap

Re: [uml-devel] [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Richard Weinberger
Am Donnerstag 02 Juni 2011, 23:04:58 schrieb Eric Paris: b/arch/um/sys-i386/shared/sysdep/ptrace.h index d50e62e..ef5c310 100644 --- a/arch/um/sys-i386/shared/sysdep/ptrace.h +++ b/arch/um/sys-i386/shared/sysdep/ptrace.h @@ -162,6 +162,7 @@ struct syscall_args { #define UPT_ORIG_SYSCALL(r)

Re: [uml-devel] [PATCH] Audit: push audit success and retcode into arch ptrace.h

2011-06-02 Thread Richard Weinberger
Am Freitag 03 Juni 2011, 01:00:51 schrieb Tony Luck: But there seems to be another problem. Why is pt_regs of type void *? gcc complains: In file included from include/linux/fsnotify.h:15:0, from include/linux/security.h:26, from init/main.c:32:

[uml-devel] [PATCH 1/2] um: Add asm/percpu.h

2011-06-01 Thread Richard Weinberger
To make SLUB work on UML we need this_cpu_cmpxchg from asm-generic/percpu.h. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/percpu.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) create mode 100644 arch/um/include/asm/percpu.h diff --git a/arch/um

[uml-devel] [PATCH 2/2] um: Clean up delay functions

2011-06-01 Thread Richard Weinberger
Both sys-i386 and sys-x86_64 support now ndelay(). The delay functions are based on arch/x86/lib/delay.c. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/delay.h |8 + arch/um/sys-i386/delay.c| 63 --- arch/um/sys

Re: [uml-devel] [PATCH 5/7] um: print info about fatal segfaults

2011-05-24 Thread Richard Weinberger
Am Dienstag 24 Mai 2011, 21:34:33 schrieb Andrew Morton: Please see the nice comment in printk.h /* * Please don't use printk_ratelimit(), because it shares ratelimiting state * with all other unrelated printk_ratelimit() callsites. Instead use * printk_ratelimited() or plain old

[uml-devel] [PATCH v2] um: use RWSEM_GENERIC_SPINLOCK on x86

2011-05-23 Thread Richard Weinberger
toralf.foers...@gmx.de Tested-by: Toralf Förster toralf.foers...@gmx.de Cc: Thomas Gleixner t...@linutronix.de Cc: sta...@kernel.org # .39.x Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Kconfig.x86 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um

[uml-devel] [PATCH 2/7] um: remove SIGHUP handler

2011-05-22 Thread Richard Weinberger
The UML kernel ignores SIGHUP anyway. This handler is in vain. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c index 39613ea..fb2a97a 100644

[uml-devel] [PATCH 5/7] um: print info about fatal segfaults

2011-05-22 Thread Richard Weinberger
Print a short info about fatal segfaults like other archs do. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/kernel/trap.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/arch/um/kernel/trap.c b/arch/um/kernel/trap.c index 637c650

[uml-devel] [PATCH 1/7] um: fix UML_LIB_PATH

2011-05-22 Thread Richard Weinberger
UML_LIB_PATH is hardcoded to /usr/lib/uml/, on 64bit systems UML_LIB_PATH needs to be /usr/lib64/uml/. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/xterm.c |2 +- arch/um/include/shared/os.h |6 ++ arch/um/os-Linux/main.c |2 +- 3 files changed, 8

[uml-devel] [PATCH 6/7] um: include linux/prefetch.h

2011-05-22 Thread Richard Weinberger
Fix build failures on UML. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/processor-generic.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/um/include/asm/processor-generic.h b/arch/um/include/asm/processor-generic.h index d1d1b0d

[uml-devel] [PATCH 7/7] um: fix crash while os_dump_core()

2011-05-22 Thread Richard Weinberger
os_dump_core() emits SIGTERM to terminate all UML processes. Kernel threads have to exit on SIGTERM instead of calling last_ditch_exit(). Multiple calls to last_ditch_exit() can cause a crash. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/process.c |1 + 1 files

[uml-devel] [PATCH 4/7] um: add ucast ethernet transport.

2011-05-22 Thread Richard Weinberger
no...@cumulusnetworks.com Signed-off-by: Richard Weinberger rich...@nod.at --- Documentation/virtual/uml/UserModeLinux-HOWTO.txt | 10 + arch/um/drivers/Makefile |4 +- arch/um/drivers/mcast.h | 24 --- arch/um/drivers/mcast_kern.c

[uml-devel] [PATCH 2/4] um: fix abort

2011-05-10 Thread Richard Weinberger
. Therefore UML gets killed by SIGSEGV and leaves a ugly log entry in the host's kernel ring buffer. To get rid of this we use our own abort routine. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/util.c | 23 ++- 1 files changed, 22 insertions(+), 1

[uml-devel] [PATCH 4/4] um: os_dump_core() cleanup

2011-05-10 Thread Richard Weinberger
exit call in this context (remove_umid_dir()) by hand. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/shared/os.h |1 + arch/um/os-Linux/umid.c |2 +- arch/um/os-Linux/util.c | 22 +++--- 3 files changed, 9 insertions(+), 16 deletions(-) diff

[uml-devel] [PATCH 3/4] um: remove SIGHUP handler

2011-05-10 Thread Richard Weinberger
The UML kernel ignores SIGHUP anyway. This handler is in vain. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c index 39613ea..fb2a97a 100644

[uml-devel] [PATCH 1/4] um: fix UML_LIB_PATH

2011-05-10 Thread Richard Weinberger
UML_LIB_PATH is hardcoded to /usr/lib/uml/, on 64bit systems UML_LIB_PATH needs to be /usr/lib64/uml/. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/xterm.c |2 +- arch/um/include/shared/os.h |6 ++ arch/um/os-Linux/main.c |2 +- 3 files changed, 8

[uml-devel] [PATCH 2/3] um: add ucast ethernet transport.

2011-05-10 Thread Richard Weinberger
no...@cumulusnetworks.com Signed-off-by: Richard Weinberger rich...@nod.at --- Documentation/uml/UserModeLinux-HOWTO.txt | 10 ++ arch/um/drivers/Makefile |4 +- arch/um/drivers/mcast.h | 24 arch/um/drivers/mcast_kern.c | 120

[uml-devel] [PATCH 3/3] um: print info about fatal segfaults

2011-05-10 Thread Richard Weinberger
Print a short info about fatal segfaults like other archs do. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/kernel/trap.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/arch/um/kernel/trap.c b/arch/um/kernel/trap.c index 637c650

[uml-devel] [PATCH 1/3] um: add earlyprintk support

2011-05-10 Thread Richard Weinberger
User Mode Linux can also benefit from earlyprintk. UML's earlyprintk writes kernel messages directly to stdout. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Kconfig.debug | 10 ++ arch/um/include/shared/os.h |1 + arch/um/kernel/Makefile |1

[uml-devel] [PATCH 4/4] um: os_dump_core() cleanup

2011-05-08 Thread Richard Weinberger
exit call in this context (remove_umid_dir()) by hand. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/shared/os.h |1 + arch/um/os-Linux/umid.c |2 +- arch/um/os-Linux/util.c | 22 +++--- 3 files changed, 9 insertions(+), 16 deletions(-) diff

[uml-devel] [PATCH 3/4] um: remove SIGHUP handler

2011-05-08 Thread Richard Weinberger
The UML kernel ignores SIGHUP anyway. This handler is in vain. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c index 39613ea..fb2a97a 100644

[uml-devel] [PATCH 1/4] um: fix UML_LIB_PATH

2011-05-08 Thread Richard Weinberger
UML_LIB_PATH is hardcoded to /usr/lib/uml/, on 64bit systems UML_LIB_PATH needs to be /usr/lib64/uml/. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/drivers/xterm.c |2 +- arch/um/include/shared/os.h |7 +++ arch/um/os-Linux/main.c |2 +- 3 files changed, 9

Re: [uml-devel] [PATCH 1/4] um: fix UML_LIB_PATH

2011-05-08 Thread Richard Weinberger
Am Montag 09 Mai 2011, 00:19:53 schrieb Mattia Dongili: On Sun, May 08, 2011 at 11:59:42PM +0200, Richard Weinberger wrote: UML_LIB_PATH is hardcoded to /usr/lib/uml/, on 64bit systems UML_LIB_PATH needs to be /usr/lib64/uml/. Signed-off-by: Richard Weinberger rich...@nod.at

Re: [uml-devel] [PATCH] um: Adjust current_thread_info() for gcc-4.6

2011-04-22 Thread Richard Weinberger
Am Freitag 22 April 2011, 02:10:50 schrieb Kirill A. Shutemov: Also reproducible with gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4). Interesting. Using gcc 4.5.1 it's not reproducible. So I've to rewrite the commit message. Thanks, //richard

<    2   3   4   5   6   7   8   >