}
> > }
> >
> >
> > I was trying to print 'output' only in case change_tramp is
> > successful. That's the old logic. And at the same time perform free
> > only in case output is not NULL.
>
> Why?
> Freeing a NULL pointer i
>> BTW, you said that you will share your git tree on kernel.org, is
>> there any news? I'm tracking what patches are accepted not to resend
>> them again.
>
> Yeah, I'll announce it on user-mode-linux-devel@lists.sourceforge.net.
> It's done when it's done. :-P
Sure. No problems.
- Vitaliy
On Thu, Jul 7, 2011 at 8:27 PM, Richard Weinberger wrote:
> Am Donnerstag 07 Juli 2011, 18:36:02 schrieb Vitaliy Ivanov:
>> >From 9b9f36f46aa708c3245f5ded83f96421966b2edf Mon Sep 17 00:00:00 2001
>>
>> From: Vitaliy Ivanov
>> Date: Thu, 7 Jul 2011 19:23:13 +03
On Thu, Jul 7, 2011 at 7:48 PM, Richard Weinberger wrote:
> Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov:
>> >From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001
>>
>> From: Vitaliy Ivanov
>> Date: Thu, 7 Jul 2011 19:29:06 +0300
&
>From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov
Date: Thu, 7 Jul 2011 19:29:06 +0300
Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix
We should cleanup memory even though 'putenv' fails.
Signed-off-by: Vitaliy Ivanov
---
arc
>From d4f92205b89eedb5054091b9fc0e0186e9acd88b Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov
Date: Thu, 7 Jul 2011 19:27:32 +0300
Subject: [PATCH 2/3] uml: drivers/slip_user.c memory leak fix
Do not free memory when you failed to allocate it.
Signed-off-by: Vitaliy Ivanov
---
arch/um/driv
>From 9b9f36f46aa708c3245f5ded83f96421966b2edf Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov
Date: Thu, 7 Jul 2011 19:23:13 +0300
Subject: [PATCH 1/3] uml: drivers/net_user.c memory leak fix
Perform memory cleanup on exit.
On receiving invalid 'pid' we still should clean
Richard,
Here is a set of fixes for UML memory leak cleanups.
arch/um/drivers/net_user.c |5 +++--
arch/um/drivers/slip_user.c |3 +--
arch/um/os-Linux/main.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
Thanks,
Vitaliy
-
gt; if (out_tempname) {
> *out_tempname = tempname;
> } else
> free(tempname);
> return fd;
> +close:
> + close(fd);
> out:
> free(tempname);
> return -1;
> --
Reviewed-by: Vitaliy Ivanov
On Tue, Jul 5, 2011 at 3:02 PM, Richard Weinberger wrote:
> Am Dienstag 05 Juli 2011, 13:45:06 schrieb Vitaliy Ivanov:
>> It's always better not to think whether it's possible but simply kill
>> all the chances for this to happen.
>> In this case that's pre
Richard,
On Tue, Jul 5, 2011 at 12:42 PM, Richard Weinberger wrote:
> Am Dienstag 05 Juli 2011, 01:15:47 schrieb Vitaliy Ivanov:
>> From 7296c5b9770e95cd6ad4e9e71d2d14c972abdfe1 Mon Sep 17 00:00:00 2001
>> From: Vitaliy Ivanov
>> Date: Tue, 5 Jul 2011 02:03:06 +0300
>&g
On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger wrote:
> Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
>> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
>> From: Vitaliy Ivanov
>> Date: Tue, 5 Jul 2011 01:57:51 +0300
>&g
From 7296c5b9770e95cd6ad4e9e71d2d14c972abdfe1 Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov
Date: Tue, 5 Jul 2011 02:03:06 +0300
Subject: [PATCH 2/4] uml: helper.c warning corrections
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
arch/um/os-Linux
From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov
Date: Tue, 5 Jul 2011 01:57:51 +0300
Subject: [PATCH 1/4] uml: cow_user.c warning corrections
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
arch/um/drivers
On Wed, Jun 29, 2011 at 6:42 PM, Richard Weinberger wrote:
> Am Mittwoch 29 Juni 2011, 17:37:54 schrieb Vitaliy Ivanov:
>> On Tue, Jun 28, 2011 at 1:15 AM, Richard Weinberger wrote:
>> > When UML is compiled with _FORTIFY_SOURCE we have to
>> > export all _chk()
On Tue, Jun 28, 2011 at 1:15 AM, Richard Weinberger wrote:
> When UML is compiled with _FORTIFY_SOURCE we have to
> export all _chk() functions which are used in modules.
> For now it's only the case for __sprintf_chk().
>
> Tested-by: Florian Fainelli
> Reported-by: Florian Fainelli
> Signed-of
16 matches
Mail list logo