[uml-devel] [PATCH 1/1] hostfs: fix UML crash (remove f_spare from hostfs)

2010-10-19 Thread Richard Weinberger
365b1818 resized f_spare within struct statfs which caused a UML crash. There is no need to copy f_spare. Signed-off-by: Richard Weinberger Reported-by: Toralf Förster Tested-by: Toralf Förster LKML-Reference: <20101019011125.ga3...@lst.de> --- fs/hostfs/hostfs.h |3 +-- fs/hostfs/hos

Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-19 Thread Richard Weinberger
On Tue, 19 Oct 2010 03:11:25 +0200, Christoph Hellwig wrote: > On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote: >> > > >> > > Is there any reason for hostfs to be playing with the f_spare field at >> > > all? > > No, there is no reason at all. do_statfs is only called by > hostfs_

Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-18 Thread Christoph Hellwig
On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote: > > > > > > Is there any reason for hostfs to be playing with the f_spare field at > > > all? No, there is no reason at all. do_statfs is only called by hostfs_statfs, which is the hostfs implementation of ->statfs. zeroing of the

Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-18 Thread Andrew Morton
On Mon, 18 Oct 2010 20:53:58 +0200 Richard Weinberger wrote: > Am Montag 18 Oktober 2010, 20:40:39 schrieb Andrew Morton: > > On Mon, 18 Oct 2010 18:36:54 +0200 Richard Weinberger > wrote: > > > 365b1818 resized f_spare within struct statfs. > > > hostfs accesses f_spare directly and needs an u

Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-18 Thread Geert Uytterhoeven
On Mon, Oct 18, 2010 at 21:31, Richard Weinberger wrote: > Am Montag 18 Oktober 2010, 21:22:31 schrieb Geert Uytterhoeven: >> On Mon, Oct 18, 2010 at 20:40, Andrew Morton > wrote: >> > On Mon, 18 Oct 2010 18:36:54 +0200 Richard Weinberger > wrote: >> >> 365b1818 resized f_spare within struct sta

Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-18 Thread Geert Uytterhoeven
On Mon, Oct 18, 2010 at 20:40, Andrew Morton wrote: > On Mon, 18 Oct 2010 18:36:54 +0200 Richard Weinberger wrote: >> 365b1818 resized f_spare within struct statfs. >> hostfs accesses f_spare directly and needs an update. >> >> Signed-off-by: Richard Weinberger >> Reported-by: Toralf F__rster >

Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-18 Thread Andrew Morton
On Mon, 18 Oct 2010 18:36:54 +0200 Richard Weinberger wrote: > 365b1818 resized f_spare within struct statfs. > hostfs accesses f_spare directly and needs an update. > > Signed-off-by: Richard Weinberger > Reported-by: Toralf F__rster > Tested-by: Toralf F__rster > --- > fs/hostfs/hostfs_use

[uml-devel] [PATCH 1/1] hostfs: fix UML crash

2010-10-18 Thread Richard Weinberger
365b1818 resized f_spare within struct statfs. hostfs accesses f_spare directly and needs an update. Signed-off-by: Richard Weinberger Reported-by: Toralf Förster Tested-by: Toralf Förster --- fs/hostfs/hostfs_user.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/