On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote:
> We normally use "comments" for that, not dead code that a compiler
> then elids ;-)
I'd argue that comments are for when you can't make the code
self-explanatory.
> [PATCH] hostfs: Remove pointless if statement
>
> And replace with
Jeff Dike <[EMAIL PROTECTED]> writes:
> [ This is both 2.6.24 and -stable material ]
>
> SuSE seems to require that binaries have a .note.SuSE section.
> Without it, UML segfaults if any parameters are passed on the command
> line.
This doesn't make any sense. You must have misanalyzed this.
-A
Hi Jeff,
I'm really sorry, but I forget to mention, that I had the same problems on a
RedHat RH4 (x86_64) too.
> On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote:
> > this sounds like something really stupid and bad... why would the kernel
> > need to have a per-distro note se
On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote:
>
> The crash is in this section:
>
> __uml_setup_start = .;
> .uml.setup.init : { *(.uml.setup.init) }
> __uml_setup_end = .;
This looks like a classic bug.
You wanted this:
.uml.setup.init : {
__uml_setup_start = .;
Tidy the tlb flushing code.
With tt mode gone, there is no reason to have the capability to have
different host-level address space updating routines. So, do_op is
called directly from do_mmap, do_mprotect, and do_munmap, rather than
calling a function pointer that it is given.
There was a large
A number of files that were changed in the recent removal of tt mode
are userspace files which call the os_* wrappers instead of calling
libc directly. A few other files were affected by this, through
This patch makes these call glibc directly.
There are also style fixes in the affected areas.
These patches are 2.6.24 material.
They are code cleanup, plus a minor bug fix.
Jeff
--
Work email - jdike at linux dot intel dot com
-
This SF.net email is sponsored by: Splunk Inc.
Still g
The BLKGETSIZE ioctl expects a pointer to a long, os_file_size was providing
an int. Therefore, ubd access to host block devices caused a segmentation
fault on 64 bits systems.
Signed-off-by: Nicolas George <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/os-Linux/file.
"extern inline" will have different semantics with gcc 4.3.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
include/asm-um/pgalloc.h |2 +-
include/asm-um/pgtable-3level.h |2 +-
include/asm-um/processor-x86_64.h |2 +-
include
Get rid of an empty if statement which might look like a bug to a
casual reader.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
fs/hostfs/hostfs_user.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.22/fs/hostfs/hostfs_user.c
==
Style fixes in hostfs.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
fs/hostfs/hostfs.h |9 +
fs/hostfs/hostfs_kern.c | 226
fs/hostfs/hostfs_user.c | 139 +
3 files changed, 202 insertions(+), 172 deletions
11 matches
Mail list logo
