Make sure that we return EIO if one passes an invalid st.mode
into hostfs.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 92b008f..8163aac 100644
Be consistent with all other functions in hostfs and just
use __getname().
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index
Host got a visit from the janitor.
[PATCH 01/15] hostfs: hostfs_file_open: Switch to data locking model
[PATCH 02/15] hostfs: hostfs_file_open: Fix a fd leak in
[PATCH 03/15] hostfs: Allow fsync on directories
[PATCH 04/15] hostfs: Handle bogus st.mode
[PATCH 05/15] hostfs: Make hostfs_readpage mo
hostfs has an "append" mount option. Report it.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index c60d886..06b3e3f 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b
In case of a race between to callers of hostfs_file_open()
it can happen that a file describtor is leaked.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 104d58d..112ba5a
Instead of serializing hostfs_file_open() we can use
a per inode mutex to protect ->mode.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
in
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 3082a7e..7260f16 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -105,11
There is really no point in having a function with 10
arguments.
Reported-by: Daniel Walter
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs.h | 3 +--
fs/hostfs/hostfs_kern.c | 5 +
fs/hostfs/hostfs_user.c | 17 +++--
3 files changed, 5 insertions(+), 20 deletions
Only initialize what we really need.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 80ced3d..cf80a30 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs
In case of an error set the page error flag and clear the up-to-date
flag.
If the read was successful clear the error flag unconditionally.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/hostfs
...otherwise we might end up with an incorrect mode mode.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 8bbceae..80ced3d 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 06b3e3f..8bbceae 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -318,9 +318,7
...to make life easier for future readers of that code.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 8163aac..67e556c 100644
--- a/fs
The kernel offers a helper function for that, use it.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index f154747..f82f98a5 100644
--- a/fs/hostfs
hostfs' __dentry_name() relies on the fact that dentry_path_raw() will place
the path name at the end of the provided buffer.
While this is okay, add a BUG_ON() to detect behavior changes as soon
as possible.
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 7 +++
1
speaking correct common userspace
like dpkg(1) stumbles over that and makes it impossible to use
hostfs as root filesystem.
The fix is easy, wire up the existing host open/fsync functions
to the directory file operations.
Reported-by: Daniel Gröber
Signed-off-by: Richard Weinberger
---
fs/hostfs
Am 16.03.2015 um 13:03 schrieb Geert Uytterhoeven:
> On Mon, Mar 16, 2015 at 12:41 PM, Richard Weinberger wrote:
>> --- a/fs/hostfs/hostfs_kern.c
>> +++ b/fs/hostfs/hostfs_kern.c
>> @@ -105,11 +105,10 @@ static char *__dentry_name(struct dentry *dentry, char
>> *name)
Am 20.03.2015 um 16:53 schrieb Laurent Dufour:
> Some architecture would like to be triggered when a memory area is moved
> through the mremap system call.
>
> This patch is introducing a new arch_remap mm hook which is placed in the
> path of mremap, and is called before the old area is unmapped
Am 16.03.2015 um 14:23 schrieb Toralf Förster:
> On 03/15/2015 05:56 PM, Richard Weinberger wrote:
>> Then please move the hardened gcc to /dev/null. ;-)
>
> yes, at least to compile the UML linux
>
>> If you can tell me what hardening feature is the root cause I can
Currently hostfs issues every time a seekdir(), in fact
it has to do this only upon the first call.
Also telldir() can be omitted as we can obtain the directory
offset from readdir().
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs.h | 3 ++-
fs/hostfs/hostfs_kern.c | 1 +
fs
.
With SKAS0 mode (separated kernel address space using 0 host patches),
default since 2005, SKAS3/4 is obsolete and can be removed.
Signed-off-by: Richard Weinberger
---
arch/um/include/shared/os.h | 2 -
arch/um/include/shared/skas/proc_mm.h| 44 --
arch/um/include
That code is a relict from the early days of UML.
ia64 support was never completed nor worked.
Let's rip it out.
Signed-off-by: Richard Weinberger
---
arch/um/Makefile-ia64 | 1 -
arch/um/sys-ia64/Makefile | 11 ---
arch/um/sys-ia64/sysdep/ptrace.h
Remove left over code from commit 970e51feaddb
(um: Add support for CONFIG_STACKTRACE)
Signed-off-by: Richard Weinberger
---
arch/um/kernel/sysrq.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index 894c8d3..aa1b56f
Highmem was always buggy and experimental on UML(i386).
In times where 64 bit computers are default we can
remove that experimental code.
Signed-off-by: Richard Weinberger
---
arch/um/Kconfig.um| 12
arch/um/include/asm/fixmap.h | 4 ---
arch/um/include/asm/pgtable.h | 6
At times where UML used the TT mode to operate it had
kind of SMP support. It never got finished nor was
stable.
Let's rip out that cruft and stop confusing developers
which do tree-wide SMP cleanups.
If someone wants SMP support UML it has do be done from scratch.
Signed-off-by: Ri
That code is a relict from the early days of UML.
ppc support was never completed nor worked.
Let's rip it out.
Signed-off-by: Richard Weinberger
---
arch/um/Makefile-ppc| 9 ---
arch/um/sys-ppc/Makefile| 65
arch/um/sys-pp
On Fri, Apr 3, 2015 at 4:51 PM, Thomas Meyer wrote:
> Print a more sensible message about the minimum physical memory
> requirement.
>
> Signed-off-by: Thomas Meyer
All of your three patches are queued for 4.1! :-)
--
Thanks,
//richard
-
Andrey Ryabinin (1):
x86, UML: fix integer overflow in ELF_ET_DYN_BASE
Richard Weinberger (22):
hostfs: hostfs_file_open: Switch to data locking model
hostfs: hostfs_file_open: Fix a fd leak in hostfs_file_open
hostfs: Allow
hch and Al found that hppfs has some serious issues[0].
As the filesystem as never marked as stable nor in heavy use
we decided to rip it out.
If someone is using it, speak up now. I plan to remove it in the v4.2
merge window.
Now we have FUSE which can be used to implement such a filesystem
in a
hppfs (honeypot procfs) was an attempt to use UML as honeypot.
It was never stable nor in heavy use.
As Al Viro and Christoph Hellwig pointed some major issues out
it is better to let it die.
Signed-off-by: Richard Weinberger
---
arch/um/Kconfig.um | 15 --
fs/Makefile| 1 -
fs
On Fri, Apr 24, 2015 at 9:58 PM, Thomas Meyer wrote:
> Am Montag, den 20.10.2014, 11:56 +0200 schrieb Richard Weinberger:
>> Am 20.10.2014 um 11:51 schrieb Thomas Meyer:
>> >> Hmm, does this always happen?
>> >
>> > Yes, my single core system seems
Am 26.04.2015 um 20:32 schrieb Richard Weinberger:
> On Fri, Apr 24, 2015 at 9:58 PM, Thomas Meyer wrote:
>> Any ideas?
>
> Can you give the attached patch a try?
> Let's see if it proves my theory.
> Looks like UML's clocksource needs fixing.
Please give also
Hi!
Am 26.04.2015 um 22:57 schrieb Thomas Meyer:
> Am Sonntag, den 26.04.2015, 20:32 +0200 schrieb Richard Weinberger:
>> On Fri, Apr 24, 2015 at 9:58 PM, Thomas Meyer wrote:
>>> Am Montag, den 20.10.2014, 11:56 +0200 schrieb Richard Weinberger:
>>>> Am 20.10.2014
On Mon, Apr 27, 2015 at 7:47 AM, Anton Ivanov
wrote:
> On 26/04/15 22:00, Richard Weinberger wrote:
>>
>>>> Can you give the attached patch a try?
>>>> Let's see if it proves my theory.
>>>> Looks like UML's clocksource needs fixing.
>&
S_IFMT is obviously wrong and needs to be 0777.
We're interested in the file mode, not the type.
Fixes: b98b91029c (hostfs: No need to box and later unbox the file mode)
Reported-by: Markus Stenberg
Signed-off-by: Richard Weinberger
---
fs/hostfs/hostfs_kern.c | 2 +-
1 file chang
Am 04.05.2015 um 15:22 schrieb Geert Uytterhoeven:
> On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger wrote:
>> --- a/fs/hostfs/hostfs_kern.c
>> +++ b/fs/hostfs/hostfs_kern.c
>> @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct
>> d
On Sun, May 10, 2015 at 1:14 AM, Thomas Meyer wrote:
> Hi,
>
> Changes:
> - also create posix timer in stub_clone_handler()
> - incorporated antons remarks
Hm, this patch does a *lot* more than the changelog says.
>
> diff --git a/arch/um/Makefile b/arch/um/Makefile
> index 17d4460..a4a434f 1006
Am 10.05.2015 um 16:34 schrieb Thomas Meyer:
>
>> Am 10.05.2015 um 14:35 schrieb Richard Weinberger
>> :
>>
>>> On Sun, May 10, 2015 at 1:14 AM, Thomas Meyer wrote:
>>> Hi,
>>>
>>> Changes:
>>> - also create posix timer in stu
Rework UML's uaccess code to reuse as much as possible
from asm-generic/uaccess.c.
Signed-off-by: Richard Weinberger
---
arch/um/include/asm/thread_info.h | 2 +-
arch/um/include/asm/uaccess.h | 176 ++
arch/um/kernel/skas/uaccess.c
um_vdso_addr is defined in asm/elf.h.
Signed-off-by: Richard Weinberger
---
arch/x86/um/vdso/vma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/um/vdso/vma.c b/arch/x86/um/vdso/vma.c
index 916cda4..237c683 100644
--- a/arch/x86/um/vdso/vma.c
+++ b/arch/x86/um/vdso/vma.c
@@ -10,6
...for userspace memory access.
Signed-off-by: Richard Weinberger
---
arch/x86/um/ldt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/um/ldt.c b/arch/x86/um/ldt.c
index 5c0b711..9701a4f 100644
--- a/arch/x86/um/ldt.c
+++ b/arch/x86/um/ldt.c
@@ -6,6 +6,7 @@
#include
#include
It's using put_user() and needs this header.
Signed-off-by: Richard Weinberger
---
arch/x86/um/syscalls_64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/um/syscalls_64.c b/arch/x86/um/syscalls_64.c
index adb08eb..e655227 100644
--- a/arch/x86/um/syscalls_64.c
+++ b/arch/x
By reusing asm-generic/uaccess.h we can drop a lot of UML's
ad-hoc uaccess code and make it much more straightforward.
It uncovered also some header issues which got resolved.
[PATCH 1/5] um: Cleanup mem_32/64.c headers
[PATCH 2/5] um: Add asm/elf.h to vma.c
[PATCH 3/5] um: Add uaccess.h to syscal
Include only headers we really need.
Signed-off-by: Richard Weinberger
---
arch/x86/um/mem_32.c | 3 +--
arch/x86/um/mem_64.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/x86/um/mem_32.c b/arch/x86/um/mem_32.c
index f40281e..744afdc 100644
--- a/arch/x86/um
Am 10.05.2015 um 16:34 schrieb Thomas Meyer:
>
>> Am 10.05.2015 um 14:35 schrieb Richard Weinberger
>> :
>>
>>> On Sun, May 10, 2015 at 1:14 AM, Thomas Meyer wrote:
>>> Hi,
>>>
>>> Changes:
>>> - also create posix timer in stu
.
Richard Weinberger (1):
hostfs: Use correct mask for file mode
fs/hostfs/hostfs_kern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
One dashboard for servers and applications across Physical
On Tue, May 19, 2015 at 6:19 PM, Anton Ivanov
wrote:
> Same story.
>
> Overall works quite well, the moment I give it the "dselect upgrade
> test" the userspace hangs.
>
> Kernel continues to work - forwarding, icmp, uml_mconsole are fine.
Do you know where it hangs?
Maybe the kernel does not get
On Sun, May 17, 2015 at 11:25 AM, Thomas Meyer wrote:
> Switch the UML clocksource from interval timers to posix interval timers
> and move to a monotonic timer.
>
> This fixes suspend&resume related timer issues and improves network
> performance as TCP state machines are now fed with the correct
On Sun, May 24, 2015 at 3:23 PM, Hans-Werner Hilse wrote:
> Compiler compatibility macros were conditionally defined based on
> the compiler version. The it tested __GNUC__, but compared it to
> a maximum value of 4, breaking compilation on now current GCC 5.x.
> Thus, the check is extended to che
On Sun, May 24, 2015 at 6:12 PM, Richard Weinberger
wrote:
> Hmm, instead of continue with that hack it would be much nicer to get rid
> of the copy&pasted __user define.
Hans-Werner, can you please give the attached patch a try?
It should fix your issue too.
--
Thanks,
//richard
di
Am 20.05.2015 um 07:26 schrieb Thomas Meyer:
>
> Am 20.05.2015 12:12 vorm. schrieb Richard Weinberger
> :
>>
>> On Sun, May 17, 2015 at 11:25 AM, Thomas Meyer wrote:
>>> Switch the UML clocksource from interval timers to posix interval timers
>>> and m
Am 04.10.2014 um 15:11 schrieb Chen Gang:
> syscall() is implemented in libc.so/a (e.g. for glibc, in "syscall.o"),
> so for normal ".o" files, it is undefined, neither can be found within
> kernel wide, so will break modpost.
>
> Since ".o" files is OK, can simply export 'syscall' symbol, let mod
Am 12.10.2014 um 13:02 schrieb Nicolas Iooss:
> When declaring __syscall_stub_start, use the same type in UML userspace
> code as in arch/um/include/asm/sections.h.
>
> While at it, also declare batch_syscall_stub as char[].
>
> Signed-off-by: Nicolas Iooss
> ---
> arch/um/os-Linux/skas/mem.c
fault code to detect that situation and
causes a panic() such that the root cause of the unprotected memory
access can be found and fixed.
Signed-off-by: Richard Weinberger
---
arch/um/kernel/trap.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/um/kernel/trap.c b/arch/um/kernel
As we got rid of the __KERNEL__ abuse, we can directly
include linux/compiler.h now.
This also allows gcc 5 to build UML.
Reported-by: Hans-Werner Hilse
Signed-off-by: Richard Weinberger
---
arch/um/include/shared/init.h | 22 +-
1 file changed, 1 insertion(+), 21 deletions
tracehook_report_syscall_entry() is allowed to fail,
in case of failure we have to abort the current syscall.
Signed-off-by: Richard Weinberger
---
arch/um/include/asm/ptrace-generic.h | 2 +-
arch/um/kernel/ptrace.c | 6 +++---
arch/um/kernel/skas/syscall.c| 6 +-
3
Currently UML is abusing __KERNEL__ to distinguish between
kernel and host code (os-Linux). It is better to use a custom
define such that existing users of __KERNEL__ don't get confused.
Signed-off-by: Richard Weinberger
---
arch/um/Makefile| 7 ---
arch/um/dr
mconsole depends on CONFIG_PROC_FS.
Signed-off-by: Richard Weinberger
---
arch/um/Kconfig.um | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/um/Kconfig.um b/arch/um/Kconfig.um
index bd5459c..28a9885 100644
--- a/arch/um/Kconfig.um
+++ b/arch/um/Kconfig.um
@@ -46,6 +46,7 @@ config
Am 31.05.2015 um 21:00 schrieb Thomas Meyer:
>> Ping.
>> Would be nice to have this patch for the 4.2 merge window.
>
> I can provide you the current version of the patch, but I'm not sure if
> it's ready for inclusion yet.
That's fine. I'll look at it.
Just rebase it against Linus' tree or uml-n
On Wed, Jun 10, 2015 at 11:20 PM, Hans-Werner Hilse wrote:
> Glibc provides __ptr_t for the pointer in the stack_t struct,
> but other C libraries - namely musl - do not necessarily do so.
> In that case, fall back to a void* pointer.
Please just kill __ptr_t in UML.
--
Thanks,
//richard
-
On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse wrote:
> Naming local variables "stdin" and "stdout" is fine with glibc,
> other C libraries, namely musl, will however complain.
Wait, what?!
These are not local variables, they are struct members.
What exactly is the issue with musl? Sounds v
On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse wrote:
> The functions in question are not part of the POSIX standard,
> documentation however hints that the corresponding header shall
> be sys/types.h. C libraries other than glibc, namely musl, did
> not include that header via other ways and
On Thu, Jun 11, 2015 at 8:35 AM, Hans-Werner Hilse wrote:
> Hi,
>
> Am 2015-06-10 23:37, schrieb Richard Weinberger:
>> On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse
>> wrote:
>>> Naming local variables "stdin" and "stdout" is fine wi
On Thu, Jun 11, 2015 at 9:54 AM, Hans-Werner Hilse wrote:
> Am 2015-06-11 08:49, schrieb Richard Weinberger:
>> On Thu, Jun 11, 2015 at 8:35 AM, Hans-Werner Hilse
>> wrote:
>>> Hi,
>>>
>>> Am 2015-06-10 23:37, schrieb Richard Weinberger:
>>>&g
On Thu, Jun 11, 2015 at 10:26 AM, Hans-Werner Hilse wrote:
> Am 2015-06-11 10:09, schrieb Richard Weinberger:
>> On Thu, Jun 11, 2015 at 9:54 AM, Hans-Werner Hilse
>> wrote:
>>> About forbidden use of names/identifiers from the stdlib, the C
>>> standard
>&g
Am 15.06.2015 um 16:43 schrieb Firo Yang:
> Gcc5 failed to build uml.
> Update codes to test __GNUC__ with 5 will be happier.
>
> Signed-off-by: Firo Yang
The issue got already addressed by patches:
[PATCH 2/5] um: Stop abusing __KERNEL__
[PATCH 3/5] um: Remove copy&paste code from init.h
They
On Thu, Jun 11, 2015 at 11:29 AM, Hans-Werner Hilse wrote:
> This set of patches facilitate compilation with the musl libc,
> either linked to shared libraries or static.
>
> Hans-Werner Hilse (3):
> um: Do not use __ptr_t type for stack_t's .ss pointer
> um: Do not use stdin and stdout identi
On Fri, Jun 26, 2015 at 10:36 AM, Hans-Werner Hilse wrote:
> I'm sorry but one patch that is necessary for compilation against
> musl libc was still missing in the series I sent earlier.
> (Thank you very much for applying!)
Okay. We can merge it for -rc2.
--
Thanks,
//richard
Do not use stdin and stdout identifiers for struct members
um: Include sys/types.h for makedev(), major(), minor()
Nicolas Iooss (3):
um: Create asm/sections.h
um: Use char[] for linker script address declarations
um/os-Linux: Use char[] for syscall_stub declaration
Commit 30b11ee9a (um: Remove copy&paste code from init.h)
uncovered an issue wrt. out-of-tree builds.
For out-of-tree builds, we must not rely on relative paths.
Before 30b11ee9a it worked by chance as no host code included
generated header files.
Signed-off-by: Richard Weinberger
---
arc
Am 08.07.2015 um 21:15 schrieb Christophe JAILLET:
> Replace a malloc+strcpy by an equivalent strdup in order to improve
> readability.
Makes sense!
> Turn a some spaces into a tab to be consistent with the rest of the code.
Do this in an extra patch. One logical change per patch please.
Thanks
Hi Jeff,
Am 08.07.2015 um 21:56 schrieb Jeff Dike:
> ... Nice patch elided ...
>
> I have a bit of a problem here - Christophe isn't a member of
> uml-devel, so Mailman is sitting on his post until it's approved by a
> list moderator, namely me.
>
> So far, so good, except that my uml-devel pass
Hi!
Can you please render this into a proper patch and re-send to the mailinglist?
Thanks,
//richard
Am 13.07.2015 um 11:08 schrieb David Binderman:
> Hello there,
>
> [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was
> opened but not closed by va_end().
>
> Source code
Am 13.07.2015 um 14:58 schrieb Geert Uytterhoeven:
> Hi David,
>
> On Mon, Jul 13, 2015 at 2:52 PM, David Binderman wrote:
>>
>>> Can you please render this into a proper patch and re-send to the
>>> mailinglist?
>>
>> I have a 100% failure rate with patc
On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer wrote:
> Hi,
>
> The uml_net network setup "fails" on my computer with:
>
> [ 15.93] helper_wait : waitpid process 11673 failed, errno = 10
> [ 15.93] * modprobe tun
>* ifconfig tap0 192.168.10.1 netmask 255.255.255.255 up
>
Am 13.07.2015 um 15:58 schrieb Thomas Meyer:
> Am Montag, den 13.07.2015, 15:52 +0200 schrieb Richard Weinberger:
>> On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer
>> wrote:
>>> Hi,
>>>
>>> The uml_net network setup "fails" on my computer with:
Am 13.07.2015 um 16:24 schrieb Thomas Meyer:
>> Yeah. And please add a dump_stack() to figure out where it was
>> called.
>
> I think calling dump_stack() somehow changed the errno to 25?!
>
> +extern __attribute__((regparm(0))) void dump_stack(void);
Hmm, maybe the regparm(0) kills your stac
Am 13.07.2015 um 17:08 schrieb Thomas Meyer:
> Am Montag, den 13.07.2015, 16:41 +0200 schrieb Richard Weinberger:
>> Am 13.07.2015 um 16:24 schrieb Thomas Meyer:
>>>> Yeah. And please add a dump_stack() to figure out where it was
>>>> called.
>>>
>&g
On Mon, Jul 13, 2015 at 5:12 PM, Thomas Meyer wrote:
> Am Montag, den 13.07.2015, 17:11 +0200 schrieb Richard Weinberger:
>> Am 13.07.2015 um 17:08 schrieb Thomas Meyer:
>> > Am Montag, den 13.07.2015, 16:41 +0200 schrieb Richard Weinberger:
>> > > Am 13.07.2015
On Mon, Jul 27, 2015 at 1:30 PM, Hans-Werner Hilse wrote:
> Hi,
>
> Richard, might I ping you about this one?
>
> Reading other mails on this ML, I reckon' you're quite busy - no
> problem, it's not really critical anyway. Just want to make sure the
> updated patch got noticed.
Thanks for the hea
Hi!
-next faces some build issues on UML because of unmet direct dependencies.
Mostly due to HAS_IOMEM and I2C.
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects
I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMA
On Tue, Jul 14, 2015 at 1:45 PM, Thomas Meyer wrote:
> Switch the UML clocksource from interval timers to posix interval timers and
> move to a monotonic timer.
>
> This fixes suspend&resume related timer issues and improves network
> performance
> as TCP state machines are now fed with the correc
On Wed, Jul 15, 2015 at 3:58 PM, Thomas Meyer wrote:
> Am Mittwoch, den 15.07.2015, 12:12 +0200 schrieb Richard Weinberger:
>> On Mon, Jul 13, 2015 at 5:12 PM, Thomas Meyer
>> wrote:
>> > Am Montag, den 13.07.2015, 17:11 +0200 schrieb Richard Weinberger:
>> >
n execve().
We have to use __WALL to wait for both clone()'ed and
regular childs to detect the termination before and
after an execve().
Reported-and-tested-by: Thomas Meyer
Signed-off-by: Richard Weinberger
---
arch/um/os-Linux/helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deleti
We have to exclude memory locations <= PAGE_SIZE from
the condition and let the kernel mode fault path catch it.
Otherwise a kernel NULL pointer exception will be reported
as a kernel user space access.
Fixes: d2313084e2c (um: Catch unprotected user memory access)
Signed-off-by: Rich
Am 09.08.2015 um 19:53 schrieb Thomas Meyer:
> Switch the UML clocksource from interval timers to posix interval timers and
> move to a monotonic timer.
>
> This fixes suspend&resume related timer issues and improves network
> performance
> as TCP state machines are now fed with the correct time;
On Sat, Aug 15, 2015 at 6:27 PM, Anton Ivanov
wrote:
> On 15/08/15 09:15, Richard Weinberger wrote:
>> Am 09.08.2015 um 19:53 schrieb Thomas Meyer:
>>> Switch the UML clocksource from interval timers to posix interval timers and
>>> move to a monotonic timer.
>&g
On Tue, Aug 18, 2015 at 6:04 PM, Thomas Meyer wrote:
> Am 15.08.2015 10:15 vorm. schrieb Richard Weinberger :
>>
>> Am 09.08.2015 um 19:53 schrieb Thomas Meyer:
>> > Switch the UML clocksource from interval timers to posix interval timers
>> > and
>> >
Hilse (1):
um: Do not rely on libc to provide modify_ldt()
Richard Weinberger (3):
um: Fix out-of-tree build
um: Fix waitpid() usage in helper code
um: Fix kernel mode fault condition
arch/um/Makefile | 4 ++--
arch/um/kernel/trap.c | 2 +-
arch/um/os-Linux
Hi!
CC'ing -devel list.
On Thu, Oct 22, 2015 at 1:29 PM, Ricardo Nunes
wrote:
> I'm trying to use a real hardware driver inside UML and I,ve come to the IRQ
> suppor part.
How do you map the hardware into UML?
> Right now it's failing on request_irq call, so my question is if there is
> any ma
...such that processes within UML can do a ptrace(PTRACE_OLDSETOPTIONS, ...)
Signed-off-by: Richard Weinberger
---
arch/um/include/asm/ptrace-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/um/include/asm/ptrace-generic.h
b/arch/um/include/asm/ptrace-generic.h
index
As long STUB_DATA fits into 32bits we can use a plain mov.
If it will grow at some point in future we will switch to movabsq.
In any case the code is smaller and more easy to read
than the current one
Signed-off-by: Richard Weinberger
---
arch/x86/um/stub_64.S | 5 +
1 file changed, 1
We can use __NR_syscall_max.
Signed-off-by: Richard Weinberger
---
arch/um/kernel/skas/syscall.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c
index 64a8fe5..1683b8e 100644
--- a/arch/um/kernel/skas
To support changing syscall numbers we have to store
it after syscall_trace_enter().
Signed-off-by: Richard Weinberger
---
arch/um/include/shared/os.h | 1 +
arch/um/kernel/skas/syscall.c | 13 +++--
arch/um/os-Linux/skas/process.c | 10 +++---
3 files changed, 11 insertions
syscall_stub is dead code as um is using only
batch_syscall_stub.
Signed-off-by: Richard Weinberger
---
arch/x86/um/stub_32.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/um/stub_32.S b/arch/x86/um/stub_32.S
index b972649..9881680 100644
--- a/arch/x86/um/stub_32.S
+++ b/arch/x86
If UML runs on the host side out of memory, report this
condition more nicely.
Signed-off-by: Richard Weinberger
---
arch/um/kernel/tlb.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/um/kernel/tlb.c b/arch/um/kernel/tlb.c
index 2077248..3777b82
syscall_stub is dead code as um is using only
batch_syscall_stub.
Signed-off-by: Richard Weinberger
---
arch/x86/um/stub_64.S | 13 -
1 file changed, 13 deletions(-)
diff --git a/arch/x86/um/stub_64.S b/arch/x86/um/stub_64.S
index 7160b20..a212445 100644
--- a/arch/x86/um/stub_64.S
syscall_stub is nowhere used these days.
Signed-off-by: Richard Weinberger
---
This time with the correct commit message.
---
arch/x86/um/stub_32.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/um/stub_32.S b/arch/x86/um/stub_32.S
index b972649..9881680 100644
--- a/arch/x86/um
Hi!
Am 25.10.2015 um 19:46 schrieb Anton Ivanov:
> Hi List, hi Richard,
>
> I am going to sort out the UBD patchset next as that has no dependencies on
> timer and the other stuff which is waiting in the queue behind the timers.
>
> That should give UML a significant boost. It is nothing partic
On Wed, Oct 28, 2015 at 5:36 PM, Ricardo Nunes
wrote:
> Hi,
>
> I'm making a UML driver to adapt a real driver to UML and hardware
> emulation.
>
> In this case I have a kernel thread trying to read a register, which is now
> done through a netlink channel to a userspace application (asynchronous
301 - 400 of 845 matches
Mail list logo