Re: [userland-discuss] Code review requested for libxml2...

2011-09-12 Thread Kevin Crowe
Thanks for the feedback Craig, Laca and Vlad! On 09/12/11 01:47 PM, Craig Mohrman wrote: Looks good Kevin. craig - kevin.cr...@oracle.com wrote: Hello, Looking for a review of libxml2 fixes: https://cr.opensolaris.org/action/browse/userland/kc28005/libxml2/webrev/ Requesting feedback

Re: [userland-discuss] Code review requested for libxml2...

2011-09-12 Thread Craig Mohrman
Looks good Kevin. craig - kevin.cr...@oracle.com wrote: > Hello, > > Looking for a review of libxml2 fixes: > https://cr.opensolaris.org/action/browse/userland/kc28005/libxml2/webrev/ > > Requesting feedback from Craig & Laszlo - but anyone else that can > review this and provide feedback

Re: [userland-discuss] Code review requested for libxml2...

2011-09-11 Thread Vladimir Marek
> Thanks for taking time to look at this! > > >The xmlRealloc calls in xinclude.c seems to exhibit the same problem, > >have you considered fixing them? > > Not in this late build for a few reasons: > -less change/less risk for this last build > -in the latest libxml2 source they have not been ch

Re: [userland-discuss] Code review requested for libxml2...

2011-09-11 Thread Kevin Crowe
Hey Vlad, Thanks for taking time to look at this! The xmlRealloc calls in xinclude.c seems to exhibit the same problem, have you considered fixing them? Not in this late build for a few reasons: -less change/less risk for this last build -in the latest libxml2 source they have not been change

Re: [userland-discuss] Code review requested for libxml2...

2011-09-11 Thread Vladimir Marek
Hi Kevin! > Looking for a review of libxml2 fixes: > https://cr.opensolaris.org/action/browse/userland/kc28005/libxml2/webrev/ > > Requesting feedback from Craig & Laszlo - but anyone else that can > review this and provide feedback in this late build would be much > appreciated also! The xmlRea

[userland-discuss] Code review requested for libxml2...

2011-09-11 Thread Kevin Crowe
Hello, Looking for a review of libxml2 fixes: https://cr.opensolaris.org/action/browse/userland/kc28005/libxml2/webrev/ Requesting feedback from Craig & Laszlo - but anyone else that can review this and provide feedback in this late build would be much appreciated also! Thanks, Kevin.