Re: Bug in TopicSubscription (wrong log message?)

2015-03-02 Thread Kevin Burton
Gotcha. That makes sense. OK. On Sun, Mar 1, 2015 at 6:31 PM, Tim Bain tb...@alumni.duke.edu wrote: The statement is right, because the other 1x is in the consumer's prefetch buffer. It's a bit confusing that the word pending in the log line counts both the pending queue on the broker and

Bug in TopicSubscription (wrong log message?)

2015-03-01 Thread Kevin Burton
This looks like a but. The log message is hard wired to say “*twice* its prefetch limit pending” but the if statement doesn’t have anything like a 2x modifier. So perhaps this log line just needs to be re-written? If you guys agree I’ll create a JIRA for it. if

Re: Bug in TopicSubscription (wrong log message?)

2015-03-01 Thread Tim Bain
The statement is right, because the other 1x is in the consumer's prefetch buffer. It's a bit confusing that the word pending in the log line counts both the pending queue on the broker and the prefetch buffer on the client, but the intent is definitely right. If you have a better word