aggregate EIP: wrong correlation key set for aggregate exchanges

2023-11-19 Thread Dinu Pavithran
I am seeing wrong correlation key is set for the first exchange emitted from aggregate EIP.  In the log below,  Exchange[7F40FFF506AA26C-000D] is aggregating with correlation key: batch-1, but when this exchange is emitted, the property  CamelAggregatedCorrelationKey is set as

Re: Jetty Component how to add additional steps after send http response back to the client

2023-11-19 Thread ski n
Or take a look at the wire tap pattern: https://camel.apache.org/components/4.0.x/eips/wireTap-eip.html Raymond On Sun, Nov 19, 2023 at 2:05 PM Claus Ibsen wrote: > Hi > > You can also look at using onCompletion > https://camel.apache.org/manual/oncompletion.html > > On Sat, Nov 18, 2023 at

Re: Question about Lombok use

2023-11-19 Thread Steve973
Claus (and others), Thank you for sharing your thoughts. I do not think any of that is harsh, because it makes perfect logical sense, and it is what I figured. I thought I would ask, just in case. I apologize if my questions were annoying, and/or a waste of time. Even though I asked these

Re: Question about Lombok use

2023-11-19 Thread Grzegorz Grzybek
Big -1 for Lombok from me. I fully agree with Andrea and Claus about this. Especially #4 - debugging problems. Saving few lines in Java code which would take you a minute to write, comparing to seconds of lombok annotation is nothing comparing to maintenance pain over years. Been there, done

Re: Question about Lombok use

2023-11-19 Thread Claus Ibsen
Hi Okay it may sound harsh when I and other long term Camel core team members say No to X or Y. However its a very large code base and a project that is ongoing for decades, currently 16 and half years old. People come and go, and it's important that everything in Camel can be picked up and

Re: Question about Lombok use

2023-11-19 Thread Steve973
If the component codebase is java-only, is it permissible to use test frameworks that use other JVM languages? I am talking about things like Spock or Kotest. On Sun, Nov 19, 2023 at 9:21 AM Steve973 wrote: > Oh, regarding my other question, which might have gotten lost among the > bigger

Re: Question about Lombok use

2023-11-19 Thread Steve973
Oh, regarding my other question, which might have gotten lost among the bigger discussion about Lombok: is the camel component codebase java-only, or is Kotlin also ok? On Sun, Nov 19, 2023 at 9:20 AM Steve973 wrote: > Thanks, Andra, for the informative reply. I understand and appreciate >

Re: Question about Lombok use

2023-11-19 Thread Steve973
Thanks, Andra, for the informative reply. I understand and appreciate your assessment, and it seems like the correct decision for Apache Camel, given your reasoning. That clears a lot of things up for me. My questions are only out of curiosity, so I hope this discussion is reasonable and

Re: Question about Lombok use

2023-11-19 Thread Andrea Cosentino
Last but not least, there are no clear, IMO, advantages is using it, despite the fact you'll see less boilerplate code. This laziness is something I don't understand. IDEs will generate setters/getters for you just with a shortcut on classes with thousands of fields. Il giorno dom 19 nov 2023

Re: Question about Lombok use

2023-11-19 Thread Andrea Cosentino
Hello, Let me add also add a couple of points: 1. It's true that is just a compile dependency but when you decide to use lombok, you also decide that everyone else who deals with your code will have to use lombok. Lombok is special in that it is a build-time dependency and your IDE needs plugins

Re: Question about Lombok use

2023-11-19 Thread Steve973
Does that preference extend to compile-time only, as well? The scope of lombok is always set to "provided", so it is never included at runtime. I am also curious if any components can be written in other JVM languages, such as Kotlin (since camel includes the Kotlin DSL), or if it's java-only.

Re: Question about Lombok use

2023-11-19 Thread Claus Ibsen
Hi No lombok is not allowed - we have as minimal dependency as possible. On Sun, Nov 19, 2023 at 2:06 PM Steve973 wrote: > Hello. I completely understand the perspective of limiting the addition of > libraries for various reasons, and especially when the library is included > in the

Question about Lombok use

2023-11-19 Thread Steve973
Hello. I completely understand the perspective of limiting the addition of libraries for various reasons, and especially when the library is included in the distribution. I know that I have asked about Lombok before, but it is great for eliminating a lot of boilerplate code, especially when a

Re: Jetty Component how to add additional steps after send http response back to the client

2023-11-19 Thread Claus Ibsen
Hi You can also look at using onCompletion https://camel.apache.org/manual/oncompletion.html On Sat, Nov 18, 2023 at 8:36 PM Claus Ibsen wrote: > Hi > > I would also add that HTTP servers like Tomcat, Jetty, JBoss etc have an > access log that logs how long time each request takes. And they

Re: How to check if an message on an exchange has attachments?

2023-11-19 Thread Claus Ibsen
Hi I am adding a function to simple language so this can be done via simple in the future https://issues.apache.org/jira/browse/CAMEL-20127 At first its a bit long in the tooth ${messageAs(org.apache.camel.language.simple.MyAttachmentMessage).hasAttachments} On Sun, Nov 19, 2023 at 12:55 PM

Re: Is URI redirection possible?

2023-11-19 Thread Steve973
Thanks, Claus. That is good to know. On Sun, Nov 19, 2023 at 6:54 AM Claus Ibsen wrote: > Hi > > We have migration guides so it's fine to add in the docs that end users > need to migrate. > Also since its isolated to a single component then most users is not > affected in any way. > > > > > >

Re: How to check if an message on an exchange has attachments?

2023-11-19 Thread Claus Ibsen
Hi You can look in the source of camel-attachments and see how they are stored and then do it by checking for exchange property key CamelAttachmentObjects exists and is not empty On Tue, Nov 14, 2023 at 9:21 PM ski n wrote: > As a workaround, I implemented it as follows: > > public class

Re: Is URI redirection possible?

2023-11-19 Thread Claus Ibsen
Hi We have migration guides so it's fine to add in the docs that end users need to migrate. Also since its isolated to a single component then most users is not affected in any way. On Sun, Nov 19, 2023 at 12:50 PM Steve973 wrote: > Hello. In a component, if I want to change the format of

Is URI redirection possible?

2023-11-19 Thread Steve973
Hello. In a component, if I want to change the format of a URI, and still want to retain compatibility with the previous URI format, is there a way (within the module) to redirect to the new URI after translation? I want to split some functionality off to another endpoint. So, rather than