Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-18 Thread Omar Al-Safi
are not known to > Camel. And other "complex" Camel components do have that. That is my main > point of view. Do you want me to create an issue for this? > > Erik > > -Opprinnelig melding- > Fra: Claus Ibsen > Sendt: søndag 13. oktober 2019 18:19 > Til: u

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-18 Thread Erik Boye
e: [SUSPECT URL !]Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint? Hi Omar Yeah the maven plugin idea is really good. But maybe we need both. The maven plugin will only get you the options of the kafka version that was used for that release. With

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Jean-Baptiste Onofré
That's my point: maven plugin is good, but I would like to give a chance for the users to give their own bean. For instance, personally, I would probably prefer to create my own bean because I know Kafka, I know Camel, I know what I need/want ;) Regards JB On 13/10/2019 18:18, Claus Ibsen wrote:

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Omar Al-Safi
Hi Claus, I agree with you that we will need both, especially on these configurations that are related to Confluent platform which are ported back to the community as you mentioned. I have created a JIRA ticket for it here: https://issues.apache.org/jira/browse/CAMEL-14062, I will work on it once

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Claus Ibsen
Hi Omar Yeah the maven plugin idea is really good. But maybe we need both. The maven plugin will only get you the options of the kafka version that was used for that release. With having a way for end users to set extra options then they could work against newer Kafka versions without Camel have

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Omar Al-Safi
Hi JB, Thanks for the feedback. The way I am doing it now in my PoC branch is that, the maven plugin will generate camel configuration beans when the component is being built by calling the plugin in the generate-sources maven phase, therefore the resulting JAR will include these configurations as

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Jean-Baptiste Onofré
Hi, IMHO, I think maven plugin is fine if it's still generate a bean. We have to provide configuration via a bean and/or URI for most for users. We have to think about non-Maven users like Gradle or script users. Regards JB On 13/10/2019 14:30, Omar Al-Safi wrote: > Hi Claus, > > I also thought

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Omar Al-Safi
Hi Claus, I also thought about this, however since Kafka producers/consumers options increase and some of them may gets deprecated, I was thinking we can have a maven plugin that generate these configurations for us without the need to do it manually, it will generate using the configDef (e.g: htt

Re: Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-13 Thread Claus Ibsen
Hi Yeah this has come up a few times that Kafka is adding new options, or more particularly Confluent adds propriety options that they dont give back to the community. Can you create a JIRA ticket. Then we can look at adding a way to add custom options. You are of course welcome to try to implem

Configuring custom Kafka producer/consumer properties on Camel Kafka component/endpoint?

2019-10-08 Thread Erik Boye
Hi, Is there any way to configure custom Kafka producer/consumer properties on the Camel Kafka component/endpoint (without "breaking in")? I specifically want to configure the Confluent Kafka property with key 'value.subject.name.strategy': https://docs.confluent.io/current/schema-registry/seri