Re: JAXB marshaller & control characters

2010-01-12 Thread Pavel
Ha, I thought EasyMock was alreay a framework of choice. As that's not the case, I'm going to give Mockito a try and convert camel-jaxb tests. If all goes well I'll get back with a patch after the weekend. Thanks, Pavel On Sat, Jan 9, 2010 at 7:48 AM, Claus Ibsen wrote: > On Fri, Jan 8, 2010 at

Re: JAXB marshaller & control characters

2010-01-09 Thread Willem Jiang
Hi Pavel, I just committed your patch with some of my change. I added a comment in the JIRA[1], please check it out. Now we need update the wiki page and finish the FallbackTypeConverter marshal part. I will keep on working them tomorrow. [1] https://issues.apache.org/activemq/browse/CAMEL-23

Re: JAXB marshaller & control characters

2010-01-08 Thread Claus Ibsen
On Fri, Jan 8, 2010 at 7:38 PM, Stephen Gargan wrote: > Pavel, > > Mock Frameworks are a subjective kind of thing, but I've had a lot of > luck with Mockito. It's DSL (And we're fans of good DSLs round here ;) > ) is really clean and succinct and the Argument Capture I've found > indispensible. >

Re: JAXB marshaller & control characters

2010-01-08 Thread Stephen Gargan
Pavel, Mock Frameworks are a subjective kind of thing, but I've had a lot of luck with Mockito. It's DSL (And we're fans of good DSLs round here ;) ) is really clean and succinct and the Argument Capture I've found indispensible. http://www.mockito.org/ And I've also found Mycila very useful for

Re: JAXB marshaller & control characters

2010-01-08 Thread Willem Jiang
Hi Pavel, We need to do the change 1, 2 at the same time. My old patch can't deal with this situation from("direct:getJAXBElementValue") .unmarshal(new JaxbDataFormat("org.apache.camel.foo.bar")) .to("mock:result"); It's very late for my time, I wil

Re: JAXB marshaller & control characters

2010-01-08 Thread Pavel
Me again. I'm trying to hook my writer to the right place and I got confused a bit. There are several places that do marshalling/unmarshalling. 1. JaxbDataFormat - this is what I think normally steps in when route needs to marshal/unmarshal something. 2. FallbackTypeConverter - if I read camel do

Re: JAXB marshaller & control characters

2010-01-08 Thread Willem Jiang
Hi Pavel, I think it is OK for us use EasyMock 2.5 as it just for testing. Look forward your XmlStream* solution :) Willem Pavel wrote: Hi, I attached test to JIRA. I'll see if I can put together Xml-based approach; will write back on that. BTW, do you guys have any objections against updat

Re: JAXB marshaller & control characters

2010-01-08 Thread Pavel
Hi, I attached test to JIRA. I'll see if I can put together Xml-based approach; will write back on that. BTW, do you guys have any objections against updating EasyMock dependency to 2.5? Thanks, Pavel On Fri, Jan 8, 2010 at 5:37 AM, Willem Jiang wrote: > Hi Pavel, > > It's good to keep improv

Re: JAXB marshaller & control characters

2010-01-07 Thread Willem Jiang
Hi Pavel, It's good to keep improving this feature by discussing :) For the marshal part, I'd like to see your solution which use the XmlStreamWriter filtering :) We can add the option in the JAXBDataFormat to turn on or turn off the filtering. I didn't found the patch of test in your last

Re: JAXB marshaller & control characters

2010-01-07 Thread Pavel
Hi again, I did look at the implementation and I have some thoughts and comments. * This addresses how Camel-JAXB reads XML, which is good. But another aspect is how Camel-JAXB produces XML. E.g. in the case I was hitting, camel/jaxb was marshalling "bad" data that could not be unmarshalled on th

Re: JAXB marshaller & control characters

2010-01-07 Thread Pavel
Hi Willem, I'm looking into it. It could take some time due to holidays I have, but I'll come back with feedback as soon as I have it. Pavel On Thu, Jan 7, 2010 at 10:49 AM, Willem Jiang wrote: > Hi Pavel, > > I committed the patch for CAMEL-2330, You can find the JaxbFilterReader > code here[1

Re: JAXB marshaller & control characters

2010-01-07 Thread Willem Jiang
Hi Pavel, I committed the patch for CAMEL-2330, You can find the JaxbFilterReader code here[1]. Please check out last Apache Camel 2.2-SNAPSHOT to verify it. [1] https://svn.apache.org/repos/asf/camel/trunk/components/camel-jaxb/src/main/java/org/apache/camel/converter/jaxb/JaxbFilterReader.j

Re: JAXB marshaller & control characters

2010-01-04 Thread Willem Jiang
I just filled a JIRA[1] for adding an out of box support in camel-jaxb. So you don't need to use covertTo() DSL any more. [1] https://issues.apache.org/activemq/browse/CAMEL-2330 Willem Willem Jiang wrote: Hi, I think you can write a type converter[1] which can turn the InputStream to a JAX

Re: JAXB marshaller & control characters

2010-01-01 Thread Willem Jiang
Hi, I think you can write a type converter[1] which can turn the InputStream to a JAXB safe (which filters the control characters) InputStream. Then can define your route like this from("direct:start").covertTo(JaxbSafeInputStream.class).unmarshal(new JaxbDataFormat("org.apache.camel.example

Re: JAXB marshaller & control characters

2010-01-01 Thread Pavel
I found a few relevant links: http://old.nabble.com/UTF-8-characters-jaxb-td25531336.html#a25531336 http://www.w3.org/TR/2004/REC-xml-20040204/#NT-Char Seems like this topic was discussed already, but I'm not if relevant replacement mechanism made it into camel. Pavel On Thu, Dec 31, 2009 at 3:

JAXB marshaller & control characters

2009-12-31 Thread Pavel
Hi, I'm looking for the way to filter out control characters prohibited by XML spec at/after marshalling. Otherwise consumers are unable to unmarshal the content. Is there an out of the box means for doing that? If not, can you recommend the right way for doing that? I just did similar exercise