Re: File idempotent store problem

2018-01-16 Thread Claus Ibsen
Hi Yeah I can see the point that its better to have the default implementation work better. I have reworked the implementation so the file store and cache are independent and the cache is only used for quick lookup. Also the default sizes of the file store has been increased to allow storing more

Re: File idempotent store problem

2018-01-04 Thread Onder SEZGIN
There are points i agree/disagree. This can stay as the limitation imho. Because using cache as fifo sounds a bit advance care of idempotent repository feature and it would require taking all the burdens of such implementation for a single minor feature by diving into caffeine. This would be too mu

Re: File idempotent store problem

2018-01-03 Thread Krzysztof Hołdanowicz
Hi, regarding CAMEL-12058 I don't know if you are aware of all consequences of wrong order in the idempotent file store. The wrong order in the file is not the problem itself as long as elemens are added and eviceted on runtime, because caffeine provides an api for ordering like: - @Override p

Re: File idempotent store problem

2017-12-02 Thread Krzysztof Hołdanowicz
I don't know if I understood you correctly. Instead of looping via cache.keySet() you mean looping via: Map.Entry entry : cache.entrySet() or cache.foreach((k, v) -> {...})? If yes what is the difference? Isn't it the same unordered collection? If Caffeince returns unordered collection how we can

Re: File idempotent store problem

2017-11-28 Thread Claus Ibsen
Hi Ah well spotted. I think we should for loop via Map.Entry (or (k,v) via lambda) which I think will be in the correct order. You are welcome to log a JIRA. And also work on unit test and patch. http://camel.apache.org/contributing On Tue, Nov 28, 2017 at 8:55 AM, Krzysztof Hołdanowicz wrote: