Re: ACS upgrade to Log4J2 version 2.19

2023-05-29 Thread Rohit Yadav
based mini-pc server with Ubuntu 22.04 + KVM. Regards. From: João Jandre Paraquetti Sent: Friday, May 26, 2023 20:04 To: d...@cloudstack.apache.org ; users@cloudstack.apache.org Subject: Re: ACS upgrade to Log4J2 version 2.19 Hi Rohit, > PR has issues w

Re: ACS upgrade to Log4J2 version 2.19

2023-05-26 Thread João Jandre Paraquetti
enough for merging; I think the vote was a bit early and unnecessary. I encourage authors and the community to continue the discussions here and stabilise the PR. Thanks and regards. From: Daan Hoogland Sent: Wednesday, May 17, 2023 18:16 To:d...@cloudstack

Re: ACS upgrade to Log4J2 version 2.19

2023-05-26 Thread Rohit Yadav
rly and unnecessary. I encourage authors and the community to continue the discussions here and stabilise the PR. Thanks and regards. From: Daan Hoogland Sent: Wednesday, May 17, 2023 18:16 To: d...@cloudstack.apache.org Cc: users@cloudstack.apache.org Subj

Re: ACS upgrade to Log4J2 version 2.19

2023-05-17 Thread Daan Hoogland
uest over others, or > for > > > > that matter one library vs another; however, as with anything that > > > impacts > > > > the community, potentially cause overhead/work, the community must > try > > to > > > > review the facts, pros, and

Re: ACS upgrade to Log4J2 version 2.19

2023-05-16 Thread João Jandre Paraquetti
e. I like Daan's suggestion of having a log-agnostic logging utility if it's possible to accommodate. Regards. From: Daniel Salvador Sent: Thursday, May 11, 2023 05:43 To: users@cloudstack.apache.org Cc: d...@cloudstack.apache.org Subject: Re: ACS upg

Re: ACS upgrade to Log4J2 version 2.19

2023-05-13 Thread Rohit Yadav
ible to accommodate. Regards. From: Daniel Salvador Sent: Thursday, May 11, 2023 05:43 To: users@cloudstack.apache.org Cc: d...@cloudstack.apache.org Subject: Re: ACS upgrade to Log4J2 version 2.19 Daan, IMHO, proxying libraries would bring us more disadvantages than b

Re: ACS upgrade to Log4J2 version 2.19

2023-05-10 Thread Daniel Salvador
The changes are huge so reviewing 100% is not possible, are the scope > > > > changes strictly logging replacement or there are other changes? > > > > > > > > What is the current state of the PR, is it ready? Has anybody looked > at > > > > the

Re: ACS upgrade to Log4J2 version 2.19

2023-05-09 Thread Daan Hoogland
I can think off, and initiatives such as > getting > > the go-sdk and terraform plugin donated in the community took long and > > painful months to get them done. In all these cases, the issue of having > > daily conflicts or building consensus, or having to wait long term was > >

Re: ACS upgrade to Log4J2 version 2.19

2023-05-05 Thread Daniel Salvador
In all these cases, the issue of having > daily conflicts or building consensus, or having to wait long term was > unavoidable and painful to stakeholders, but in hindsight they were the > right approaches compliant to ASF, the community did the right thing for > themselves. > > >

Re: ACS upgrade to Log4J2 version 2.19

2023-05-03 Thread Rohit Yadav
have > shown that logback's AsyncAppender is both simpler and significantly > faster. > > 2) at least one downstream appender is slow > > In which case, the very large buffer will slowly fill up, possibly > exhausting available memory. More importantly, in case the application

Re: ACS upgrade to Log4J2 version 2.19

2023-05-03 Thread Daniel Salvador
gt; 2) at least one downstream appender is slow > > In which case, the very large buffer will slowly fill up, possibly > exhausting available memory. More importantly, in case the application > is stopped, this will result in large amount of logging data to be lost, > which is far from

Re: ACS upgrade to Log4J2 version 2.19

2023-05-03 Thread Rohit Yadav
Regards. From: Abhishek Kumar Sent: Wednesday, May 3, 2023 15:16 To: users@cloudstack.apache.org Cc: d...@cloudstack.apache.org Subject: Re: ACS upgrade to Log4J2 version 2.19 Hi Daniel, It was just my opinion it is based on the reasons that it is something tha

Re: ACS upgrade to Log4J2 version 2.19

2023-05-03 Thread Abhishek Kumar
Hi Daniel, It was just my opinion it is based on the reasons that it is something that we haven't seen any request in the community before and it will create some challenges for the releases, forward-merging bug-fixes and also for any existing integrations that users might be having. To be specifi

Re: ACS upgrade to Log4J2 version 2.19

2023-05-02 Thread Sidimar Carniel
Hello, I'm +1 on implementing this change, the importance has already been well explained. Improving any process has a degree of difficulty, but it can be a great improvement and help in future versions. As there are volunteers for this improvement, this PR is important for the evolution of Cloud

Re: ACS upgrade to Log4J2 version 2.19

2023-05-02 Thread Nux
Hi Daniel and all, With my PMC hat on, I'm +1 on implementing this PR. "The show must go on" as they say. I also see no reason this should wait for 5.0, there is nothing special about v5 that I know of, it's just a number. The PR is indeed quite large and it has the potential to "inconvenie

Re: ACS upgrade to Log4J2 version 2.19

2023-05-01 Thread Daniel Salvador
Abhishek, I do not see why it would be a 5.0 change. Also, ACS 5.0 is a discussion the community has been having for a long time from now and is something we are too far away to achieve consensus. The patch is important to enable further development for the log management on ACS and facilitate ev

Re: ACS upgrade to Log4J2 version 2.19

2023-05-01 Thread Abhishek Kumar
Great work. Though I feel this is a 5.0 change. I agree with Wei that this would create too much overhead for upcoming releases. 4.18 was pushed ahead a few months and we may end up on a similar path. Also, reload4j is still actively maintained so I don't think this is urgent. Regards, Abhishek O

Re: ACS upgrade to Log4J2 version 2.19

2023-04-28 Thread Daniel Salvador
Hello guys, Thanks, Felipe Rossi for the reply, operators are a vital part of the community and your opinions are of the greatest importance to the project's advancement. I already did a lot of tests with the patch and I think we are in a good way to place it. I am +1 on it. Regarding Wei's conc

Re: ACS upgrade to Log4J2 version 2.19

2023-04-28 Thread Wei ZHOU
Hi Joao, Thanks for bringing this to our attention. I am +1 with log4j 2.x. It is not urgent to me, as we are currently using reload4j which is still well maintained: https://mvnrepository.com/artifact/ch.qos.reload4j/reload4j My concern is, you have made a huge amount of rename of variables, fo

Re: ACS upgrade to Log4J2 version 2.19

2023-04-28 Thread Felipe Rossi
Hello everyone, This upgrade is fundamental, because log4j is deprecated, not possible to make new updates/upgrades. with log4j2 we can expand, receive new upgrades/updates, with maintenance of a secure environment and evolution. the importance of this is not questionable. Att / Regards Felipe

ACS upgrade to Log4J2 version 2.19

2023-04-28 Thread João Jandre Paraquetti
In PR #7131 (https://github.com/apache/cloudstack/pull/7131) I have proposed to normalize ACS's loggers, and more importantly, upgrade the library log4j to log4j2 version 2.19. Log4j2 has a lot of features that could offer benefits to ACS: * Async Loggers - performance similar to logging swit